Status Update
No update yet.
Comments
cl...@gmail.com
The issue turns out to be a problem with how the requestFocus() was being called. in updateFocusRectInWindowSnapshot, there is a check for isFocused that should also consider hasFocus(). The line should be changed from:
if (!view.isFocused) {
to
if (!view.isFocused && !view.hasFocus()) {
ma...@google.com
ma...@google.com
ap...@google.com
Resolved the original issues by using the correct rect value. However the focus shouldn't skip focus even with incorrect value. re-open the issue for investigation purpose. Thank you!
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: George Mount <
Link:
Fix requestFocus with bad previous rectangle
Expand for full commit details
Fix requestFocus with bad previous rectangle
Fixes: 388590015
When requestFocus() is called on a ComposeView with a previousRect
set to something that doesn't make sense (empty rectangle from the
wrong direction, for example), the previous behavior would not
find a matching component in that direction. Instead, it would
find the next View to focus on and pass the focus on.
With this CL, if the ComposeView isn't currently focused and a
focusSearch fails to find something focusable in relation to the
previous rectangle, an attempt is made irrespective of the
previous rectangle.
Relnote: "Fixed focus issue where requestFocus() with a
nonsensical previouslyFocusedRect parameter (related to
the focus direction) would skip past a ComposeView."
Test: new test, manual testing
Change-Id: Ifdc2f17b23620d1ae14848624f447f84cc1b0b5d
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt - M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
Hash: 8501eec732d61bd71c385a90f58a194191816d57
Date: Fri Jan 10 11:04:59 2025
ma...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.ui:ui-android:1.8.0-beta01androidx.compose.ui:ui-jvmstubs:1.8.0-beta01androidx.compose.ui:ui-linuxx64stubs:1.8.0-beta01
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.8.0-alpha07androidx.compose.material:material-android:1.8.0-alpha07androidx.compose.material:material-jvmstubs:1.8.0-alpha07androidx.compose.material:material-linuxx64stubs:1.8.0-alpha07androidx.compose.ui:ui:1.8.0-alpha07androidx.compose.ui:ui-android:1.8.0-alpha07androidx.compose.ui:ui-jvmstubs:1.8.0-alpha07androidx.compose.ui:ui-linuxx64stubs:1.8.0-alpha07
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <
Link:
Clip indicator line to text field shape
Expand for full commit details
Clip indicator line to text field shape
Another approach, replacing aosp/3387263.
Now, only the indicator line is clipped instead
of the entire text field.
Bug: b/380704151
Test: added screenshot tests
Relnote: "`Modifier.indicatorLine` now takes a shape for the text field to handle clipping."
Change-Id: I8c5f31cc77134107ae7895a273895f71ee6b2cc6
Files:
- M
compose/material3/material3/api/current.txt - M
compose/material3/material3/api/restricted_current.txt - M
compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TextFieldScreenshotTest.kt - M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextField.kt - M
compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextFieldDefaults.kt
Hash: de96373ca0f3f3bdc29c7b9aaeb98ac449eca1b4
Date: Mon Dec 09 22:18:43 2024
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.4.0-alpha06androidx.compose.material3:material3-android:1.4.0-alpha06androidx.compose.material3:material3-jvmstubs:1.4.0-alpha06androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha06
Description
Description has been deleted.