SecureTextField Active indicator does not get clipped with Modifier.clip [380704151]

Fixed

Bug

Status Update

No update yet.

Description

cl...@gmail.com

created issue #1

Nov 25, 2024 06:23AM

Description has been deleted.

deleted

0 B

deleted

0 B

Comments

cl...@gmail.com <cl...@gmail.com> #2Nov 25, 2024 07:18AM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

bug.png

8.7 KB

View

Download

intended.png

4.7 KB

View

Download

ma...@google.com <ma...@google.com> Dec 2, 2024 04:56PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> Dec 2, 2024 05:02PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #3Dec 3, 2024 08:21PM

Thanks for the report!

ap...@google.com <ap...@google.com> #4Dec 3, 2024 08:21PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

ma...@google.com <ma...@google.com> #5Dec 3, 2024 09:06PM

Marked as fixed.

deleted

pr...@google.com <pr...@google.com> #6Dec 11, 2024 06:27PM

In my case, I have multiple font sizes in the same Text (using SpanStyle in AnnotatedString). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).

ap...@google.com <ap...@google.com> #7Dec 11, 2024 07:25PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Max Alfonso-Ying <maxying@google.com>
Link: https://android-review.googlesource.com/3400559

Clip indicator line to text field shape

Expand for full commit details

Clip indicator line to text field shape 
 
Another approach, replacing aosp/3387263. 
Now, only the indicator line is clipped instead 
of the entire text field. 
 
Bug: b/380704151 
Test: added screenshot tests 
Relnote: "`Modifier.indicatorLine` now takes a shape for the text field to handle clipping." 
Change-Id: I8c5f31cc77134107ae7895a273895f71ee6b2cc6

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/TextFieldScreenshotTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextField.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextFieldDefaults.kt

Hash: de96373ca0f3f3bdc29c7b9aaeb98ac449eca1b4
Date: Mon Dec 09 22:18:43 2024

pr...@google.com <pr...@google.com> #8Jan 15, 2025 06:31PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.4.0-alpha06
androidx.compose.material3:material3-android:1.4.0-alpha06
androidx.compose.material3:material3-jvmstubs:1.4.0-alpha06
androidx.compose.material3:material3-linuxx64stubs:1.4.0-alpha06