IndexOutOfBoundsException Inconsistency detected. Invalid view holder adapter when updating paging to 3.3.4 [381024738]

Fixed

Bug

Status Update

No update yet.

Description

st...@viber.com

created issue #1

Nov 26, 2024 04:18PM

Despite the fact that bug https://issuetracker.google.com/issues/343124454 is marked as fixed, it's still reproduced after updating from 3.2.1 to 3.3.4. I created a sample project to demonstrate it.

Steps to reproduce:

open the app
quickly scroll down the list
switch tabs while scrolling
if there is no crash, go back and repeat the steps 2-3

java.lang.IndexOutOfBoundsException: Inconsistency detected. Invalid item position 156(offset:156).state:1000 androidx.recyclerview.widget.RecyclerView{e95134d VFED..... ........ 0,367-1080,2205 #7f08016c app:id/recycler}, adapter:com.example.badsearch.MainRecyclerAdapter@be8de02, layout:androidx.recyclerview.widget.LinearLayoutManager@d575313, context:com.example.badsearch.MainActivity@3b66302 at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6364) at androidx.recyclerview.widget.GapWorker.prefetchPositionWithDeadline(GapWorker.java:288) at androidx.recyclerview.widget.GapWorker.flushTaskWithDeadline(GapWorker.java:345) at androidx.recyclerview.widget.GapWorker.flushTasksWithDeadline(GapWorker.java:361) at androidx.recyclerview.widget.GapWorker.prefetch(GapWorker.java:368) at androidx.recyclerview.widget.GapWorker.run(GapWorker.java:399) at android.os.Handler.handleCallback(Handler.java:958) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:230) at android.os.Looper.loop(Looper.java:319) at android.app.ActivityThread.main(ActivityThread.java:9063) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:588) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1103)

Paging3ScrollBug.zip

114 KB

Download

Comments

st...@viber.com <st...@viber.com> #2Nov 27, 2024 06:28AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

cl...@google.com <cl...@google.com> #3Nov 27, 2024 06:46PM

Accepted by cl...@google.com.

Yeah the bug has to do with races introduced in 3.3.0 when we refactored PagingDataPresenter to make it common friendly.

The class is now decoupled from any specific UI (it was previously coupled to RecyclerView), but now there are races between RecyclerView and AsyncPagingDataDiffer. Working on a fix right now.

ap...@google.com <ap...@google.com> #4Dec 4, 2024 05:58PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3390907

Fix race between presenter update and RV

Expand for full commit details

Fix race between presenter update and RV 
 
In a previous CL aosp/3315349 we made previousPresenter reset within the computeDiff worker context to ensure that reset happens even if the refresh is interrupted. However, this introduced a race where RV work on main thread would be executed after presenter reset (meaning AsyncPagingDataDiffer now refers to the new presenter). This led to RV getting the wrong itemCount (it expects itemCount from old list rather than new list). 
 
To prevent this, we need to ensure that RV work cannot be executed in between presenter reset and dispatchDiff. To do this, we move presenter reset back onto main thread to ensure no RV work can occur at least until presentPagingDataEvent completes. 
 
Test: ./gradlew paging:paging-runtime:cC 
Bug: 381024738 
Relnote: "Fixed bug where RecyclerView throws IndexOutOfBoundsException when user scrolls while updating RecyclerView" 
Change-Id: Id1f16a1e2cc0286458659d0bf63cf59ab3399b93

Files:

M paging/paging-runtime/src/androidTest/java/androidx/paging/AsyncPagingDataDifferTest.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt

Hash: 837b71a5f455e57626b61c2ccc7fadce8a00b3bf
Date: Tue Dec 03 20:48:20 2024

cl...@google.com <cl...@google.com> #5Dec 4, 2024 06:07PM

Marked as fixed.

Fixed and available in paging 3.3.5

pr...@google.com <pr...@google.com> #6Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.paging:paging-runtime:3.3.5

va...@gmail.com <va...@gmail.com> #7Dec 16, 2024 03:16PM

Yes. It is only partially fixed. I upgraded to 3.3.5 and while I'm getting less crashes, I still get them as you can see in the screenshots.

Screenshot 2024-12-16 at 23.14.46.png

305 KB

View

Download

Screenshot 2024-12-16 at 23.14.54.png

230 KB

View

Download

Screenshot 2024-12-16 at 23.15.03.png

315 KB

View

Download

cl...@google.com <cl...@google.com> #8Dec 17, 2024 05:13PM

comment#7 can you please file a separate bug and upload a sample that reproduces the issue?

ma...@kayak.com <ma...@kayak.com> #9Feb 6, 2025 11:25PM

We're encountering the same issue in production. Although it happens infrequently, a fix would be greatly appreciated. I tried reproducing it in the sample project but was unsuccessful. Based on the logs and breadcrumbs, it appears to occur when navigating to a different activity while more results are still loading, and then returning to the previous screen while the local data source is being updated. Below are the stack traces in case they offer any insights:

androidx.paging.PageStore.checkIndex (PageStore.kt:56)
androidx.paging.PageStore.get (PageStore.kt)
androidx.paging.PagingDataPresenter.get (PagingDataPresenter.kt:278)
androidx.paging.AsyncPagingDataDiffer.getItem (AsyncPagingDataDiffer.kt:460)
androidx.paging.PagingDataAdapter.getItem (PagingDataAdapter.kt:302)
.....
androidx.recyclerview.widget.NestedAdapterWrapper.getItemViewType (NestedAdapterWrapper.java:146)
androidx.recyclerview.widget.ConcatAdapterController.getItemViewType (ConcatAdapterController.java:319)
androidx.recyclerview.widget.ConcatAdapter.getItemViewType (ConcatAdapter.java:178)
androidx.recyclerview.widget.RecyclerView$Recycler.validateViewHolderForOffsetPosition (RecyclerView.java:6594)
androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline (RecyclerView.java:6796)

cl...@google.com <cl...@google.com> #10Feb 7, 2025 08:37PM

comment#9 your stack trace indicate the problem could be different from the original bug.

I tried reproing your issue with a sample app to no avail. I'd like to get to the bottom of this though - it would really help if either your or comment#7 can repro this reliably.

ja...@go-text.me <ja...@go-text.me> #11Feb 10, 2025 03:59PM

We're unable to upgrade past 3.2.1 otherwise we get this crash. We've tried to upgrade since 3.3.1 but every version has this crash. We're unable to reproduce locally, but it's happening in the wild. As such I don't have a sample project that's able to reproduce. Is this on someone's radar to fix? Thank you.

          Fatal Exception: java.lang.IndexOutOfBoundsException: Inconsistency detected. Invalid view holder adapter positionInboxSectionViewHolder{a814017 position=3 id=-1, oldPos=1, pLpos:1 scrap [attachedScrap] tmpDetached no parent} androidx.recyclerview.widget.RecyclerView{caf350 VFED..... ......I. 0,0-1080,1683 #7f0a0909 app:id/recycler_view_inbox}, adapter:com.textmeinc.textme3.ui.activity.main.inbox.adapter.v2.InboxAdapter2@17ca774, layout:androidx.recyclerview.widget.LinearLayoutManager@c6c2949, context:dagger.hilt.android.internal.managers.p@4c8d829
       at androidx.recyclerview.widget.RecyclerView$Recycler.validateViewHolderForOffsetPosition(RecyclerView.java:6686)
       at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6892)
       at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6853)
       at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6849)
       at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2422)
       at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1722)
       at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1682)
       at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:747)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep1(RecyclerView.java:4683)
       at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4457)
       at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:5011)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.onLayout(SwipeRefreshLayout.java:625)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at androidx.constraintlayout.widget.ConstraintLayout.onLayout(ConstraintLayout.java:1961)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:374)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:312)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
       at android.widget.LinearLayout.layoutHorizontal(LinearLayout.java:1818)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1584)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at androidx.constraintlayout.widget.ConstraintLayout.onLayout(ConstraintLayout.java:1961)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:374)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:312)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:374)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:312)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:374)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:312)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1829)
       at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1673)
       at android.widget.LinearLayout.onLayout(LinearLayout.java:1582)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at android.widget.FrameLayout.layoutChildren(FrameLayout.java:374)
       at android.widget.FrameLayout.onLayout(FrameLayout.java:312)
       at com.android.internal.policy.DecorView.onLayout(DecorView.java:1330)
       at android.view.View.layout(View.java:24461)
       at android.view.ViewGroup.layout(ViewGroup.java:7412)
       at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4609)
       at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:4031)
       at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2919)
       at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:10491)
       at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1108)
       at android.view.Choreographer.doCallbacks(Choreographer.java:866)
       at android.view.Choreographer.doFrame(Choreographer.java:797)
       at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1092)
       at android.os.Handler.handleCallback(Handler.java:938)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:226)
       at android.os.Looper.loop(Looper.java:313)
       at android.app.ActivityThread.main(ActivityThread.java:8663)
       at java.lang.reflect.Method.invoke(Method.java)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:567)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)
        ```

cl...@google.com <cl...@google.com> #12Feb 10, 2025 07:31PM

comment#11 - Do you also still get this in 3.3.5?

ja...@go-text.me <ja...@go-text.me> #13Feb 10, 2025 07:35PM

Yes we do, stacktrace is from app using 3.3.5

Issue 381024738

Description

Issue summary

Comments

st...@viber.com <st...@viber.com> #2Nov 27, 2024 06:28AM

cl...@google.com <cl...@google.com> #3Nov 27, 2024 06:46PM

ap...@google.com <ap...@google.com> #4Dec 4, 2024 05:58PM

cl...@google.com <cl...@google.com> #5Dec 4, 2024 06:07PM

pr...@google.com <pr...@google.com> #6Dec 11, 2024 06:27PM

va...@gmail.com <va...@gmail.com> #7Dec 16, 2024 03:16PM

cl...@google.com <cl...@google.com> #8Dec 17, 2024 05:13PM

ma...@kayak.com <ma...@kayak.com> #9Feb 6, 2025 11:25PM

cl...@google.com <cl...@google.com> #10Feb 7, 2025 08:37PM

ja...@go-text.me <ja...@go-text.me> #11Feb 10, 2025 03:59PM

cl...@google.com <cl...@google.com> #12Feb 10, 2025 07:31PM

ja...@go-text.me <ja...@go-text.me> #13Feb 10, 2025 07:35PM

Add comment

Issue metadata