Add `recreate` support in `ViewModelScenario` [381063087]

Fixed

Feature Request

Status Update

No update yet.

Description

mg...@google.com

created issue #1

Nov 26, 2024 02:27PM

Add a recreate API in ViewModelScenario, which simulates a System Process Death recreating the ViewModel and all associated components. The new API allow to verify that a ViewModel correctly preserves and restores its state.

Comments

ap...@google.com <ap...@google.com> #2Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375898

Set robolectric in lifecycle-viewmodel-testing

Expand for full commit details

Set `robolectric` in `lifecycle-viewmodel-testing` 
 
Bug: 381063087 
Test: ViewModelScenarioTest 
Change-Id: Ia5466af402a10291c10e45662b6b5d9a76748a34

Files:

M lifecycle/lifecycle-viewmodel-testing/build.gradle

Hash: 52a8c8438f3522eced0edfc243419179796cd9e1
Date: Tue Nov 26 11:46:10 2024

ap...@google.com <ap...@google.com> #4Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375899

Add RobolectricTest to lifecycle-viewmodel-testing

Expand for full commit details

Add `RobolectricTest` to `lifecycle-viewmodel-testing` 
 
Bug: 381063087 
Test: ViewModelScenarioTest 
Change-Id: Ia80fcf0ccc49f232247de97a3046f445854f5203

Files:

A lifecycle/lifecycle-viewmodel-testing/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/testing/RobolectricTest.android.kt
A lifecycle/lifecycle-viewmodel-testing/src/androidUnitTest/kotlin/androidx/lifecycle/viewmodel/testing/RobolectricTest.android.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonTest/kotlin/androidx/lifecycle/viewmodel/testing/DefaultCreationExtrasTest.kt
A lifecycle/lifecycle-viewmodel-testing/src/commonTest/kotlin/androidx/lifecycle/viewmodel/testing/RobolectricTest.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonTest/kotlin/androidx/lifecycle/viewmodel/testing/ViewModelScenarioTest.kt
A lifecycle/lifecycle-viewmodel-testing/src/nonAndroidTest/kotlin/androidx/lifecycle/viewmodel/testing/RobolectricTest.nonAndroid.kt

Hash: 70cfbc46068bdf9899d15020498a7e49641b3a53
Date: Tue Nov 26 11:53:48 2024

ap...@google.com <ap...@google.com> #5Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375896

Move ViewModelScenarioTest.kt to commonTest

Expand for full commit details

Move `ViewModelScenarioTest.kt` to `commonTest` 
 
Bug: 381063087 
Test: ViewModelScenarioTest 
Change-Id: I33c5c0722229adbc841ba63e728c6d772e76be14

Files:

D lifecycle/lifecycle-viewmodel-testing/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/testing/ViewModelScenarioInstrumentedTest.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonTest/kotlin/androidx/lifecycle/viewmodel/testing/ViewModelScenarioTest.kt

Hash: 958948fdd1f1d62bdc73f9440ae21235b9b51410
Date: Tue Nov 26 11:30:08 2024

ap...@google.com <ap...@google.com> #6Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375895

Move DefaultCreationExtrasInstrumentedTest.kt to commonTest

Expand for full commit details

Move `DefaultCreationExtrasInstrumentedTest.kt` to ` commonTest` 
 
Bug: 381063087 
Test: DefaultCreationExtrasTest 
Change-Id: Ia9f21a6f565fe9099c7eeae1e4a4810978d34823

Files:

M lifecycle/lifecycle-viewmodel-testing/src/commonTest/kotlin/androidx/lifecycle/viewmodel/testing/DefaultCreationExtrasTest.kt

Hash: 4efdb54584aec42a44e9cca75034266063c5b525
Date: Tue Nov 26 11:24:24 2024

ap...@google.com <ap...@google.com> #7Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375894

Set nonAndroidMain in lifecycle-viewmodel-testing

Expand for full commit details

Set `nonAndroidMain` in `lifecycle-viewmodel-testing` 
 
Bug: 381063087 
Test: N/A 
Change-Id: I069c3bdb8c760a0a0c57ce1382822a4fe7081b45

Files:

M lifecycle/lifecycle-viewmodel-testing/build.gradle

Hash: b246e058d4dbe08bced04661053a7487fe954868
Date: Tue Nov 26 10:58:12 2024

ap...@google.com <ap...@google.com> #8Dec 3, 2024 11:20PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375897

Add recreate to ViewModelScenario

Expand for full commit details

Add `recreate` to `ViewModelScenario` 
 
* Allows a `ViewModelScenario` to simulate a System Process Death recreating the ViewModel and all associated components. 
 
RelNote: "Add `ViewModelScenario.recreate` to simulate a System Process Death recreating the ViewModel under test and all associated components." 
Bug: 381063087 
Test: ViewModelScenarioTest 
Change-Id: Id6a696888ce900c573e47c6c93e4ac9df1881e6b

Files:

M lifecycle/lifecycle-viewmodel-testing/api/current.txt
M lifecycle/lifecycle-viewmodel-testing/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-testing/bcv/native/current.txt
A lifecycle/lifecycle-viewmodel-testing/src/androidMain/kotlin/androidx/lifecycle/viewmodel/testing/internal/ViewModelScenarioOwner.android.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonMain/kotlin/androidx/lifecycle/viewmodel/testing/DefaultCreationExtras.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonMain/kotlin/androidx/lifecycle/viewmodel/testing/ViewModelScenario.kt
A lifecycle/lifecycle-viewmodel-testing/src/commonMain/kotlin/androidx/lifecycle/viewmodel/testing/internal/ViewModelScenarioOwner.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonTest/kotlin/androidx/lifecycle/viewmodel/testing/ViewModelScenarioTest.kt
A lifecycle/lifecycle-viewmodel-testing/src/nonAndroidMain/kotlin/androidx/lifecycle/viewmodel/testing/internal/ViewModelScenarioOwner.nonAndroid.kt

Hash: b6898682f3319ed640cf86f6cb4b578bfad38dba
Date: Tue Nov 26 10:59:19 2024

mg...@google.com <mg...@google.com> Dec 4, 2024 02:31PM

Marked as fixed.

ap...@google.com <ap...@google.com> #9Dec 4, 2024 11:26PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3393199

Add size limit check to ViewModelScenario.recreate

Expand for full commit details

Add size limit check to `ViewModelScenario.recreate` 
 
* Detects excessively large SavedStates. 
 
Bug: 381063087 
Test: ViewModelScenarioTest 
Change-Id: I61f51bc99cd8679c93f07c2d260ef9291a85346d

Files:

M lifecycle/lifecycle-viewmodel-testing/src/androidMain/kotlin/androidx/lifecycle/viewmodel/testing/internal/ViewModelScenarioOwner.android.kt
A lifecycle/lifecycle-viewmodel-testing/src/androidUnitTest/kotlin/androidx/lifecycle/viewmodel/testing/AndroidViewModelScenarioTest.kt

Hash: c9717402010d49a1a3ad9aac04ee606bdcd3e389
Date: Wed Dec 04 18:26:56 2024

pr...@google.com <pr...@google.com> #10Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-viewmodel-testing:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-android:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-desktop:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-iosarm64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-iossimulatorarm64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-iosx64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-linuxarm64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-linuxx64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-macosarm64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-macosx64:2.9.0-alpha08

Issue 381063087

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #3Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #4Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #5Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #6Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #7Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #8Dec 3, 2024 11:20PM

mg...@google.com <mg...@google.com> Dec 4, 2024 02:31PM

ap...@google.com <ap...@google.com> #9Dec 4, 2024 11:26PM

pr...@google.com <pr...@google.com> #10Dec 11, 2024 06:27PM

Add comment

Issue metadata