Add `recreate` support in `ViewModelScenario` [381063087]

Fixed

Feature Request

Status Update

No update yet.

Description

mg...@google.com

created issue #1

Nov 26, 2024 02:27PM

Add a recreate API in ViewModelScenario, which simulates a System Process Death recreating the ViewModel and all associated components. The new API allow to verify that a ViewModel correctly preserves and restores its state.

Comments

ap...@google.com <ap...@google.com> #2Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ap...@google.com <ap...@google.com> #3Dec 3, 2024 10:39AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375896

Move ViewModelScenarioTest.kt to commonTest

Expand for full commit details

Move `ViewModelScenarioTest.kt` to `commonTest` 
 
Bug: 381063087 
Test: ViewModelScenarioTest 
Change-Id: I33c5c0722229adbc841ba63e728c6d772e76be14

Files:

D lifecycle/lifecycle-viewmodel-testing/src/androidInstrumentedTest/kotlin/androidx/lifecycle/viewmodel/testing/ViewModelScenarioInstrumentedTest.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonTest/kotlin/androidx/lifecycle/viewmodel/testing/ViewModelScenarioTest.kt

Hash: 958948fdd1f1d62bdc73f9440ae21235b9b51410
Date: Tue Nov 26 11:30:08 2024

ap...@google.com <ap...@google.com> #6Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375895

Move DefaultCreationExtrasInstrumentedTest.kt to commonTest

Expand for full commit details

Move `DefaultCreationExtrasInstrumentedTest.kt` to ` commonTest` 
 
Bug: 381063087 
Test: DefaultCreationExtrasTest 
Change-Id: Ia9f21a6f565fe9099c7eeae1e4a4810978d34823

Files:

M lifecycle/lifecycle-viewmodel-testing/src/commonTest/kotlin/androidx/lifecycle/viewmodel/testing/DefaultCreationExtrasTest.kt

Hash: 4efdb54584aec42a44e9cca75034266063c5b525
Date: Tue Nov 26 11:24:24 2024

ap...@google.com <ap...@google.com> #7Dec 3, 2024 10:39AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375894

Set nonAndroidMain in lifecycle-viewmodel-testing

Expand for full commit details

Set `nonAndroidMain` in `lifecycle-viewmodel-testing` 
 
Bug: 381063087 
Test: N/A 
Change-Id: I069c3bdb8c760a0a0c57ce1382822a4fe7081b45

Files:

M lifecycle/lifecycle-viewmodel-testing/build.gradle

Hash: b246e058d4dbe08bced04661053a7487fe954868
Date: Tue Nov 26 10:58:12 2024

ap...@google.com <ap...@google.com> #8Dec 3, 2024 11:20PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3375897

Add recreate to ViewModelScenario

Expand for full commit details

Add `recreate` to `ViewModelScenario` 
 
* Allows a `ViewModelScenario` to simulate a System Process Death recreating the ViewModel and all associated components. 
 
RelNote: "Add `ViewModelScenario.recreate` to simulate a System Process Death recreating the ViewModel under test and all associated components." 
Bug: 381063087 
Test: ViewModelScenarioTest 
Change-Id: Id6a696888ce900c573e47c6c93e4ac9df1881e6b

Files:

M lifecycle/lifecycle-viewmodel-testing/api/current.txt
M lifecycle/lifecycle-viewmodel-testing/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-testing/bcv/native/current.txt
A lifecycle/lifecycle-viewmodel-testing/src/androidMain/kotlin/androidx/lifecycle/viewmodel/testing/internal/ViewModelScenarioOwner.android.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonMain/kotlin/androidx/lifecycle/viewmodel/testing/DefaultCreationExtras.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonMain/kotlin/androidx/lifecycle/viewmodel/testing/ViewModelScenario.kt
A lifecycle/lifecycle-viewmodel-testing/src/commonMain/kotlin/androidx/lifecycle/viewmodel/testing/internal/ViewModelScenarioOwner.kt
M lifecycle/lifecycle-viewmodel-testing/src/commonTest/kotlin/androidx/lifecycle/viewmodel/testing/ViewModelScenarioTest.kt
A lifecycle/lifecycle-viewmodel-testing/src/nonAndroidMain/kotlin/androidx/lifecycle/viewmodel/testing/internal/ViewModelScenarioOwner.nonAndroid.kt

Hash: b6898682f3319ed640cf86f6cb4b578bfad38dba
Date: Tue Nov 26 10:59:19 2024

mg...@google.com <mg...@google.com> Dec 4, 2024 02:31PM

Marked as fixed.

ap...@google.com <ap...@google.com> #9Dec 4, 2024 11:26PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Galhardo <mgalhardo@google.com>
Link: https://android-review.googlesource.com/3393199

Add size limit check to ViewModelScenario.recreate

Expand for full commit details

Add size limit check to `ViewModelScenario.recreate` 
 
* Detects excessively large SavedStates. 
 
Bug: 381063087 
Test: ViewModelScenarioTest 
Change-Id: I61f51bc99cd8679c93f07c2d260ef9291a85346d

Files:

M lifecycle/lifecycle-viewmodel-testing/src/androidMain/kotlin/androidx/lifecycle/viewmodel/testing/internal/ViewModelScenarioOwner.android.kt
A lifecycle/lifecycle-viewmodel-testing/src/androidUnitTest/kotlin/androidx/lifecycle/viewmodel/testing/AndroidViewModelScenarioTest.kt

Hash: c9717402010d49a1a3ad9aac04ee606bdcd3e389
Date: Wed Dec 04 18:26:56 2024

pr...@google.com <pr...@google.com> #10Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.lifecycle:lifecycle-viewmodel-testing:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-android:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-desktop:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-iosarm64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-iossimulatorarm64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-iosx64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-linuxarm64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-linuxx64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-macosarm64:2.9.0-alpha08
androidx.lifecycle:lifecycle-viewmodel-testing-macosx64:2.9.0-alpha08

Issue 381063087

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #3Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #4Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #5Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #6Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #7Dec 3, 2024 10:39AM

ap...@google.com <ap...@google.com> #8Dec 3, 2024 11:20PM

mg...@google.com <mg...@google.com> Dec 4, 2024 02:31PM

ap...@google.com <ap...@google.com> #9Dec 4, 2024 11:26PM

pr...@google.com <pr...@google.com> #10Dec 11, 2024 06:27PM

Add comment

Issue metadata