PerfettoTraceProcessor tied to Android, limits portability of querying code [381134564]

Assigned

Feature Request

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Nov 26, 2024 10:28PM

Metric queries and insights would benefit from iterating on host, while currently PerfettoTraceProcessor can only run on Android.

First step here would be decoupling PerfettoTraceProcessor API from our trace_processor_shell android binary.

Follow ups could improve portability:

bundled trace_processor_shell for jvm on host
Metric / Insight APIs move to androidx.benchmark.traceprocessor

Comments

ys...@google.com <ys...@google.com> #2Nov 27, 2024 10:53AM

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

cc...@google.com <cc...@google.com> #3Dec 4, 2024 12:16AM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

Message last modified on Dec 4, 2024 12:16AM

ap...@google.com <ap...@google.com> #4Dec 11, 2024 06:47PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

ap...@google.com <ap...@google.com> #5Dec 11, 2024 06:47PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Chris Craik <ccraik@google.com>
Link: https://android-review.googlesource.com/3390906

Add initial, empty benchmark-traceprocessor

Expand for full commit details

Add initial, empty benchmark-traceprocessor 
 
Bug: 381134564 
Test: N/A 
Relnote: N/A 
 
Change-Id: If3e85be06a29ad105f3eb1d21090531772204e6f

Files:

A benchmark/benchmark-traceprocessor/api/current.txt
A benchmark/benchmark-traceprocessor/api/res-current.txt
A benchmark/benchmark-traceprocessor/api/restricted_current.txt
A benchmark/benchmark-traceprocessor/build.gradle
M docs-tip-of-tree/build.gradle
M settings.gradle

Hash: 6c7159fd997ef48fa0f3c5b12c85c2938e47d64a
Date: Tue Dec 03 16:07:21 2024

cc...@google.com <cc...@google.com> #6Dec 11, 2024 09:01PM

Reverted due to build breakage.

ap...@google.com <ap...@google.com> #7Dec 13, 2024 07:28PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Chris Craik <ccraik@google.com>
Link: https://android-review.googlesource.com/3408688

Reland "Move PerfettoTraceProcessor -> TraceProcessor in benchmark-traceprocessor"

Expand for full commit details

Reland "Move PerfettoTraceProcessor -> TraceProcessor in benchmark-traceprocessor" 
 
Bug: 381134564 
Bug: 382741383 
Test: Tests in benchmark-macro 
Test: TraceProcessorBenchmark 
Test: ./gradlew :docs-tip-of-tree:docs 
 
Revert submission 3407319-revert-3376991-QEQTPRWJDK 
 
Reason for revert: dependent change aosp/3394905 was reverted, but has since relanded as aosp/3406159 
 
Reverted changes: /q/submissionid:3407319-revert-3376991-QEQTPRWJDK 
 
Relnote: """Move PerfettoTraceProcessor to TraceProcessor in a new 
androidx.benchmark:benchmark-traceprocessor artifact, and make most of 
its API non-experimental. Any custom TraceMetric or anything reading 
from traces will need to update to the new TraceProcessor import. The 
new TraceProcessor API works exactly like the old one, but is a 
standalone interface library (somewhat analogous to the androidx.sql 
layer from Room) with an Android-specific implementation built into 
macrobenchmark. The new artifact can be used on JVM as well, but 
currently you'll need to start your own copy of the TraceProcessor 
binary and offer a port to connect to it on.""" 
 
This works around a crash in the docs build by moving 
package-info.java out of commonMain to both jvmMain/androidMain. 
 
Change-Id: I3a7675f25f4425745b6f255dcd1a0cec81a068ba

Files:

M benchmark/benchmark-common/api/current.txt
M benchmark/benchmark-common/api/restricted_current.txt
M benchmark/benchmark-common/build.gradle
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/PerfettoTraceTest.kt
D benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoTrace.kt
A benchmark/benchmark-common/src/main/java/androidx/benchmark/traceprocessor/PerfettoTrace.kt
M benchmark/benchmark-junit4/api/current.txt
M benchmark/benchmark-junit4/api/restricted_current.txt
M benchmark/benchmark-junit4/src/main/java/androidx/benchmark/junit4/PerfettoTraceRule.kt
M benchmark/benchmark-macro-junit4/build.gradle
A benchmark/benchmark-macro/api/current.ignore
M benchmark/benchmark-macro/api/current.txt
A benchmark/benchmark-macro/api/restricted_current.ignore
M benchmark/benchmark-macro/api/restricted_current.txt
M benchmark/benchmark-macro/build.gradle
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/ArtMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/InsightTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PerfettoTraceRuleTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PowerMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/AndroidxTracingTraceTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/BatteryDischargeQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/MemoryCountersQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/MemoryUsageQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoCaptureSweepTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkTraceTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PowerQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/StartupTimingQueryTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/traceprocessor/RowTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/traceprocessor/SliceTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/traceprocessor/TraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkPhase.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
A benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/TraceProcessorExtensions.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/BatteryDischargeQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/FrameTimingQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/MemoryCountersQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/MemoryUsageQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/PowerQuery.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StartupInsights.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/StartupTimingQuery.kt
D benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/perfetto/server/PerfettoHttpServer.kt
M benchmark/benchmark-traceprocessor/api/current.txt
M benchmark/benchmark-traceprocessor/api/restricted_current.txt
M benchmark/benchmark-traceprocessor/build.gradle
A benchmark/benchmark-traceprocessor/src/androidMain/kotlin/androidx/benchmark/traceprocessor/Log.android.kt
A benchmark/benchmark-traceprocessor/src/androidMain/kotlin/perfetto/protos/package-info.java
M benchmark/benchmark-traceprocessor/src/commonMain/kotlin/androidx/benchmark/traceprocessor/ExperimentalTraceProcessorApi.kt
A benchmark/benchmark-traceprocessor/src/commonMain/kotlin/androidx/benchmark/traceprocessor/Log.kt
A benchmark/benchmark-traceprocessor/src/commonMain/kotlin/androidx/benchmark/traceprocessor/PerfettoTrace.kt
M benchmark/benchmark-traceprocessor/src/commonMain/kotlin/androidx/benchmark/traceprocessor/QueryResultIterator.kt
M benchmark/benchmark-traceprocessor/src/commonMain/kotlin/androidx/benchmark/traceprocessor/Row.kt
A benchmark/benchmark-traceprocessor/src/commonMain/kotlin/androidx/benchmark/traceprocessor/ServerLifecycleManager.kt
M benchmark/benchmark-traceprocessor/src/commonMain/kotlin/androidx/benchmark/traceprocessor/Slice.kt
M benchmark/benchmark-traceprocessor/src/commonMain/kotlin/androidx/benchmark/traceprocessor/TraceProcessor.kt
A benchmark/benchmark-traceprocessor/src/commonMain/kotlin/androidx/benchmark/traceprocessor/TraceProcessorHttpServer.kt
A benchmark/benchmark-traceprocessor/src/jvmMain/kotlin/androidx/benchmark/traceprocessor/Log.jvm.kt
A benchmark/benchmark-traceprocessor/src/jvmMain/kotlin/perfetto/protos/package-info.java
M benchmark/integration-tests/macrobenchmark/src/main/java/androidx/benchmark/integration/macrobenchmark/TraceProcessorBenchmark.kt
M wear/compose/compose-material3/macrobenchmark/src/main/java/androidx/wear/compose/material3/macrobenchmark/metric/FrameCostQuery.kt
M wear/compose/compose-material3/macrobenchmark/src/main/java/androidx/wear/compose/material3/macrobenchmark/metric/Metric.kt
M wear/compose/integration-tests/macrobenchmark/src/main/java/androidx/wear/compose/integration/macrobenchmark/CompositionMetric.kt

Hash: a13168a07a6545e9614541c28bf4ab19a2f6523e
Date: Thu Dec 12 09:48:11 2024

cc...@google.com <cc...@google.com> #8Jan 10, 2025 10:03PM

Reassigned to ra...@google.com.

Over to Rahul, who was looking at landing the host artifacts to make this work trivially on JVM

gr...@google.com <gr...@google.com> #9Jan 15, 2025 12:18PM

Good news! Wear Compose has been updated to ab/12816344 in

https://critique.corp.google.com/cl/715723139 and this bug has been affected.

na...@google.com <na...@google.com> #10Feb 3, 2025 03:23PM

Is this the same issue as b/299504225 which limits us from using it on device effectively?

Message last modified on Feb 3, 2025 03:23PM