Build variant specific Dagger generated classes in Baseline Profiles [381211719]

Assigned

Bug

Status Update

No update yet.

Description

li...@gmail.com

created issue #1

Nov 27, 2024 12:49PM

Component used: Benchmarks and Baseline Profiles Version used: 1.3.0

Hi Baseline profiles are expected to be generated on a non-minified release build type. If such is missing, the baseline profiles plugin created one for us.

So, I'm using that nonMinifiedRelease built type to generate baseline profiles. Today I've been reviewing the generated profile and spotted that it contains Dagger 2 generated classes, which have build variant in their names. For example:

HSPLorg/mycompany/feature/common/ui/di/module/DatabaseModule;->provideDataModelDynamicRealmFactory$app_prodServerNonMinifiedRelease(Lorg/mycompany/cache/db/DatabaseConfigurator;)Lorg/mycompany/core/base/cache/db/configuration/DynamicRealmFactory;

Obviously, in the real release version of the app the app_prodServerNonMinifiedRelease part will be app_prodServerRelease. So, these entries in the generated profile seem to bring no benefit and even may be a little harmful.

How cases like these are expected to be handled?

Comments

li...@gmail.com <li...@gmail.com> #2Nov 30, 2024 04:03PM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

Please provide sample project or apk to reproduce the issue. Also mention the steps to be followed for reproducing the issue with the given sample project or apk.

Expected output
What is the expected output?

Current output
What is the current output?

cc...@google.com <cc...@google.com> #3Jan 6, 2025 11:29PM

Reassigned to ma...@google.com.

How can you possibly need more information, i just told you the exact part of code causing the issue, and the code changes required to fix it!
Please read the description.

Expected output:
What is the expected output?
See attached "expected.webm" video in OP

Current output
What is the current output?
See attached "actual.webm" video in OP

ma...@google.com <ma...@google.com> #4Jan 6, 2025 11:34PM

1. Import attached project
2. Install and run on Android 5 (Lollipop) or above
3. Click FAB and see it fall below/behind the navigation bar once the Snackbar disappear

Message last modified on Jan 6, 2025 11:40PM

li...@gmail.com <li...@gmail.com> #5Jan 7, 2025 02:38PM

Could you please check the attached project as we couldn't extract the files from it.

da...@google.com <da...@google.com> #6Jan 7, 2025 02:51PM

It's a RAR archive, there's no issue with it.
However you have problems extracting such, here's the same content as a ZIP archive.

li...@gmail.com <li...@gmail.com> #7Jan 7, 2025 05:06PM

Thank you for reporting this issue. We have shared this with our product and engineering team and will update this issue with more information as it becomes available.

ma...@google.com <ma...@google.com> #8Jan 7, 2025 05:07PM

@ coordinator layout,

Please check this issue and provide your inputs.