apksigner unable to handle aliases that begin with less than four characters followed by a space on Windows [38132450]

Fixed

Bug

[AOSP] win

Migrated-Tools-windows

Migrated-Tools-build

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 8, 2017 09:15PM

On Windows, apksigner says that unexpected characters were present if the alias name begins with less than four characters followed by a space (e.g. "bug apksigner test"). This is a valid alias name, but apksigner seems to have difficulty parsing it on Windows. This issue does not happen on the Linux version of apksigner.

Below is a contrived example to demonstrate the issue, as well as the working version on a Linux system. Since the keystore and APK passed in do not exist, the expected result is a FileNotFoundException. This was chosen to remove any possibility of malformed files interfering with the result, but the issue was first observed with a real keystore and APK.

***Windows Server 2008 R2***

C:\>java -version
java version "1.8.0_131"
Java(TM) SE Runtime Environment (build 1.8.0_131-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)

C:\>"C:\Program Files (x86)\Android\android-sdk\build-tools\25.0.3\apksigner" --version

0.5

C:\>"C:\Program Files (x86)\Android\android-sdk\build-tools\25.0.3\apksigner" sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bug apksigner test" nonexistent.apk

a was unexpected at this time.

C:\>"C:\Program Files (x86)\Android\android-sdk\build-tools\25.0.3\apksigner" sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "b apksigner test" nonexistent.apk

apk was unexpected at this time.

C:\>"C:\Program Files (x86)\Android\android-sdk\build-tools\25.0.3\apksigner" sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bugr apksigner test" nonexistent.apk

Failed to load signer "signer #1"
java.io.FileNotFoundException: nonexistent.jks (The system cannot find the file specified)
at java.io.FileInputStream.open0(Native Method)
at java.io.FileInputStream.open(FileInputStream.java:195)
at java.io.FileInputStream.<init>(FileInputStream.java:138)
at java.io.FileInputStream.<init>(FileInputStream.java:93)
at com.android.apksigner.ApkSignerTool$SignerParams.loadKeyStoreFromFile(ApkSignerTool.java:733)
at com.android.apksigner.ApkSignerTool$SignerParams.loadPrivateKeyAndCertsFromKeyStore(ApkSignerTool.java:636)
at com.android.apksigner.ApkSignerTool$SignerParams.loadPrivateKeyAndCerts(ApkSignerTool.java:580)
at com.android.apksigner.ApkSignerTool$SignerParams.access$200(ApkSignerTool.java:534)
at com.android.apksigner.ApkSignerTool.sign(ApkSignerTool.java:229)
at com.android.apksigner.ApkSignerTool.main(ApkSignerTool.java:87)

***Ubuntu 16.04***

> java -version
java version "1.8.0_131"
Java(TM) SE Runtime Environment (build 1.8.0_131-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)

> /opt/android-sdk/build-tools/25.0.3/apksigner --version

0.5

> /opt/android-sdk/build-tools/25.0.3/apksigner sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bug apksigner test" nonexistent.apk

Failed to load signer "signer #1"
java.io.FileNotFoundException: nonexistent.jks (No such file or directory)
at java.io.FileInputStream.open0(Native Method)
at java.io.FileInputStream.open(FileInputStream.java:195)
at java.io.FileInputStream.<init>(FileInputStream.java:138)
at java.io.FileInputStream.<init>(FileInputStream.java:93)
at com.android.apksigner.ApkSignerTool$SignerParams.loadKeyStoreFromFile(ApkSignerTool.java:733)
at com.android.apksigner.ApkSignerTool$SignerParams.loadPrivateKeyAndCertsFromKeyStore(ApkSignerTool.java:636)
at com.android.apksigner.ApkSignerTool$SignerParams.loadPrivateKeyAndCerts(ApkSignerTool.java:580)
at com.android.apksigner.ApkSignerTool$SignerParams.access$200(ApkSignerTool.java:534)
at com.android.apksigner.ApkSignerTool.sign(ApkSignerTool.java:229)
at com.android.apksigner.ApkSignerTool.main(ApkSignerTool.java:87)

Comments

en...@google.com <en...@google.com> May 10, 2017 06:20PM

Assigned to kl...@google.com.

kl...@google.com <kl...@google.com> #2May 11, 2017 12:02AM

Accepted by kl...@google.com.

These changes would be really nice! Being able to change the text colour is really important as it now doesn't match the rest of our app either.

Stack overflow posting -

http://stackoverflow.com/questions/32533069/how-to-change-a-title-color-in-chrome-custom-tabs

apksigner.bat

2.7 KB

Download

[Deleted User] <[Deleted User]> #3May 11, 2017 05:41PM

Changing text color and the overflow icon color is important to us too! Awesome work on the feature though.

ap...@google.com <ap...@google.com> #4May 22, 2017 07:54PM

The ability of customize the status bar color is very important!

ap...@google.com <ap...@google.com> #5Jun 22, 2017 06:56PM

It is in the essence of a "custom" UI component to have a custom color. Please add this feature!

kl...@google.com <kl...@google.com> #6Jul 25, 2017 07:34PM

Marked as fixed.

I have noted that the status bar automatically generated from the toolbar color is a bit darker than needed. The status bar color of the chrome activity is different to the one of the rest of my app. It doesn't strictly follow Material guidelines.

Issue 38132450