apksigner unable to handle aliases that begin with less than four characters followed by a space on Windows [38132450]

Fixed

Bug

[AOSP] win

Migrated-Tools-windows

Migrated-Tools-build

Status Update

No update yet.

Description

[Deleted User]

created issue #1

May 8, 2017 09:15PM

On Windows, apksigner says that unexpected characters were present if the alias name begins with less than four characters followed by a space (e.g. "bug apksigner test"). This is a valid alias name, but apksigner seems to have difficulty parsing it on Windows. This issue does not happen on the Linux version of apksigner.

Below is a contrived example to demonstrate the issue, as well as the working version on a Linux system. Since the keystore and APK passed in do not exist, the expected result is a FileNotFoundException. This was chosen to remove any possibility of malformed files interfering with the result, but the issue was first observed with a real keystore and APK.

***Windows Server 2008 R2***

C:\>java -version
java version "1.8.0_131"
Java(TM) SE Runtime Environment (build 1.8.0_131-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)

C:\>"C:\Program Files (x86)\Android\android-sdk\build-tools\25.0.3\apksigner" --version

0.5

C:\>"C:\Program Files (x86)\Android\android-sdk\build-tools\25.0.3\apksigner" sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bug apksigner test" nonexistent.apk

a was unexpected at this time.

C:\>"C:\Program Files (x86)\Android\android-sdk\build-tools\25.0.3\apksigner" sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "b apksigner test" nonexistent.apk

apk was unexpected at this time.

C:\>"C:\Program Files (x86)\Android\android-sdk\build-tools\25.0.3\apksigner" sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bugr apksigner test" nonexistent.apk

Failed to load signer "signer #1"
java.io.FileNotFoundException: nonexistent.jks (The system cannot find the file specified)
at java.io.FileInputStream.open0(Native Method)
at java.io.FileInputStream.open(FileInputStream.java:195)
at java.io.FileInputStream.<init>(FileInputStream.java:138)
at java.io.FileInputStream.<init>(FileInputStream.java:93)
at com.android.apksigner.ApkSignerTool$SignerParams.loadKeyStoreFromFile(ApkSignerTool.java:733)
at com.android.apksigner.ApkSignerTool$SignerParams.loadPrivateKeyAndCertsFromKeyStore(ApkSignerTool.java:636)
at com.android.apksigner.ApkSignerTool$SignerParams.loadPrivateKeyAndCerts(ApkSignerTool.java:580)
at com.android.apksigner.ApkSignerTool$SignerParams.access$200(ApkSignerTool.java:534)
at com.android.apksigner.ApkSignerTool.sign(ApkSignerTool.java:229)
at com.android.apksigner.ApkSignerTool.main(ApkSignerTool.java:87)

***Ubuntu 16.04***

> java -version
java version "1.8.0_131"
Java(TM) SE Runtime Environment (build 1.8.0_131-b11)
Java HotSpot(TM) 64-Bit Server VM (build 25.131-b11, mixed mode)

> /opt/android-sdk/build-tools/25.0.3/apksigner --version

0.5

> /opt/android-sdk/build-tools/25.0.3/apksigner sign --ks "nonexistent.jks" --ks-pass pass:123123 --ks-key-alias "bug apksigner test" nonexistent.apk

Failed to load signer "signer #1"
java.io.FileNotFoundException: nonexistent.jks (No such file or directory)
at java.io.FileInputStream.open0(Native Method)
at java.io.FileInputStream.open(FileInputStream.java:195)
at java.io.FileInputStream.<init>(FileInputStream.java:138)
at java.io.FileInputStream.<init>(FileInputStream.java:93)
at com.android.apksigner.ApkSignerTool$SignerParams.loadKeyStoreFromFile(ApkSignerTool.java:733)
at com.android.apksigner.ApkSignerTool$SignerParams.loadPrivateKeyAndCertsFromKeyStore(ApkSignerTool.java:636)
at com.android.apksigner.ApkSignerTool$SignerParams.loadPrivateKeyAndCerts(ApkSignerTool.java:580)
at com.android.apksigner.ApkSignerTool$SignerParams.access$200(ApkSignerTool.java:534)
at com.android.apksigner.ApkSignerTool.sign(ApkSignerTool.java:229)
at com.android.apksigner.ApkSignerTool.main(ApkSignerTool.java:87)

Comments

en...@google.com <en...@google.com> May 10, 2017 06:20PM

Assigned to kl...@google.com.

kl...@google.com <kl...@google.com> #2May 11, 2017 12:02AM

Accepted by kl...@google.com.

Hi,

would you try to boot emulator with this command line flag:

-feature -Vulkan

and let us know if it fixes the issue for you? Also would you tell us what graphics card you are using and what is the graphics driver version?

apksigner.bat

2.7 KB

Download

[Deleted User] <[Deleted User]> #3May 11, 2017 05:41PM

The feature flag did solve the issue for me. Thank you very much. I don't use a dedicated graphics card. Only the internal one from the CPU.

ap...@google.com <ap...@google.com> #4May 22, 2017 07:54PM

Your integrated GPU is supposed to support Vulkan 1.2. I would need more work to figure out why it crashes without that flag.

ap...@google.com <ap...@google.com> #5Jun 22, 2017 06:56PM

If there is more information that I can provide please let me know.

kl...@google.com <kl...@google.com> #6Jul 25, 2017 07:34PM

Marked as fixed.

Thanks. Would you help me to try some more runs to isolate the root cause? Please try to run the emulator with this flag:

-feature -GLDirectMem,-GLDMA,-GLDMA2

I am suspecting the Vulkan direct memory access and coherent mapping is causing the issue.

Issue 38132450