navigation-common non-reified safe args API [382094941]

Fixed

Feature Request

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Dec 3, 2024 08:28PM

Add non-reified versions of reified safe args API for `navigation-common` module.

Comments

ap...@google.com <ap...@google.com> #2Dec 4, 2024 06:06PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ap...@google.com <ap...@google.com> #3Dec 4, 2024 06:09PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Dec 4, 2024 06:09PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5Dec 4, 2024 06:09PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3390361

Add non-reified NavDestinationBuilder.deepLink safe args api

Expand for full commit details

Add non-reified NavDestinationBuilder.deepLink safe args api 
 
Test: ./gradlew navigation:navigation-common:cC 
Bug: 382094941 
Relnote: "Added non-reified NavDestinationBuilder.deepLink API to add a deeplink with KClass<*>" 
Change-Id: I93281ed88fe3be9e6c68a2d5f16d9e0f335c999d

Files:

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDestinationBuilderTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestinationBuilder.kt

Hash: 3de22e912b5752790370c40acdc03de4d0985933
Date: Tue Dec 03 12:57:11 2024

ap...@google.com <ap...@google.com> #6Dec 4, 2024 06:12PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3390364

Add non-reified NavOptionsBuilder.popUpTo safe args api

Expand for full commit details

Add non-reified NavOptionsBuilder.popUpTo safe args api 
 
Test: ./gradlew navigation:navigation-common:cC 
Bug: 382094941 
Relnote: "Added non-reified NavOptionsBuilder.popUpTo API to set popUpTo destination with KClass<T>" 
Change-Id: Id09d2f511e9844b0618140781f07bebe1e7deb77

Files:

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavOptionsBuilderTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptionsBuilder.kt

Hash: e9d6539c2369ec0e0de4bccd18e890432cab86c2
Date: Tue Dec 03 14:33:41 2024

ap...@google.com <ap...@google.com> #7Dec 4, 2024 06:12PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3390365

Add non-reified NavOptions.Builder.setPopUpTo safe args api

Expand for full commit details

Add non-reified NavOptions.Builder.setPopUpTo safe args api 
 
Test: existing tests 
Bug: 382094941 
Relnote: "Added non-reified NavOptions.Builder.setPopUpTo API to set popUpTo destination with KClass<T>" 
Change-Id: I17d79479d8a1f2acda8f6767a40ff19773235d9d

Files:

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/main/java/androidx/navigation/NavOptions.kt

Hash: 30bf6328f0dac6fc20aad820586cbe88c949cae2
Date: Tue Dec 03 14:44:33 2024

ap...@google.com <ap...@google.com> #8Dec 4, 2024 08:22PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3393181

Add non-reified NavDeepLinkDSLBuilder.navDeepLink safe args api

Expand for full commit details

Add non-reified NavDeepLinkDSLBuilder.navDeepLink safe args api 
 
Test: ./gradlew navigation:navigation-common:cC 
Bug: 382094941 
Relnote: "Added non-reified NavDeepLinkDSLBuilder.navDeepLink API to add a NavDeepLink with KClass<T>" 
Change-Id: Id28791416c67c0b4930370ded037ffb3c40922b6

Files:

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkBuilderTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLinkDslBuilder.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavDestinationBuilder.kt

Hash: 1f8d26c4db6329f6a726f317b2983cd5c7d8ea78
Date: Wed Dec 04 10:30:52 2024

ap...@google.com <ap...@google.com> #9Dec 4, 2024 08:34PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3393182

Add non-reified NavGraph.setStartDestination safe args api

Expand for full commit details

Add non-reified NavGraph.setStartDestination safe args api 
 
Test: ./gradlew navigation:navigation-common:cC 
Bug: 382094941 
Relnote: "Added non-reified NavGraph.setStartDestination API to set a graph’s startDestination with KClass<T>" 
Change-Id: Ia7eed5b9c0fe15834468d3eccc489c2dc3edca74

Files:

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavGraphTest.kt
M navigation/navigation-common/src/main/java/androidx/navigation/NavGraph.kt

Hash: 9e0a95788cbe0b0f44e1bafd1c93a086aced0ccb
Date: Wed Dec 04 10:40:39 2024

cl...@google.com <cl...@google.com> #10Dec 4, 2024 09:23PM

Marked as fixed.

Fixed internally and available in navigation-2.9.0-alpha04

pr...@google.com <pr...@google.com> #11Dec 11, 2024 06:27PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.9.0-alpha04

Issue 382094941

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Dec 4, 2024 06:06PM

ap...@google.com <ap...@google.com> #3Dec 4, 2024 06:09PM

ap...@google.com <ap...@google.com> #4Dec 4, 2024 06:09PM

ap...@google.com <ap...@google.com> #5Dec 4, 2024 06:09PM

ap...@google.com <ap...@google.com> #6Dec 4, 2024 06:12PM

ap...@google.com <ap...@google.com> #7Dec 4, 2024 06:12PM

ap...@google.com <ap...@google.com> #8Dec 4, 2024 08:22PM

ap...@google.com <ap...@google.com> #9Dec 4, 2024 08:34PM

cl...@google.com <cl...@google.com> #10Dec 4, 2024 09:23PM

pr...@google.com <pr...@google.com> #11Dec 11, 2024 06:27PM

Add comment

Issue metadata