Status Update
Comments
tn...@google.com <tn...@google.com>
tn...@google.com <tn...@google.com> #2
Thanks for filing Alex. Not handling it at all would be a burden for developers to handle IMO, as it will be hard to guess what sides are handled by top/bottom app bars and what should be handled by the content manually. It is probably better than claiming all the padding automatically, I agree.
Would this make sense for scaffold to handle and consume the insets on the sides where we have top and bottom app bar, so that the rest is handled by the application? Still not ideal, but at least it is easier to wire up when nesting is involved.
an...@google.com <an...@google.com> #3
I think even in that case, the Scaffold
isn't directly handling the insets itself: the underlying component of the top bar or bottom bar is.
I think having a WindowInsets
parameter like the app bars would be enough. Then the contract could be something along the lines of "By default, the Scaffold
will inset the content to avoid the safeDrawing
, either because there is an app bar taking up at least that much space directly or because the Scaffold
will inset it."
And that could be an opt-out point as well: Passing an empty window insets would keep the old behavior, and let the insets pass down insets down the hierarchy unaltered.
Description
To repro:
Build.VERSION.SDK_INT
is above a particular value.@RequiresApi
to capture this requirement.Expected:
Lint warns me if I call this method without checking
Build.VERSION.SDK_INT
(like how the@RequiresApi
annotation works in non-test code).Actual:
Lint tells me to use
@SdkSuppress
instead (see screenshot). This doesn't seem equivalent to me, since@SdkSuppress
should only be used on public@Test
methods to allow the test runner to decide whether to run them or not. This is a private method, which won't be directly invoked by the test runner.