Lint prevents usage of RequiresApi even on private helper method in test [382253664]

Fixed

Bug

Status Update

No update yet.

Description

ib...@google.com

created issue #1

Dec 4, 2024 04:18PM

To repro:

Add a private helper method to a test which should only be called if Build.VERSION.SDK_INT is above a particular value.
Annotate this method @RequiresApi to capture this requirement.

Expected:

Lint warns me if I call this method without checking Build.VERSION.SDK_INT (like how the @RequiresApi annotation works in non-test code).

Actual:

Lint tells me to use @SdkSuppress instead (see screenshot). This doesn't seem equivalent to me, since @SdkSuppress should only be used on public @Test methods to allow the test runner to decide whether to run them or not. This is a private method, which won't be directly invoked by the test runner.

Screenshot 2024-12-04 at 16.15.00.png

100 KB

View

Download

Comments

tn...@google.com <tn...@google.com> Dec 4, 2024 04:43PM

Reassigned to tn...@google.com.

tn...@google.com <tn...@google.com> #2Dec 5, 2024 05:26AM

Marked as fixed.

More freezes

an...@google.com <an...@google.com> #3Dec 12, 2024 03:57PM

This looks to be related to either Lint or the Kotlin Plugin. Redirecting this bug to the Lint team to take a first look.

The EDT is waiting for a write lock, while the thread running Lint is blocking it with a long-running operation in a read lock. From the stack, it's not clear to me if the Lint code is doing a bunch of stuff without checking for cancellation (in which case adding cancellation checks would probably resolve this), or if it's logic within the Kotlin plugin that is blocking for a longer amount of time.

"DefaultDispatcher-worker-12" prio=0 tid=0x0 nid=0x0 runnable
     java.lang.Thread.State: RUNNABLE

	at com.intellij.platform.instanceContainer.internal.InstanceContainerImpl.getInstanceHolder(InstanceContainerImpl.kt:99)
	at com.intellij.serviceContainer.ComponentManagerImpl.doGetService(ComponentManagerImpl.kt:717)
	at com.intellij.serviceContainer.ComponentManagerImpl.getService(ComponentManagerImpl.kt:695)
	at org.jetbrains.uast.kotlin.KotlinAbstractUElement.getBaseResolveProviderService(KotlinAbstractUElement.kt:27)
	at org.jetbrains.uast.kotlin.KotlinAbstractUElement.convertParent(KotlinAbstractUElement.kt:41)
	at org.jetbrains.uast.kotlin.KotlinAbstractUElement.getUastParent(KotlinAbstractUElement.kt:34)
	at org.jetbrains.uast.UastUtils__UastUtilsKt.getParentOfType(UastUtils.kt:28)
	at org.jetbrains.uast.UastUtils.getParentOfType(Unknown Source)
	at org.jetbrains.uast.kotlin.psi.UastKotlinPsiParameter$Companion.create$kotlin_uast_uast_kotlin_base(UastKotlinPsiParameter.kt:77)
	at org.jetbrains.uast.kotlin.KotlinULambdaExpression.getParameters(KotlinULambdaExpression.kt:71)
	at org.jetbrains.uast.kotlin.KotlinULambdaExpression.getValueParameters(KotlinULambdaExpression.kt:61)
	at org.jetbrains.uast.kotlin.BaseKotlinConverter.convertParameter$lambda$41(BaseKotlinConverter.kt:413)
	at org.jetbrains.uast.kotlin.BaseKotlinConverter$$Lambda/0x0000000803cc6ed8.invoke(Unknown Source)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.accommodate$lambda$2(implementationUtils.kt:30)
	at org.jetbrains.uast.internal.ImplementationUtilsKt$$Lambda/0x00000008037dd688.invoke(Unknown Source)
	at kotlin.sequences.TransformingSequence$iterator$1.next(Sequences.kt:210)
	at kotlin.sequences.FilteringSequence$iterator$1.calcNext(Sequences.kt:170)
	at kotlin.sequences.FilteringSequence$iterator$1.hasNext(Sequences.kt:194)
	at kotlin.sequences.SequencesKt___SequencesKt.firstOrNull(_Sequences.kt:172)
	at org.jetbrains.uast.kotlin.BaseKotlinConverter.convertDeclaration(BaseKotlinConverter.kt:233)
	at org.jetbrains.uast.kotlin.BaseKotlinConverter.convertDeclarationOrElement(BaseKotlinConverter.kt:294)
	at org.jetbrains.uast.kotlin.KotlinUastLanguagePlugin.convertElementWithParent(KotlinUastLanguagePlugin.kt:53)
	at org.jetbrains.uast.UastFacade.convertElementWithParent(UastContext.kt:66)
	at org.jetbrains.uast.UastContextKt.toUElement(UastContext.kt:145)
	at org.jetbrains.uast.kotlin.BaseKotlinInternalUastUtilsKt.getMaybeLightElement(baseKotlinInternalUastUtils.kt:147)
	at org.jetbrains.uast.kotlin.KotlinInternalUastUtilsKt.resolveToDeclarationImpl(kotlinInternalUastUtils.kt:421)
	at org.jetbrains.uast.kotlin.KotlinInternalUastUtilsKt.resolveToDeclarationImpl(kotlinInternalUastUtils.kt:414)
	at org.jetbrains.uast.kotlin.KotlinUastResolveProviderService.resolveToDeclaration(KotlinUastResolveProviderService.kt:388)
	at org.jetbrains.uast.kotlin.KotlinUSimpleReferenceExpression.getResolvedDeclaration(KotlinUSimpleReferenceExpression.kt:37)
	at org.jetbrains.uast.kotlin.KotlinUSimpleReferenceExpression.resolve(KotlinUSimpleReferenceExpression.kt:44)
	at com.android.tools.lint.client.api.AnnotationHandler$checkContextAnnotations$1.visitSimpleNameReferenceExpression(AnnotationHandler.kt:219)
	at org.jetbrains.uast.kotlin.KotlinUSimpleReferenceExpression.accept(KotlinUSimpleReferenceExpression.kt:58)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:33)
	at org.jetbrains.uast.UBinaryExpression.accept(UBinaryExpression.kt:42)
	at org.jetbrains.uast.UParenthesizedExpression.accept(UParenthesizedExpression.kt:21)
	at org.jetbrains.uast.UBinaryExpression.accept(UBinaryExpression.kt:42)
	at org.jetbrains.uast.UIfExpression.accept(UIfExpression.kt:58)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.kotlin.KotlinUSimpleReferenceExpression.visitAccessorCalls(KotlinUSimpleReferenceExpression.kt:86)
	at org.jetbrains.uast.kotlin.KotlinUSimpleReferenceExpression.accept(KotlinUSimpleReferenceExpression.kt:61)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.UBinaryExpression.accept(UBinaryExpression.kt:42)
	at org.jetbrains.uast.UReturnExpression.accept(UReturnExpression.kt:22)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.UReturnExpression.accept(UReturnExpression.kt:22)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.UMethod.accept(UMethod.kt:45)
	at com.android.tools.lint.client.api.AnnotationHandler.checkContextAnnotations(AnnotationHandler.kt:214)
	at com.android.tools.lint.client.api.AnnotationHandler.visitVariable(AnnotationHandler.kt:1082)
	at com.android.tools.lint.client.api.UElementVisitor$DelegatingUastVisitor.visitVariable(UElementVisitor.kt:840)
	at org.jetbrains.uast.visitor.UastVisitor.visitParameter(UastVisitor.kt:16)
	at com.android.tools.lint.client.api.UElementVisitor$DispatchUastVisitor.visitParameter(UElementVisitor.kt:551)
	at com.android.tools.lint.client.api.UElementVisitor$DelegatingUastVisitor.visitParameter(UElementVisitor.kt:889)
	at org.jetbrains.uast.UParameter.accept(UVariable.kt:80)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.kotlin.KotlinUCatchClause.accept(KotlinUCatchClause.kt:55)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UTryExpression.accept(UTryExpression.kt:79)
	at org.jetbrains.uast.UReturnExpression.accept(UReturnExpression.kt:22)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.UReturnExpression.accept(UReturnExpression.kt:22)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.UReturnExpression.accept(UReturnExpression.kt:22)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UReturnExpression.accept(UReturnExpression.kt:22)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.UBinaryExpression.accept(UBinaryExpression.kt:43)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.kotlin.KotlinULocalVariable.accept(KotlinULocalVariable.kt:46)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UDeclarationsExpression.accept(UDeclarationsExpression.kt:22)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UExpressionList.accept(UExpressionList.kt:26)
	at org.jetbrains.uast.UReturnExpression.accept(UReturnExpression.kt:22)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.UReturnExpression.accept(UReturnExpression.kt:22)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.ULambdaExpression.accept(ULambdaExpression.kt:40)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UCallExpression.accept(UCallExpression.kt:98)
	at org.jetbrains.uast.UQualifiedReferenceExpression.accept(UQualifiedReferenceExpression.kt:34)
	at org.jetbrains.uast.UBinaryExpression.accept(UBinaryExpression.kt:43)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UBlockExpression.accept(UBlockExpression.kt:21)
	at org.jetbrains.uast.UMethod.accept(UMethod.kt:45)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.kotlin.AbstractKotlinUClass.accept(AbstractKotlinUClass.kt:213)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UFile.accept(UFile.kt:89)
	at com.android.tools.lint.detector.api.UastLintUtilsKt.acceptSourceFile(UastLintUtils.kt:992)
	at com.android.tools.lint.client.api.UElementVisitor.visitFile$lambda$5(UElementVisitor.kt:216)
	at com.android.tools.lint.client.api.UElementVisitor$$Lambda/0x0000000803fd0d58.run(Unknown Source)
	at com.intellij.openapi.application.impl.AnyThreadWriteThreadingSupport.tryRunReadAction(AnyThreadWriteThreadingSupport.kt:333)
	at com.intellij.openapi.application.impl.ApplicationImpl.tryRunReadAction(ApplicationImpl.java:971)
	at com.intellij.openapi.progress.util.ProgressIndicatorUtils.lambda$runInReadActionWithWriteActionPriority$0(ProgressIndicatorUtils.java:95)
	at com.intellij.openapi.progress.util.ProgressIndicatorUtils$$Lambda/0x0000000801625000.run(Unknown Source)
	at com.intellij.openapi.progress.util.ProgressIndicatorUtilService.runActionAndCancelBeforeWrite(ProgressIndicatorUtilService.java:66)
...

Issue 382253664

Description

Issue summary

Comments

tn...@google.com <tn...@google.com> Dec 4, 2024 04:43PM

tn...@google.com <tn...@google.com> #2Dec 5, 2024 05:26AM

an...@google.com <an...@google.com> #3Dec 12, 2024 03:57PM

Add comment

Issue metadata