IssueTracker

Project: platform/frameworks/support
Branch: androidx-main
Author: Radha Nakade <radhanakade@google.com>
Link:      https://android-review.googlesource.com/3510337

Migrate traffic from pixel2 to mediumphone on FTL emulators.

Migrate traffic from pixel2 to mediumphone on FTL emulators. 
 
Bug: 396715333 
 
Test: ./gradlew emoji2:emoji2-emojipicker:ftlmediumphoneapi33 
Change-Id: If5555443ca1a91479128e1bd6f4f909154c40ba2

Ah interesting, I didn't know about that. We have a lot of Compose custom lint checks that probably should be running on tests (we have the test scope defined in those lint checks), but I don't think adding all the IDs to this file with fatal is the best way of enabling these...

Could we consider inverting this so we just disable the specific built-in checks we don't want, and rely on the test scope as a signal for checks that should run vs not run?

Could we consider inverting this so we just disable the specific built-in checks we don't want, and rely on the test scope as a signal for checks that should run vs not run?

That would be the ideal solution, but the configuration options from lint don't really allow it.

The default behavior when checkTestSources is false is that only checks with test scope set are run on test sources. AndroidX wanted to run the NewApi check on tests, which doesn't have test scope set, and requested lint add a configuration option to enable additional checks on test sources in b/172331502. Tor said they were unlikely to add that configuration, and suggested setting checkTestSources to true, disabling all checks on tests, and reenabling specific checks. The downside of this solution is that now checks with test scope are not run on test sources unless specifically enabled. I went through what lint errors would come up if we were to stop disabling checks on tests by default, and there were some custom lint checks specifically designed for tests that currently do nothing since they aren't enabled for tests in lint.xml.

Some options of how we could update the configuration:

• Set checkTestSources to false. Of the issues enabled for test sources in lint.xml, most are in the AndroidX repo, so we can set test scope for those. The non-AndroidX checks are NewApi and WrongThread. We could make clones of these in the AndroidX lint-checks project with test scope set. (I think we could clone them without actually copying the code from the original checks because the implementation classes are accessible from the lint-checks project.)
• Keep checkTestSources true, but instead of disabling all checks on tests and reenabling some, we could disable the checks we don't want run on tests. The trouble there is that there's a very long list of checks we'd probably want to disable, and we'd need to set all the test paths to ignore for each one. We could programmatically generate the lint.xml file to make that part easier to maintain.
• Keep the current behavior of checks selectively reenabled for tests in lint.xml. Add a lint check which looks for other lint checks which have test scope set but aren't in lint.xml and suggest adding them.

ag/31807228 added the configuration we need to switch to running checks with test scope plus specified additional checks on test sources, but unfortunately NewApi, which is one of the checks we want to enable on test sources even though it does not specify test scope, still won't run on test sources -- b/398807363 to fix this.

Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <juliamcclellan@google.com>
Link:      https://android-review.googlesource.com/3517497

Add test scope to lint checks we run on test sources

Add test scope to lint checks we run on test sources 
 
These two checks are currently enabled for tests in lint.xml, but don't set test scope. 
 
Bug: 382507748 
Test: ./gradlew lint 
Change-Id: I25f8041ca4c0195480b951a9f1f3f2591fcf15ac

Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <juliamcclellan@google.com>
Link:      https://android-review.googlesource.com/3525630

Move root lint.xml config to buildSrc subdirectory

Move root lint.xml config to buildSrc subdirectory 
 
Having the file directly in buildSrc causes issues for `./gradlew buildSrc-tests:lint` when lint checks are set to run on tests in lint.xml. The configuration file was registered twice, once from the setting in LintConfiguration and once from scanning the directory. When it was picked up from scanning the directory, it caused the lint warning "The tests attribute can only be specified for lint.xml files at the module level or higher". 
 
Bug: 382507748 
Test: `./gradlew buildSrc-tests:lint` for topic 
Change-Id: I0629ac180487ac200b263caf3030739ee71c292e

Project: platform/frameworks/support
Branch: androidx-main
Author: Julia McClellan <juliamcclellan@google.com>
Link:      https://android-review.googlesource.com/3524390

Update lint configuration for test sources

Update lint configuration for test sources 
 
Instead of disabling all lint checks on test sources and then reenabling specific checks, this enables specifically the lint checks which set test scope, and also a few other checks. 
 
Bug: 382507748 
Test: `./gradlew lint` for topic 
Change-Id: Ib91c16de04df9b763788247d2e19180558630f44