Fixed
Status Update
Comments
je...@google.com <je...@google.com> #2
Would you accept external contributions for this ticket? I would gladly contribute implementation for this.
ta...@gmail.com <ta...@gmail.com> #3
Absolutely, we'd be happy to accept a pull request for this if you'd like follow our
je...@google.com <je...@google.com> #4
an...@google.com <an...@google.com>
ta...@gmail.com <ta...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Csaba Kozák <
Link:
[GH] Add support for List<Enum> arguments in typesafe navigation
Expand for full commit details
[GH] Add support for List<Enum> arguments in typesafe navigation
## Proposed Changes
Add support for List<Enum> arguments in typesafe navigation
## Testing
Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
## Issues Fixed
Fixes: 375559962
This is an imported pull request from https://github.com/androidx/androidx/pull/725.
Resolves #725
Github-Pr-Head-Sha: 79289f5cd89a355aa44ac1a7190301cde1e03ae9
GitOrigin-RevId: 5d12e8b036e98d45944806f1d16a00b0769b49e2
Change-Id: Ie67dc9665634751da06fad21c93e9475627e7e62
Files:
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteDecoderTest.kt
- M
navigation/navigation-common/src/androidTest/java/androidx/navigation/serialization/RouteFilledTest.kt
- M
navigation/navigation-common/src/main/java/androidx/navigation/serialization/NavTypeConverter.kt
- M
navigation/navigation-common/src/test/java/androidx/navigation/serialization/NavArgumentGeneratorTest.kt
- M
navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
Hash: 061287da098c4249bbe0b3a10add04feb9bdf5ae
Date: Mon Nov 18 22:24:48 2024
ap...@google.com <ap...@google.com> #6
Fixed externally and will be available in navigation 2.8.5
je...@google.com <je...@google.com>
pr...@google.com <pr...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.9.0-alpha04
androidx.navigation:navigation-runtime:2.9.0-alpha04
androidx.navigation:navigation-common:2.8.5
androidx.navigation:navigation-runtime:2.8.5
Description
Jetpack Compose version:
BOM 2024.09.00
Jetpack Compose component(s) used:
Compose Testing (createComposeRule)
Android Studio Build:
Android Studio Meerkat | 2024.3.1 Canary 3 Build #AI-243.21565.193.2431.12691553, built on November 21, 2024 Runtime version: 21.0.5+-12651406-b631.16 aarch64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Toolkit: sun.lwawt.macosx.LWCToolkit macOS 14.4.1
Steps to Reproduce or Code Sample to Reproduce:
Expected Behavior:
The default theme should prevent the ActionBar from overlapping the Compose content, as most users use themes without ActionBars in Compose-based projects. In fact, newly created Android projects use
android:Theme.Material.Light.NoActionBar
by default, which naturally avoids this issue. Updating the default testing environment to setwindowActionBar=false
would better align with typical use cases and expected behaviors.Actual Behavior:
The ActionBar is displayed and overlaps the Compose content. This leads to confusion, especially for beginners or developers trying to test simple layouts, as their content may not appear as expected.
Related links
Reproduced Repository:
https://github.com/takahirom/createComposeRule-ActionBar-Overrapping-issue/blob/main/module/src/androidTest/java/com/github/takahirom/module/ExampleInstrumentedTest.kt
Relevant Pull Request:
https://github.com/android/nowinandroid/pull/1719