createComposeRule() with Target SDK 35 causes ActionBar overlapping in default theme [383368165]

Fixed

Bug

Status Update

No update yet.

Description

ta...@gmail.com

created issue #1

Dec 11, 2024 01:54AM

Jetpack Compose version:

BOM 2024.09.00

Jetpack Compose component(s) used:

Compose Testing (createComposeRule)

Android Studio Build:

Android Studio Meerkat | 2024.3.1 Canary 3 Build #AI-243.21565.193.2431.12691553, built on November 21, 2024 Runtime version: 21.0.5+-12651406-b631.16 aarch64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Toolkit: sun.lwawt.macosx.LWCToolkit macOS 14.4.1

Steps to Reproduce or Code Sample to Reproduce:

Set the Target SDK to 35.
Use createComposeRule() in a test file without specifying a custom theme.
Run the following code in an instrumented test(androidTest):

@RunWith(AndroidJUnit4::class)
class ExampleInstrumentedTest {
    @get:Rule
    val composeTestRule = createComposeRule()

    @Test
    fun useAppContext() {
        composeTestRule.setContent {
            Text("Hello\n\n\n\n\n\n\n\n\n\n World")
        }

        Thread.sleep(10000) // Observe the UI
    }
}

Expected Behavior:
The default theme should prevent the ActionBar from overlapping the Compose content, as most users use themes without ActionBars in Compose-based projects. In fact, newly created Android projects use android:Theme.Material.Light.NoActionBar by default, which naturally avoids this issue. Updating the default testing environment to set windowActionBar=false would better align with typical use cases and expected behaviors.

Actual Behavior:
The ActionBar is displayed and overlaps the Compose content. This leads to confusion, especially for beginners or developers trying to test simple layouts, as their content may not appear as expected.

Relevant Pull Request:
https://github.com/android/nowinandroid/pull/1719

Wed Dec 11 2024 10:45:04 GMT+0900 (Japan Standard Time).png

Restricted

788 KB

View

Download

Comments

je...@google.com <je...@google.com> #2Dec 16, 2024 06:03PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

ta...@gmail.com <ta...@gmail.com> #3Dec 17, 2024 12:31AM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

je...@google.com <je...@google.com> #4Dec 17, 2024 02:34PM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

an...@google.com <an...@google.com> Dec 17, 2024 07:33PM

Assigned to je...@google.com.

ta...@gmail.com <ta...@gmail.com> #5Dec 17, 2024 11:51PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

ap...@google.com <ap...@google.com> #6Dec 20, 2024 05:40PM

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

je...@google.com <je...@google.com> Jan 6, 2025 06:56PM

Marked as fixed.

pr...@google.com <pr...@google.com> #7Jan 15, 2025 06:31PM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

IssueTracker