CoarseFineLocation lint rule doesn't account for a maxSdkVersion attribute [383595395]

Fixed

Bug

Status Update

No update yet.

Description

ey...@gmail.com

created issue #1

Dec 12, 2024 05:10AM

DESCRIBE THE ISSUE IN DETAIL:

I need to request ACCESS_FINE_LOCATION permission in my app on Android versions 30 and below in order to use BLE scanning.

Since I don't need that for versions 31 and above, I include the permission in my manifest with a maxSdkVersion:

  <uses-permission
    android:name="android.permission.ACCESS_FINE_LOCATION"
    android:maxSdkVersion="30" />

This triggers a violation of lint's CoarseFineLocation.

Comments

xi...@google.com <xi...@google.com> Dec 12, 2024 04:48PM

Assigned to an...@google.com.

tn...@google.com <tn...@google.com> Dec 12, 2024 10:07PM

Reassigned to tn...@google.com.

me...@google.com <me...@google.com> Dec 13, 2024 04:07PM

Reassigned to tn...@google.com.

tn...@google.com <tn...@google.com> #2Dec 13, 2024 06:23PM

Marked as fixed.

No error occurs when compile, but when run the app, the crash will happen

an...@google.com <an...@google.com> #3Dec 23, 2024 09:19PM

Project: r8
Branch: main
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101380

Revert "Optimize empty Object[] -> null in reflection APIs"

Expand for full commit details

Revert "Optimize empty Object[] -> null in reflection APIs" 
 
This reverts commit b2baa96841919a9fd14102c652f2b881fb77aa15. 
 
Reason for revert: Causes verification errors, b/395140848 
 
Bug: b/395140848 
Change-Id: I6a3311a56443f911d0179a7a40772201fb3e687a

Files:

D src/main/java/com/android/tools/r8/ir/optimize/library/ClassOptimizer.java
D src/main/java/com/android/tools/r8/ir/optimize/library/ConstructorOptimizer.java
D src/main/java/com/android/tools/r8/ir/optimize/library/EmptyVarargsUtil.java
M src/main/java/com/android/tools/r8/ir/optimize/library/LibraryMemberOptimizer.java
D src/main/java/com/android/tools/r8/ir/optimize/library/MethodOptimizer.java
M src/test/java/com/android/tools/r8/ir/optimize/library/EmptyVarargsTest.java

Hash: 29f1b9c5d00148c170a67c8b1fa566a1a701bee6
Date: Tue Feb 11 12:02:13 2025

aa...@gmail.com <aa...@gmail.com> #4Jan 5, 2025 02:19AM

Is there any specified r8 version to use for verifying this bug?

Issue 383595395