Static modifier not tracked for @JvmStatic reified inline fun in object [384052878]

In Progress

Bug

Status Update

No update yet.

Description

je...@google.com

created issue #1

Dec 13, 2024 06:48PM

Consider the following file Test.kt:

inline fun <reified T> foo() {}

object Obj {
    @JvmStatic
    inline fun <reified T> foo() {}
}

When generating current.txt, the signature of the top level function contains the static modifier, but the function in the object is missing the static modifier despite the @JvmStatic annotation:

public final class Obj {
  method public inline <reified T> void foo(); // <-- static missing
  // ..
}

public final class TestKt {
  method public static inline <reified T> void foo(); // <-- static present
}

I ran into this issue when researching if I can rename the wrapper class of top level functions in a binary compatible way, by adding a deprecated hidden object with the old wrapper class name and all the top level functions. I'd be happy to do this in a different way if the above is WAI.

Comments

au...@google.com <au...@google.com> #2Dec 13, 2024 07:18PM

Assigned to ju...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Radha Nakade <radhanakade@google.com>
Link: https://android-review.googlesource.com/3510337

Migrate traffic from pixel2 to mediumphone on FTL emulators.

Expand for full commit details

Migrate traffic from pixel2 to mediumphone on FTL emulators. 
 
Bug: 396715333 
 
Test: ./gradlew emoji2:emoji2-emojipicker:ftlmediumphoneapi33 
Change-Id: If5555443ca1a91479128e1bd6f4f909154c40ba2

Files:

M buildSrc/private/src/main/kotlin/androidx/build/FtlRunner.kt

Hash: c76f8094154101867327912e659ae47509755957
Date: Wed Feb 26 11:27:46 2025

ju...@google.com <ju...@google.com> #3Dec 20, 2024 05:13PM

In the compiled code both functions do have a static modifier, so it is a bug that metalava isn't including it for the object function.

  public static final <T extends java.lang.Object> void reifiedInlineFunTopLevel();
    descriptor: ()V
    flags: (0x1019) ACC_PUBLIC, ACC_STATIC, ACC_FINAL, ACC_SYNTHETIC
    Code:
      stack=1, locals=1, args_size=0
         0: iconst_0
         1: istore_0
         2: return
      LineNumberTable:
        line 3: 2
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            2       1     0 $i$f$reifiedInlineFunTopLevel   I
    Signature: #7                           // <T:Ljava/lang/Object;>()V

  public static final <T extends java.lang.Object> void reifiedInlineFunInObject();
    descriptor: ()V
    flags: (0x1019) ACC_PUBLIC, ACC_STATIC, ACC_FINAL, ACC_SYNTHETIC
    Code:
      stack=1, locals=1, args_size=0
         0: iconst_0
         1: istore_0
         2: return
      LineNumberTable:
        line 7: 2
      LocalVariableTable:
        Start  Length  Slot  Name   Signature
            2       1     0 $i$f$reifiedInlineFunInObject   I
    Signature: #12                          // <T:Ljava/lang/Object;>()V
    RuntimeVisibleAnnotations:
      0: #13()
        kotlin.jvm.JvmStatic

ju...@google.com <ju...@google.com> #4Jan 9, 2025 04:28PM

Looking into this more -- I think this might be an unsupported case because it isn't possible to call a reified inline function from java, so the @JvmStatic doesn't really make sense here, but I filed https://youtrack.jetbrains.com/issue/KT-74330

ju...@google.com <ju...@google.com> #5Jan 21, 2025 03:43PM

Reassigned to bu...@google.com.

Bugjuggler: https://youtrack.jetbrains.com/issue/KT-74330 -> juliamcclellan@

bu...@google.com <bu...@google.com> #6Jan 21, 2025 03:44PM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait for

https://youtrack.jetbrains.com/issue/KT-74330 to be resolved and then assign the bug to juliamcclellan.

Issue 384052878