Allow Terminal VM to change IP address [384523560]

Fixed

Bug

Platform

Needs-Triage-M110

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Dec 17, 2024 01:46AM

My wifi network is in the 192.168.0.x subnet, which is the same subnet assigned to the Android Terminal VM.

I'm not seeing a place to change that, and when I open the Terminal app with WiFi enabled I have no network connectivity.

I gain network connectivity only when I turn off WiFi.

Additionally, enabling a VPN connection through wireguard also completely breaks the terminal app, as that causes the terminal app to disconnect and one receives a notification stating that “Terminal is trying to open a new port. Port requested to be open: 8080.”

I am unable to click Accept in that notification, and I cannot access the Terminal again until I disconnect my VPN.

These may or may not be related issues.

Comments

ak...@google.com <ak...@google.com> Dec 17, 2024 02:01AM

Assigned to ak...@google.com.

ak...@google.com <ak...@google.com> #2Dec 17, 2024 05:52AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b2ae0a8c9429e6def582fda75e85f76540a31192
Author: Ralston Da Silva <ralu@google.com>
Date: Thu Jul 09 18:55:04 2020

New Focus Modifier Implementation

This is the first CL in a series of CLs which implement the new focus API. The new implementation consists of multiple modifiers each implementing a specific use case.
This CL adds FocusModifier2 and ModifiedFocusNode2 (Which will be renamed to FocusModifier and ModifiedFocusNode after the existing classes are deleted).

Bug: 160924778
Relnote: Added Modifier.focus which replaces FocusModifier.
Test: Built and launched the demo app
Change-Id: Ib852a056a0f3c76757f0fdef07e75e82bf178b8d

M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/DelegatingLayoutNodeWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/InnerPlaceable.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNodeWrapper.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusModifier2.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusNodeUtils.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/ModifiedFocusNode2.kt

https://android-review.googlesource.com/1359576

sa...@gmail.com <sa...@gmail.com> #3Dec 17, 2024 05:17PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 79b361fcb1a863005e834f70a88cae274f6ca3ce
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Jul 13 18:34:14 2020

Instantiate a ModifiedFocusNode2 corresponding to a Modifier.focus() modifier

Bug: 160924778
Test: Built and launched the demo app
Change-Id: Ib5e045621e36a72327acf148bb1698632ffe182f

M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt

https://android-review.googlesource.com/1362065

ak...@google.com <ak...@google.com> #4Dec 19, 2024 12:38PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a52a858283c3ee5af05036e1e3665784a3051f4f
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Jul 13 18:19:31 2020

Add a modifier to request focus changes

Bug: 161182057, 160924778
Relnote: Added a modifier to request focus changes
Test: Built and launched the demo App.
Change-Id: I8dd73cf3ce77e112a9f97f203b8ec7a0f07bc706

M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusRequester.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusRequesterModifier.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/ModifiedFocusRequesterNode.kt

https://android-review.googlesource.com/1362064

sa...@gmail.com <sa...@gmail.com> #5Dec 19, 2024 08:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c8c1ab4e79928727f722e5c946c7342dd9fa30f8
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Jul 15 01:20:27 2020

Instantiate a ModifiedFocusNode2 corresponding to a Modifier.focus() modifier

Bug: 160924778
Test: Built and launched the demo app
Change-Id: Ide2b07ec55b65627d1a8cfedef55848807537bac

M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt

https://android-review.googlesource.com/1363337

r0...@gmail.com <r0...@gmail.com> #6Dec 25, 2024 01:37PM

I think the "not able to tap port forwarding accept/deny" part is it's own bug: my device exhibits the same behaviour however the wifi network is on a different subnet (.2.0/24) entirely.

I agree that giving us the option to define the network subnet would be a major win for the app and users; the ideal implementation could probably inspect the currently used network subnets and pick one that doesn't overlap?

Device: Pixel 6a
Version: BP11.241121.010

ak...@google.com <ak...@google.com> #7Jan 8, 2025 07:44AM

Marked as fixed.

The issue has been fixed and watch out for future releases.