Handle invalid JVM names in JavaPoet side of XPoet [384600605]

Fixed

Bug

Status Update

No update yet.

Description

da...@google.com

created issue #1

Dec 17, 2024 03:52AM

With the changes for XPoet to build both JavaPoet and KotlinPoet specs it means that when Room is processing function that lead to invalid JVM method names, it will cause the JavaPoet side to throw an exception even if the XProcessingConfig.excludeMethodsWithInvalidJvmSourceNames is turned ON for Kotlin code generation.

An example case where Room will encounter these is with internal functions that it needs to override.

Caused by: java.lang.IllegalArgumentException: not a valid name: deleteAllBooksSuspend$room-testapp-kotlin_withKspGenKotlinDebugAndroidTest
	at com.squareup.javapoet.Util.checkArgument(Util.java:53)
	at com.squareup.javapoet.MethodSpec$Builder.setName(MethodSpec.java:315)
	at com.squareup.javapoet.MethodSpec$Builder.<init>(MethodSpec.java:310)
	at com.squareup.javapoet.MethodSpec$Builder.<init>(MethodSpec.java:294)
	at com.squareup.javapoet.MethodSpec.methodBuilder(MethodSpec.java:188)
	at androidx.room.compiler.processing.MethodSpecHelper.overriding(JavaPoetExt.kt:175)
	at androidx.room.compiler.processing.MethodSpecHelper.overridingWithFinalParams(JavaPoetExt.kt:148)
	at androidx.room.compiler.codegen.XFunSpec$Companion.overridingBuilder(XFunSpec.kt:166)
	at androidx.room.compiler.codegen.XFunSpec$Companion.overridingBuilder$default(XFunSpec.kt:158)
	at androidx.room.writer.DaoWriter.overrideWithoutAnnotations(DaoWriter.kt:676)
	at androidx.room.writer.DaoWriter.createPreparedQueryMethod(DaoWriter.kt:435)
	at androidx.room.writer.DaoWriter.createTypeSpecBuilder(DaoWriter.kt:154)
	at androidx.room.writer.TypeWriter.write(TypeWriter.kt:70)
	at androidx.room.DatabaseProcessingStep.process(DatabaseProcessingStep.kt:103)

Comments

ap...@google.com <ap...@google.com> #2Jan 2, 2025 11:52PM

Same bug here.
I have a LazyVerticalGrid composable with around 100 elements (2 columns) and the scroll is already very laggy. With a SmallAppBar and a scrollbehavior, it is now very very laggy.

el...@google.com <el...@google.com> Jan 23, 2025 06:17PM

Marked as fixed.

na...@google.com <na...@google.com> #3Jan 29, 2025 06:11PM

Is this a LazyColumn/LazyVerticalGrid performance issue?

We've ported the behavior to material (not material3) and whenever LazyColumn's size and position were being adjusted during a scroll, the scrolling was laggy.

We've also tried to make LazyColumn fill the whole screen and adjust its contentPadding instead, but we got the same result. The scrolling was laggy while contentPadding was being adjusted.

Once the bar is collapsed, the performance seems okay again.

We use ExitUntilCollapsedScrollBehavior.

sp...@gmail.com <sp...@gmail.com> #4Jan 29, 2025 07:45PM

Are you testing on a debug or a release version of your APK?

ap...@google.com <ap...@google.com> #5Jan 29, 2025 11:39PM

We tried both. It's a bit better in release version but not good enough for production use.

We tested on physical Pixel 3a with API 32.

pr...@google.com <pr...@google.com> #6Feb 12, 2025 06:40PM

Could you provide us with a minimal code that showcase this issue. It can be very helpful!

Issue 384600605