Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Make androidx.room and androidx.sqlite target Kotlin 2.0
Expand for full commit details
Make androidx.room and androidx.sqlite target Kotlin 2.0
This required the following changes:
* Suppress 'ACTUAL_ANNOTATIONS_NOT_MATCH_EXPECT' in SQLiteException.android.kt and ThreadLocal.jvmAndroid.kt due to being impossible to match annotations in expect when actual is a typealias to a platform type. Meanwhile in room-common repeatable annotations in JVM use @JvmRepeatable while expect uses Kotlin's @Repeatable and while trying to match actual with expect, an error is produced due to @JvmRepeatable and @Repeatable being used together.
* Fix various annotations mismatch between actual / expect.
* Removing @JvmField from common code as expect properties have no backing field and @JvmField targets FIELD.
* Smart-cast is not possible for expect properties, therefore first store in local variable before smart-case usage. Observed in TableInfo, FtsTableInfo, ViewInfo and MigrationUtil.
* Adding load() and getRefreshKey() to expect LimitOffsetPagingSource to conform to modality of actual overriding those functions.
* Make a XProcessingEnvConfig a normal class (instead of a data class) since it has a private constructor with a public copy() usage which is now invalid.
* Set useKsp2=true on projects with KSP and Kotlin language 2.0 (Room KMP test apps).
* Workaround KSP2 issue with default value of annotations not appearing in value list. Added a get() that returns nullable XAnnotationValue.
* Workaround KSP2 issue of projecting value class constructor as member of (to support generics).
* Workaround XPoet creating JavaPoet types of invalid methods (internal) when XProcessingEnvConfig.excludeMethodsWithInvalidJvmSourceNames is set to true due to Kotlin codegen.
Bug: 315461431
Bug: 384600605
Test: Existing
Relnote: "Native APIs updated due to Kotlin 2.0"
Change-Id: I8efb015c88682921780370c8bed5931d9933a319
Files:
- M
development/build_log_simplifier/messages.ignore - M
room/integration-tests/kotlintestapp/build.gradle - M
room/integration-tests/multiplatformtestapp/build.gradle - M
room/room-common/bcv/native/current.txt - M
room/room-common/build.gradle - M
room/room-common/src/jvmMain/kotlin/androidx/room/DeleteColumn.jvm.kt - M
room/room-common/src/jvmMain/kotlin/androidx/room/DeleteTable.jvm.kt - M
room/room-common/src/jvmMain/kotlin/androidx/room/RenameColumn.jvm.kt - M
room/room-common/src/jvmMain/kotlin/androidx/room/RenameTable.jvm.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/InternalXAnnotation.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/JavaPoetExt.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/XAnnotation.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/XProcessingEnvConfig.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/util/NamingUtils.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationTest.kt - M
room/room-compiler/build.gradle - M
room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt - M
room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/MultimapQueryResultAdapter.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/BaseDaoKotlinCodeGenTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/DaoKotlinCodeGenTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/DaoRelationshipKotlinCodeGenTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseKotlinCodeGenTest.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_daoProperty.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_internalVisibility.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_javaSource.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_simple.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_withFtsAndView.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/guavaCallable_java.kt - M
room/room-ktx/build.gradle - M
room/room-migration/build.gradle - M
room/room-paging-guava/build.gradle - M
room/room-paging-rxjava2/build.gradle - M
room/room-paging-rxjava3/build.gradle - M
room/room-paging/build.gradle - M
room/room-paging/src/androidMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.android.kt - M
room/room-paging/src/commonMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt - M
room/room-paging/src/jvmNativeMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.jvmNative.kt - M
room/room-runtime/bcv/native/current.txt - M
room/room-runtime/build.gradle - M
room/room-runtime/src/commonMain/kotlin/androidx/room/RoomConnectionManager.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/FtsTableInfo.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/MigrationUtil.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/TableInfo.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/ViewInfo.kt - M
room/room-runtime/src/jvmAndroidMain/kotlin/androidx/room/concurrent/ThreadLocal.jvmAndroid.kt - M
room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/InvalidationTracker.jvmNative.kt - M
room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/util/TableInfo.jvmNative.kt - M
room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/util/ViewInfo.jvmNative.kt - M
room/room-runtime/src/nativeMain/kotlin/androidx/room/concurrent/ThreadLocal.native.kt - M
room/room-rxjava2/build.gradle - M
room/room-rxjava3/build.gradle - M
room/room-testing/build.gradle - M
sqlite/sqlite-bundled/build.gradle - M
sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteConnection.kt - M
sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteDriver.kt - M
sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteStatement.kt - M
sqlite/sqlite-bundled/src/jvmAndroidMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLite.jvmAndroid.kt - M
sqlite/sqlite-framework/build.gradle - M
sqlite/sqlite-ktx/build.gradle - M
sqlite/sqlite/build.gradle - M
sqlite/sqlite/src/androidMain/kotlin/androidx/sqlite/SQLiteException.android.kt - M
sqlite/sqlite/src/androidUnitTest/kotlin/androidx/sqlite/db/SimpleSQLiteQueryTest.kt
Hash: 6e1e6e154483b9346ffc27a0e57d14bd20f4359f
Date: Mon Dec 16 22:13:20 2024
el...@google.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-common:2.7.0-alpha13androidx.room:room-common-iosarm64:2.7.0-alpha13androidx.room:room-common-iossimulatorarm64:2.7.0-alpha13androidx.room:room-common-iosx64:2.7.0-alpha13androidx.room:room-common-jvm:2.7.0-alpha13androidx.room:room-common-linuxarm64:2.7.0-alpha13androidx.room:room-common-linuxx64:2.7.0-alpha13androidx.room:room-common-macosarm64:2.7.0-alpha13androidx.room:room-common-macosx64:2.7.0-alpha13androidx.room:room-compiler:2.7.0-alpha13androidx.room:room-compiler-processing:2.7.0-alpha13androidx.room:room-ktx:2.7.0-alpha13androidx.room:room-migration:2.7.0-alpha13androidx.room:room-migration-iosarm64:2.7.0-alpha13androidx.room:room-migration-iossimulatorarm64:2.7.0-alpha13androidx.room:room-migration-iosx64:2.7.0-alpha13androidx.room:room-migration-jvm:2.7.0-alpha13androidx.room:room-migration-linuxarm64:2.7.0-alpha13androidx.room:room-migration-linuxx64:2.7.0-alpha13androidx.room:room-migration-macosarm64:2.7.0-alpha13androidx.room:room-migration-macosx64:2.7.0-alpha13androidx.room:room-paging:2.7.0-alpha13androidx.room:room-paging-android:2.7.0-alpha13androidx.room:room-paging-guava:2.7.0-alpha13androidx.room:room-paging-iosarm64:2.7.0-alpha13androidx.room:room-paging-iossimulatorarm64:2.7.0-alpha13androidx.room:room-paging-iosx64:2.7.0-alpha13androidx.room:room-paging-jvm:2.7.0-alpha13androidx.room:room-paging-linuxarm64:2.7.0-alpha13androidx.room:room-paging-linuxx64:2.7.0-alpha13androidx.room:room-paging-macosarm64:2.7.0-alpha13androidx.room:room-paging-macosx64:2.7.0-alpha13androidx.room:room-paging-rxjava2:2.7.0-alpha13androidx.room:room-paging-rxjava3:2.7.0-alpha13androidx.room:room-runtime:2.7.0-alpha13androidx.room:room-runtime-android:2.7.0-alpha13androidx.room:room-runtime-iosarm64:2.7.0-alpha13androidx.room:room-runtime-iossimulatorarm64:2.7.0-alpha13androidx.room:room-runtime-iosx64:2.7.0-alpha13androidx.room:room-runtime-jvm:2.7.0-alpha13androidx.room:room-runtime-linuxarm64:2.7.0-alpha13androidx.room:room-runtime-linuxx64:2.7.0-alpha13androidx.room:room-runtime-macosarm64:2.7.0-alpha13androidx.room:room-runtime-macosx64:2.7.0-alpha13androidx.room:room-rxjava2:2.7.0-alpha13androidx.room:room-rxjava3:2.7.0-alpha13androidx.room:room-testing:2.7.0-alpha13androidx.room:room-testing-android:2.7.0-alpha13androidx.room:room-testing-iosarm64:2.7.0-alpha13androidx.room:room-testing-iossimulatorarm64:2.7.0-alpha13androidx.room:room-testing-iosx64:2.7.0-alpha13androidx.room:room-testing-jvm:2.7.0-alpha13androidx.room:room-testing-linuxarm64:2.7.0-alpha13androidx.room:room-testing-linuxx64:2.7.0-alpha13androidx.room:room-testing-macosarm64:2.7.0-alpha13androidx.room:room-testing-macosx64:2.7.0-alpha13androidx.sqlite:sqlite:2.5.0-alpha13androidx.sqlite:sqlite-android:2.5.0-alpha13androidx.sqlite:sqlite-bundled:2.5.0-alpha13androidx.sqlite:sqlite-bundled-android:2.5.0-alpha13androidx.sqlite:sqlite-bundled-iosarm64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-iossimulatorarm64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-iosx64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-jvm:2.5.0-alpha13androidx.sqlite:sqlite-bundled-linuxarm64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-linuxx64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-macosarm64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-macosx64:2.5.0-alpha13androidx.sqlite:sqlite-framework:2.5.0-alpha13androidx.sqlite:sqlite-framework-android:2.5.0-alpha13androidx.sqlite:sqlite-framework-iosarm64:2.5.0-alpha13androidx.sqlite:sqlite-framework-iossimulatorarm64:2.5.0-alpha13androidx.sqlite:sqlite-framework-iosx64:2.5.0-alpha13androidx.sqlite:sqlite-framework-linuxarm64:2.5.0-alpha13androidx.sqlite:sqlite-framework-linuxx64:2.5.0-alpha13androidx.sqlite:sqlite-framework-macosarm64:2.5.0-alpha13androidx.sqlite:sqlite-framework-macosx64:2.5.0-alpha13androidx.sqlite:sqlite-iosarm64:2.5.0-alpha13androidx.sqlite:sqlite-iossimulatorarm64:2.5.0-alpha13androidx.sqlite:sqlite-iosx64:2.5.0-alpha13androidx.sqlite:sqlite-jvm:2.5.0-alpha13androidx.sqlite:sqlite-ktx:2.5.0-alpha13androidx.sqlite:sqlite-linuxarm64:2.5.0-alpha13androidx.sqlite:sqlite-linuxx64:2.5.0-alpha13androidx.sqlite:sqlite-macosarm64:2.5.0-alpha13androidx.sqlite:sqlite-macosx64:2.5.0-alpha13
sp...@gmail.com
I'm seeing this with Room 2.7.0-alpha13.
e: [ksp] java.lang.IllegalArgumentException: not a valid name: update--rkJvpU
at com.squareup.javapoet.Util.checkArgument(Util.java:53)
at com.squareup.javapoet.MethodSpec$Builder.setName(MethodSpec.java:315)
at com.squareup.javapoet.MethodSpec$Builder.<init>(MethodSpec.java:310)
at com.squareup.javapoet.MethodSpec$Builder.<init>(MethodSpec.java:294)
at com.squareup.javapoet.MethodSpec.methodBuilder(MethodSpec.java:188)
at androidx.room.compiler.processing.MethodSpecHelper.overriding(JavaPoetExt.kt:183)
at androidx.room.compiler.processing.MethodSpecHelper.overridingWithFinalParams(JavaPoetExt.kt:149)
at androidx.room.compiler.codegen.XFunSpec$Companion.overridingBuilder(XFunSpec.kt:166)
at androidx.room.compiler.codegen.XFunSpec$Companion.overridingBuilder$default(XFunSpec.kt:158)
at androidx.room.writer.DaoWriter.overrideWithoutAnnotations(DaoWriter.kt:680)
at androidx.room.writer.DaoWriter.createPreparedQueryFunction(DaoWriter.kt:435)
at androidx.room.writer.DaoWriter.createTypeSpecBuilder(DaoWriter.kt:154)
at androidx.room.writer.TypeWriter.write(TypeWriter.kt:70)
at androidx.room.DatabaseProcessingStep.process(DatabaseProcessingStep.kt:103)
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Sanitize DAO Java method names mangled by value classes.
Expand for full commit details
Sanitize DAO Java method names mangled by value classes.
Bug: 384600605
Bug: 388299754
Test: DaoKotlinCodeGenTest.kt
Change-Id: I805ae6828bf45de82f4bcec55af4528ccd16d00a
Files:
- M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/util/NamingUtils.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/DaoKotlinCodeGenTest.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_valueClassConverter.kt
Hash: 93666e398595454b46279c8ea2b8e746363971eb
Date: Wed Jan 29 15:54:02 2025
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.core:core-viewtree:1.0.0-rc01androidx.room:room-compiler:2.7.0-beta01androidx.room:room-compiler-processing:2.7.0-beta01
Description
With the changes for XPoet to build both JavaPoet and KotlinPoet specs it means that when Room is processing function that lead to invalid JVM method names, it will cause the JavaPoet side to throw an exception even if the
XProcessingConfig.excludeMethodsWithInvalidJvmSourceNamesis turned ON for Kotlin code generation.An example case where Room will encounter these is with
internalfunctions that it needs to override.