Fixed
Status Update
Comments
dy...@gmail.com <dy...@gmail.com>
dy...@gmail.com <dy...@gmail.com> #2
The issue turns out to be a problem with how the requestFocus()
was being called. in updateFocusRectInWindowSnapshot
, there is a check for isFocused
that should also consider hasFocus()
. The line should be changed from:
if (!view.isFocused) {
to
if (!view.isFocused && !view.hasFocus()) {
st...@google.com <st...@google.com>
vv...@google.com <vv...@google.com> #3
Resolved the original issues by using the correct rect value. However the focus shouldn't skip focus even with incorrect value. re-open the issue for investigation purpose. Thank you!
ja...@gmail.com <ja...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-main
Author: George Mount <
Link:
Fix requestFocus with bad previous rectangle
Expand for full commit details
Fix requestFocus with bad previous rectangle
Fixes: 388590015
When requestFocus() is called on a ComposeView with a previousRect
set to something that doesn't make sense (empty rectangle from the
wrong direction, for example), the previous behavior would not
find a matching component in that direction. Instead, it would
find the next View to focus on and pass the focus on.
With this CL, if the ComposeView isn't currently focused and a
focusSearch fails to find something focusable in relation to the
previous rectangle, an attempt is made irrespective of the
previous rectangle.
Relnote: "Fixed focus issue where requestFocus() with a
nonsensical previouslyFocusedRect parameter (related to
the focus direction) would skip past a ComposeView."
Test: new test, manual testing
Change-Id: Ifdc2f17b23620d1ae14848624f447f84cc1b0b5d
Files:
- M
compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt
- M
compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
Hash: 8501eec732d61bd71c385a90f58a194191816d57
Date: Fri Jan 10 11:04:59 2025
Description
What
User experience
What type of Android issue is this?
User Interface
What steps would let us observe this issue?
What did you expect to happen?
The wallpaper selected could be previewed before setting wallpaper for either home or lock screen.
What actually happened?
When wallpaper was selected the emoji workshop opened.
What was the effect of this issue on your device usage, such as lost time or work?
None - device worked normally
When
Time and frequency
Time when bug report was triggered: Dec 17, 2024 12:51 AM GMT-06:00
How often has this happened?
Every time
Where
Component
Suggested component: <not visible> (1630575)
Build and device data
- Build Number: google/oriole_beta/oriole:15/BP11.241121.010/12780007:user/release-keys
(Note: It is the build when sending this report. For exact build reference, please see the attached bugreport.)
Debugging information
Google Play services
com.google.android.gms
Version 244532035 (24.45.32 (260400-693815026))
System App (Bundled)
Android System WebView
com.google.android.webview
Version 661308831 (128.0.6613.88)
System App (Updated)
Network operator: Verizon
SIM operator: Verizon
Filed by Android Beta Feedback. Version (Updated): 2.46-betterbug.external_20241023_RC01 (DOGFOOD)https://developer.android.com/preview/feedback#feedback-app .
To learn more about our feedback process, please visit