Assigned
Status Update
Comments
ja...@gmail.com <ja...@gmail.com> #2
This bug been identified as part of Chrome's flake reduction initiative. Resolution of this issue is critical because it has a large impact on the stability of Chrome CI/CQ. Resolving these issues will be essential to meet Chrome’s flake reduction goals.
This bug has led to a large number of gardened builds failing in the last 7 days. List of gardened build failures caused by this cluster can be viewed at:
https://data.corp.google.com/sites/chrome_generic_flakiness_dashboard_datasite/build_failures/?av=rpqxzw:ktu56&fb=is_sheriff_or_cq_builder:eq:true&f=cluster_name:in:b%2F400617105
or in LUCI Analysis and grouped by builders:
https://luci-milo.appspot.com/ui/tests/p/chromium/rules/3519deb73451d0c9b91241ccea2406fa?tab=recent-failures&filterToMetric=builds-failed-due-to-flaky-tests&groupBy=builder&orderBy=invocationFailures
Please consider the following strategies to mitigate the impact from this issue which are rated in order of resolution preference:
1. Resolve the underlying test issue.
2. Move the flaky test from Critical Builders to FYI Builder
3. Disable test (least desirable as it reduces test coverage) and add a Test-Disabled label to this issue. The disabled tests might continue running in reviver builders (go/test-reviver), see config [1] for a list of supported builders.
http://go/resolve-chrome-top-flakes provides more information on the tools available for resolving flaky tests.
When investigating this failure, you may identify this bug is too broad (encompasses multiple different issues) or too narrow (only captures one part of a larger issue). If this applies, you can combine issues[2] or split issues[3].
Links:
[1]https://source.chromium.org/chromium/chromium/src/+/main:infra/config/subprojects/reviver/reviver.star
[2]https://luci-analysis.appspot.com/help#combining-issues
[3]https://luci-analysis.appspot.com/help#splitting-issues
Why LUCI Analysis posted this comment:https://luci-milo.appspot.com/ui/tests/help#policy-activated (Policy ID: builds-failed-due-to-flaky-tests)
This bug has led to a large number of gardened builds failing in the last 7 days. List of gardened build failures caused by this cluster can be viewed at:
or in LUCI Analysis and grouped by builders:
Please consider the following strategies to mitigate the impact from this issue which are rated in order of resolution preference:
1. Resolve the underlying test issue.
2. Move the flaky test from Critical Builders to FYI Builder
3. Disable test (least desirable as it reduces test coverage) and add a Test-Disabled label to this issue. The disabled tests might continue running in reviver builders (go/test-reviver), see config [1] for a list of supported builders.
When investigating this failure, you may identify this bug is too broad (encompasses multiple different issues) or too narrow (only captures one part of a larger issue). If this applies, you can combine issues[2] or split issues[3].
Links:
[1]
[2]
[3]
Why LUCI Analysis posted this comment:
bu...@chromium.org <bu...@chromium.org> #3
Tried testing the issue on latest stable version #131.0.6778.142 using macOS 14.6.3 by following steps from comment #1
Observed that, for 'allow this time' option after exit from full screen again permission pop up appear
Please find screencast attached below
Reporter@: Could you please review the screencast and let us know if anything is missed from our end.
Thanks..!!
Observed that, for 'allow this time' option after exit from full screen again permission pop up appear
Please find screencast attached below
Reporter@: Could you please review the screencast and let us know if anything is missed from our end.
Thanks..!!
ja...@gmail.com <ja...@gmail.com> #4
The screecast showcases the issue, but it is not just from entering and exiting fullscreen, its anytime you call unlock and then lock again. If you play more of the web game, (try walking up to the notebook on the desk right of the computer.) and then when the UI opens it calls unlock and then when you click the exit button it will incorrectly make the permission pop up appear.
Thanks for looking into this!
Thanks for looking into this!
pe...@google.com <pe...@google.com> #5
Thank you for providing more feedback. Adding the requester to the CC list.
Description
Steps to reproduce the problem
Problem Description
This is unexpected behavior because "this time" button option for permission dialog is ambigious. Especially next to "Allow on every visit." Currently, the "this time" breaks experiences that lock() and unlock() multiple times. So... I think "this time" should be for the duration of this session. Also, before this worked because there was no pop up permission dialog.
Summary
Pointer lock api permission dialog option for [Allow this time] is not session based.
Additional Data
Category: UI
Chrome Channel: Not sure
Regression: Yes