Meerkat canary06 breaks gradle-profiler [385264250]

Fixed

Bug

Status Update

No update yet.

Description

jf...@block.xyz

created issue #1

Dec 20, 2024 03:10PM

This recent change renamed ProjectSystemSyncManager#syncProject to requestSyncProject, so gradle-profiler is unable to trigger a sync:

2024-12-20 10:12:03,736 [   1863] SEVERE - #c.i.o.a.i.AnyThreadWriteThreadingSupport - 'com.google.common.util.concurrent.ListenableFuture com.android.tools.idea.projectsystem.ProjectSystemSyncManager.syncProject(com.android.tools.idea.projectsystem.ProjectSystemSyncManager$SyncReason)'
java.lang.NoSuchMethodError: 'com.google.common.util.concurrent.ListenableFuture com.android.tools.idea.projectsystem.ProjectSystemSyncManager.syncProject(com.android.tools.idea.projectsystem.ProjectSystemSyncManager$SyncReason)'
	at org.gradle.profiler.studio.plugin.system.AndroidStudioSystemHelper.doGradleSync(AndroidStudioSystemHelper.java:53)
	at org.gradle.profiler.studio.plugin.system.AndroidStudioSystemHelper.startManualSync(AndroidStudioSystemHelper.java:48)
	at org.gradle.profiler.studio.plugin.system.AndroidStudioSystemHelper.getStartupSyncResult(AndroidStudioSystemHelper.java:39)
	at org.gradle.profiler.studio.plugin.client.GradleProfilerClient.handleSyncRequest(GradleProfilerClient.java:96)
	at org.gradle.profiler.studio.plugin.client.GradleProfilerClient.handleGradleProfilerRequest(GradleProfilerClient.java:72)
	at org.gradle.profiler.studio.plugin.client.GradleProfilerClient.listenForSyncRequests(GradleProfilerClient.java:46)
	at org.gradle.profiler.studio.plugin.GradleProfilerStartupActivity.listenForSyncRequests(GradleProfilerStartupActivity.java:103)
	at org.gradle.profiler.studio.plugin.GradleProfilerStartupActivity.lambda$runActivity$0(GradleProfilerStartupActivity.java:55)
	at com.intellij.openapi.application.impl.AnyThreadWriteThreadingSupport$executeOnPooledThread$1.run(AnyThreadWriteThreadingSupport.kt:167)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)

Comments

cm...@google.com <cm...@google.com> Dec 20, 2024 04:20PM

Assigned to wf...@google.com.

cm...@google.com <cm...@google.com> #2Jan 17, 2025 03:03PM

Assigned to wf...@google.com.

I have a pending change to just add the method back (with DeprecationLevel.HIDDEN) to avoid breaking the profiler code.

(Will appear once submitted: Ia71305e675d2ba022b399ce6531c6cb6c679cdac)

cm...@google.com <cm...@google.com> #3Jan 20, 2025 04:18PM

Fixed in https://cs.android.com/android-studio/platform/tools/adt/idea/+/cbf9fde51684986e0995b0a20ce5d1ddad31ec73

Will leave this open until it's landed in the release branch also

cm...@google.com <cm...@google.com> #4Jan 21, 2025 03:57PM

Marked as fixed.

This will be in the releases after next of Meerkat and Meerkat feature drop

an...@google.com <an...@google.com> #5Jan 23, 2025 08:52PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat Feature Drop | 2024.3.2 Canary 2
Android Gradle Plugin 8.10.0-alpha02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

jf...@block.xyz <jf...@block.xyz> #6Jan 23, 2025 09:20PM

Can you also merge this to Meerkat 2024.3.1? It would be unfortunate to let that go all the way to a final release

an...@google.com <an...@google.com> #7Feb 5, 2025 07:50PM

The fixes for this issue are now also available in:

Android Studio Meerkat | 2024.3.1 RC 1
Android Gradle Plugin 8.9.0-rc01