AppLinkSplitToWebAndCustom is UnknownIssue in lint 8.7.3 [385875832]

Fixed

Bug

Status Update

No update yet.

Description

ic...@gmail.com

created issue #1

Dec 25, 2024 09:25AM

Description has been deleted.

lint-results-debug-report.xml

685 B

Download

Comments

ic...@gmail.com <ic...@gmail.com> #2Dec 25, 2024 09:30AM

Realized this also affects effectively-sealed classes (no public or protected constructors). We should consider adding ClassItem.isEffectivelySealed() to match.

We have three options for the logic:

Search Codebase for all descendent classes of each effectively sealed class and only consider the ancestor class effectively final if all its descendents are concrete or effectively sealed. This matches the behavior inherent to the language.
Disallow sealed (possibly also effectively sealed) classes from having abstract descendents altogether. This limits some potentially valid APIs (E.g.: ADT that the client extends) but might be worth doing if we think this is a bad API pattern.
Disallow adding abstract methods to any abstract class or interface altogether. This checks is the only exception to rule against adding abstract methods, and maybe it's better to never add abstract methods to existing public classes.

ic...@gmail.com <ic...@gmail.com> #3Dec 25, 2024 10:15AM

Project: platform/frameworks/support
Branch: androidx-main
Author: George Mount <mount@google.com>
Link: https://android-review.googlesource.com/3338887

Revert^2 "Add requestFocus(FocusDirection) to focusRequester"

Expand for full commit details

Revert^2 "Add requestFocus(FocusDirection) to focusRequester" 
 
This reverts commit 274c9242bfe89dad5aeb7179750d45fa64c6ab80. 
 
Reason for revert: The original CL was correct. The revert was incorrect. 
 
Relnote: "Adds requestFocus(FocusDirection) to both focusRequester and 
FocusTargetModifierNode to allow focusing with a specific 
direction." 
 
Bug: 220960090 
Test: new test 
 
Change-Id: I96b97720a65d2e1bf8d7f845dc05844f7e7f565c

Files:

M compose/ui/ui/api/1.8.0-beta01.txt
M compose/ui/ui/api/current.ignore
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/restricted_1.8.0-beta01.txt
M compose/ui/ui/api/restricted_current.ignore
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/ExplicitEnterExitWithCustomFocusEnterExitDemo.kt
M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/focus/RequestFocusTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOwnerImpl.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequester.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTargetModifierNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTargetNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTransactions.kt

Hash: fb5d4a3eebdbc0cd3034d11eae8e00f507ec1a68
Date: Wed Nov 06 19:23:12 2024

Message last modified on Dec 26, 2024 02:36AM

ya...@google.com <ya...@google.com> Dec 26, 2024 04:52PM

Assigned to an...@google.com.

tn...@google.com <tn...@google.com> #4Dec 26, 2024 05:55PM

Reassigned to tn...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: drchen <conradchen@google.com>
Link: https://android-review.googlesource.com/3510176

Introduce APIs to support pane preferred heights

Expand for full commit details

Introduce APIs to support pane preferred heights 
 
Note that we need to ignore API checking of adding the modifier 
to PaneScaffoldScope, as b/220960090 indicates, the current Metalava 
is not able to tell if a sealed interface has been implemented by 
an open abstract class. (In our case, all inheritances are sealed or 
internal so we are good to ignore the API warning.) 
 
Relnote: "Introduce PaneScaffoldScope.preferredHeight modifier for 
   devs to provide pane preferred heights that will be applied with 
   new adapt strategies we are going to introduce." 
 
Test: n/a 
Bug: 373490181 
Bug: 373489847 
Change-Id: I957dd252b2bd154e3b0be048c092147fb6d1b2b8

Files:

M compose/material3/adaptive/adaptive-layout/api/current.ignore
M compose/material3/adaptive/adaptive-layout/api/current.txt
M compose/material3/adaptive/adaptive-layout/api/restricted_current.ignore
M compose/material3/adaptive/adaptive-layout/api/restricted_current.txt
M compose/material3/adaptive/adaptive-layout/src/commonMain/kotlin/androidx/compose/material3/adaptive/layout/PaneScaffold.kt
M compose/material3/adaptive/adaptive-layout/src/commonMain/kotlin/androidx/compose/material3/adaptive/layout/PaneScaffoldDirective.kt

Hash: 0d7a940f0ce81b2a9a699146f48de72a177357b7
Date: Wed Feb 26 11:34:20 2025

tn...@google.com <tn...@google.com> #5Dec 27, 2024 07:12PM

Marked as fixed.

The docs now contain exact release information for issues as well, e.g. on https://googlesamples.github.io/android-custom-lint-rules/checks/AppLinkSplitToWebAndCustom.md.html it says "Since: 8.8.0-alpha08 (October 2024)".

ic...@gmail.com <ic...@gmail.com> #6Dec 30, 2024 07:20AM

Thanks a lot for the quick support.
It do helps and the "Since" field is exactly what we're looking for.

deleted

0 B

an...@google.com <an...@google.com> #7Jan 6, 2025 05:15PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat | 2024.3.1 Canary 8
Android Gradle Plugin 8.9.0-alpha08

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!