IssueTracker

Problem you have encountered:

GetDatabaseDdl returns `<schema>.<table>` when the <schema> or <table> is reserved keywords. Quoted identifiers with dot is not valid DDL identifier.

What you expected to happen:

GetDatabaseDdl must return only valid DDLs.

Quote only a path element as like one of:

• schema.table
• schema.`table`
• `schema`.table
• `schema`.`table`

Steps to reproduce:

Reproduce using gcloud spanner databases ddl command group.

$ gcloud spanner databases ddl update --project ${SPANNER_PROJECT_ID} --instance ${SPANNER_INSTANCE_ID} ${SPANNER_DATABASE_ID} --ddl='CREATE SCHEMA `group`; CREATE TABLE `group`.`order` (PK INT64 PRIMARY KEY)'
Schema updating...done.                                                                                                                
$ gcloud spanner databases ddl describe --project ${SPANNER_PROJECT_ID} --instance ${SPANNER_INSTANCE_ID} ${SPANNER_DATABASE_ID}
CREATE SCHEMA `group`;

CREATE TABLE `group.order` (
  PK INT64,
) PRIMARY KEY(PK);

It is not a valid DDL statement.

$ gcloud spanner databases ddl update --project ${SPANNER_PROJECT_ID} --instance ${SPANNER_INSTANCE_ID} ${SPANNER_DATABASE_ID} --ddl='CREATE TABLE `group.order` (                                               
  PK INT64,
) PRIMARY KEY(PK);'
ERROR: (gcloud.spanner.databases.ddl.update) INVALID_ARGUMENT: Error parsing Spanner DDL statement: CREATE TABLE `group.order` (\n  PK INT64,\n) PRIMARY KEY(PK) : Error on line 1, column 14: Can not contain dot(.) in identifier: group.order
Error parsing Spanner DDL statement: CREATE TABLE `group.order` (
  PK INT64,
) PRIMARY KEY(PK) : Error on line 1, column 14: Can not contain dot(.) in identifier: group.order

Other information (workarounds you have tried, documentation consulted, etc):

N/A