Status Update
No update yet.
Comments
cl...@google.com
ap...@google.com
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
cl...@google.com
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
na...@google.com
-
Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
-
Dynamic features are not used in the application.
As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.
zy...@gmail.com
Hmm, I feel the crash might be something related to separate/secondary process.
I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.
Description
Component used: Navigation
Version used: 2.8.5
The
NavDestination.fillInLabelmethodlabelof theNavDestinationwith arguments. However, it does this by (in every case butNavType.ReferenceType) by just callingargs[argName].toString()- e.g., just directly callingtoString()on the object in theSavedStatebundle.While this approach works for simple types, a custom
NavTypemight not store their class directly in the Bundle - for example, if using the@Serializablesupport, it would be stored as aBundle, which means thetoString()is unlikely to actually be what is needed.Instead,
fillInLabelshould take into account theNavTypeand use itsgetmethod to give theNavTypecontrol over exactly the object that is synthesized from the arguments. That way, developers could implement a customtoString()implementation on their object to control how it is displayed in the label.