Generated Kotlin code has sytax error when using long entity and POJO names [388193960]

Fixed

Bug

Status Update

No update yet.

Description

mo...@gmail.com

created issue #1

Jan 7, 2025 04:04PM

Component used: Room compiler, @Dao, @Delete

Version used: 2.7.0-alpha11

Devices/Android versions reproduced on: -

Code generation: KSP with Kotlin option enabled

Invalid code generated when using too long names for an entity and a POJO and using the @Delete annotation.

Sample:

class ThisEntityPrimaryKeyClassHasAVeryVeryLongName(...)

@Entity
class ThisEntityClassHasAVeryVeryLongName(
    @PrimaryKey @Embedded val key: ThisEntityPrimaryKeyClassHasAVeryVeryLongName,
    ...
)

@Dao
interface MyDao {
    @Delete(entity = ThisEntityClassHasAVeryVeryLongName::class)
    suspend fun deleteItem(key: ThisEntityPrimaryKeyClassHasAVeryVeryLongName)
}

Generated code:

public class MyDao_Impl(
  __db: RoomDatabase,
) : MyDao {
  private val __db: RoomDatabase

  private
      val __deleteAdapterOfThisEntityPrimaryKeyClassHasAVeryVeryLongNameAsThisEntityClassHasAVeryVeryLongName:
      EntityDeleteOrUpdateAdapter<ThisEntityPrimaryKeyClassHasAVeryVeryLongName>

  init {
    this.__db = __db
    this.__deleteAdapterOfThisEntityPrimaryKeyClassHasAVeryVeryLongNameAsThisEntityClassHasAVeryVeryLongName // <-- The `=` should be placed here
      = object : EntityDeleteOrUpdateAdapter<ThisEntityPrimaryKeyClassHasAVeryVeryLongName>() 
   ...
}

Compilation error:

e: file:///.../build/generated/ksp/debug/kotlin/.../MyDao_Impl.kt:... Expecting an element

Comments

da...@google.com <da...@google.com> #2Jan 7, 2025 05:13PM

Reassigned to da...@google.com.

there are some image for help

ap...@google.com <ap...@google.com> #3Mar 3, 2025 11:10PM

hello?

ap...@google.com <ap...@google.com> #4Mar 3, 2025 11:10PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3514432

Update KotlinPoet to 2.1.0

Expand for full commit details

Update KotlinPoet to 2.1.0 
 
KotlinPoet 2.x is source and binary compatible with 1.x but changes how spaces are wrapped, specifically by default it does not wrap white spaces, solving long-standing issues of line breaks leading to generated code that does not compile. 
 
Also updates users of KotlinPoet to target Kotlin 2.0 since KotlinPoet brings a 2.x kotlin-stdlib. 
 
Bug: 388193960 
Test: ./gradlew bOS 
Change-Id: Ic381db48637f17a97be90a0ab850108f9b8a7842

Files:

M appfunctions/appfunctions-compiler/build.gradle
M appfunctions/appfunctions-compiler/src/test/test-data/output/$AllPrimitiveInputFunctions_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$AllPrimitiveInputFunctions_AppFunctionInvoker.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$AppFunctionWithInputFromDifferentPackage_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$AppFunctionWithOutputFromDifferentPackage_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$DerivedSerializableInputFunctions_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$DerivedSerializableOutputFunctions_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$EntityWithDiffPackageSerializablePropertyFactory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$EntityWithValidNullablePropertiesFactory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$EntityWithValidPropertiesFactory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$FakeAllPrimitiveParamsImpl_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$FakeAllPrimitiveReturnsImpl_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$NestedBaseSerializableFactory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$NestedDerivedSerializableFactory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$NestedDerivedSerializableInputFunctions_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$NestedDerivedSerializableOutputFunctions_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$NonNestedChildSerializableFactory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$RecursiveSerializableFactory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$RecursiveSerializableInputFunctions_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$SerializableInputFunctions_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$SerializableOutputFunctions_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$SimpleFunction_AppFunctionInventory.KT
M appfunctions/appfunctions-compiler/src/test/test-data/output/$StringBaseSerializableFactory.KT
M development/build_log_simplifier/messages.ignore
M gradle/libs.versions.toml
M navigation/navigation-safe-args-generator/build.gradle
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/KotlinNavWriterTest.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/NavGeneratorTest.kt
M navigation/navigation-safe-args-generator/src/test/kotlin/androidx/navigation/safe/args/generator/TestUtils.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/MainFragmentArgs.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/Next.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/ReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyReallyLongNameMainFragmentArgs.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsDirections.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsFragmentDirections.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/SettingsFragmentDirections.kt
M navigation/navigation-safe-args-gradle-plugin/build.gradle
M privacysandbox/tools/tools-apicompiler/build.gradle
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/AbstractSandboxedSdkProviderCompat.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/IMySharedUiInterfaceCoreLibInfoAndBinderWrapperConverter.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/IMyUiInterfaceCoreLibInfoAndBinderWrapperConverter.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/InnerValueConverter.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/MyCallbackClientProxy.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/MyInterfaceStubDelegate.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/MySdkStubDelegate.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/MySecondInterfaceStubDelegate.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/RequestConverter.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/RequestFlagConverter.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/ResponseConverter.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/fullfeaturedsdk/output/com/mysdk/SdkActivityLauncherAndBinderWrapper.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/sdkwithpackages/output/com/myotherpackage/MyOtherPackageDataClassConverter.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/sdkwithpackages/output/com/myotherpackage/MyOtherPackageInterfaceStubDelegate.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/sdkwithpackages/output/com/mysdk/AbstractSandboxedSdkProviderCompat.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/sdkwithpackages/output/com/mysdk/MyMainPackageInterfaceStubDelegate.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/sdkwithpackages/output/com/mysdk/MySdkStubDelegate.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/withoutruntimelibrarysdk/output/com/mysdk/AbstractSandboxedSdkProviderCompat.kt
M privacysandbox/tools/tools-apicompiler/src/test/test-data/withoutruntimelibrarysdk/output/com/mysdk/WithoutRuntimeLibrarySdkFactory.kt
M privacysandbox/tools/tools-apigenerator/build.gradle
M privacysandbox/tools/tools-apigenerator/src/test/test-data/callbacks/output/com/sdkwithcallbacks/IMySharedUiInterfaceCoreLibInfoAndBinderWrapperConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/callbacks/output/com/sdkwithcallbacks/IMyUiInterfaceCoreLibInfoAndBinderWrapperConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/callbacks/output/com/sdkwithcallbacks/MyEnumConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/callbacks/output/com/sdkwithcallbacks/MySharedUiInterfaceClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/callbacks/output/com/sdkwithcallbacks/MyUiInterfaceClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/callbacks/output/com/sdkwithcallbacks/ResponseConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/callbacks/output/com/sdkwithcallbacks/SdkActivityLauncherProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/callbacks/output/com/sdkwithcallbacks/SdkServiceFactory.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/interfaces/output/com/sdk/IMySecondInterfaceCoreLibInfoAndBinderWrapperConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/interfaces/output/com/sdk/IMySharedUiInterfaceCoreLibInfoAndBinderWrapperConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/interfaces/output/com/sdk/MyInterface.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/interfaces/output/com/sdk/MyInterfaceClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/interfaces/output/com/sdk/MySdkClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/interfaces/output/com/sdk/MySdkFactory.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/interfaces/output/com/sdk/MySecondInterfaceClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/interfaces/output/com/sdk/MySharedUiInterfaceClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/interfaces/output/com/sdk/SdkActivityLauncherProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/primitives/output/com/mysdk/TestSandboxSdkClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/primitives/output/com/mysdk/TestSandboxSdkFactory.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/IMySharedUiInterfaceCoreLibInfoAndBinderWrapperConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/IMyUiInterfaceCoreLibInfoAndBinderWrapperConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/InnerSdkValueConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/MySharedUiInterfaceClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/MyUiInterfaceClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/RequestFlagConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/SdkActivityLauncherProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/SdkInterfaceClientProxy.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/SdkInterfaceFactory.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/SdkRequestConverter.kt
M privacysandbox/tools/tools-apigenerator/src/test/test-data/values/output/com/sdkwithvalues/SdkResponseConverter.kt
M privacysandbox/tools/tools-apipackager/build.gradle
M privacysandbox/tools/tools-core/build.gradle
M privacysandbox/tools/tools-testing/src/main/java/androidx/privacysandbox/tools/testing/AbstractDiffTest.kt
M room/room-compiler-processing/build.gradle
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_boolean.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_byteArray.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_customTypeConverter.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_customTypeConverter_composite.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_customTypeConverter_internalVisibility.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_customTypeConverter_java.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_customTypeConverter_nullAware.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_customTypeConverter_provided.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_embedded.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_enum.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_internalVisibility.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_otherModule.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_primitives.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_primitives_nullable.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_string.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_uuid.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_valueClassConverter.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_variableProperty.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/dataClassRowAdapter_variableProperty_java.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/database_daoProperty.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/database_internalVisibility.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/database_javaSource.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/database_simple.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/database_withFtsAndView.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/deleteOrUpdateFunctionAdapter.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/entityRowAdapter.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/guavaCallable.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/insertOrUpsertFunctionAdapter.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/multiTypedPagingSourceResultBinder.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/paging_dataSource.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/queryResultAdapter_guavaImmutableMultimap.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/queryResultAdapter_map.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/queryResultAdapter_map_ambiguousIndexAdapter.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/queryResultAdapter_nestedMap.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/queryResultAdapter_nestedMap_ambiguousIndexAdapter.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/relations.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/relations_arrayMap.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/relations_byteBufferKey.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/relations_dataSource.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/relations_longSparseArray.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/relations_nullable.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/relations_set.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/shortcutMethods_rx2.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/shortcutMethods_rx3.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/shortcutMethods_suspend.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/transactionFunctionAdapter_abstractClass.kt
M room/room-compiler/src/test/test-data/kotlinCodeGen/transactionFunctionAdapter_interface.kt

Hash: 6c6067ad58bc6fd6a977ac94ac2d60db16e9e371
Date: Thu Feb 27 13:08:24 2025

da...@google.com <da...@google.com> Mar 3, 2025 11:20PM

Marked as fixed.

Issue 388193960

Description

Issue summary

Comments

da...@google.com <da...@google.com> #2Jan 7, 2025 05:13PM

ap...@google.com <ap...@google.com> #3Mar 3, 2025 11:10PM

ap...@google.com <ap...@google.com> #4Mar 3, 2025 11:10PM

da...@google.com <da...@google.com> Mar 3, 2025 11:20PM

Add comment

Issue metadata