Ksp error due to invalid name: find-Hr90x1I [388299754]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Jan 8, 2025 12:43AM

Version used:

Version used: 2.7.0-alpha12

Ksp error due to invalid name:

[ksp] java.lang.IllegalArgumentException: not a valid name: find-Hr90x1I
	at com.squareup.javapoet.Util.checkArgument(Util.java:53)
	at com.squareup.javapoet.MethodSpec$Builder.setName(MethodSpec.java:315)
	at com.squareup.javapoet.MethodSpec$Builder.<init>(MethodSpec.java:310)
	at com.squareup.javapoet.MethodSpec$Builder.<init>(MethodSpec.java:294)
	at com.squareup.javapoet.MethodSpec.methodBuilder(MethodSpec.java:188)
	at androidx.room.compiler.processing.MethodSpecHelper.overriding(JavaPoetExt.kt:175)
	at androidx.room.compiler.processing.MethodSpecHelper.overridingWithFinalParams(JavaPoetExt.kt:148)
	at androidx.room.compiler.codegen.XFunSpec$Companion.overridingBuilder(XFunSpec.kt:166)
	at androidx.room.compiler.codegen.XFunSpec$Companion.overridingBuilder$default(XFunSpec.kt:158)
	at androidx.room.writer.DaoWriter.overrideWithoutAnnotations(DaoWriter.kt:751)
	at androidx.room.writer.DaoWriter.createSelectMethod(DaoWriter.kt:290)
	at androidx.room.writer.DaoWriter.createTypeSpecBuilder(DaoWriter.kt:142)
	at androidx.room.writer.TypeWriter.write(TypeWriter.kt:70)
	at androidx.room.DatabaseProcessingStep.process(DatabaseProcessingStep.kt:103)
	at androidx.room.compiler.processing.CommonProcessorDelegate.processRound(XBasicAnnotationProcessor.kt:134)
	at androidx.room.compiler.processing.ksp.KspBasicAnnotationProcessor.process(KspBasicAnnotationProcessor.kt:62)
	at com.google.devtools.ksp.AbstractKotlinSymbolProcessingExtension$doAnalysis$8$1.invoke(KotlinSymbolProcessingExtension.kt:320)
	at com.google.devtools.ksp.AbstractKotlinSymbolProcessingExtension$doAnalysis$8$1.invoke(KotlinSymbolProcessingExtension.kt:318)
	at com.google.devtools.ksp.AbstractKotlinSymbolProcessingExtension.handleException(KotlinSymbolProcessingExtension.kt:430)
	at com.google.devtools.ksp.AbstractKotlinSymbolProcessingExtension.doAnalysis(KotlinSymbolProcessingExtension.kt:318)
	at org.jetbrains.kotlin.cli.jvm.compiler.TopDownAnalyzerFacadeForJVM.analyzeFilesWithJavaIntegration(TopDownAnalyzerFacadeForJVM.kt:112)
	at org.jetbrains.kotlin.cli.jvm.compiler.TopDownAnalyzerFacadeForJVM.analyzeFilesWithJavaIntegration$default(TopDownAnalyzerFacadeForJVM.kt:75)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinToJVMBytecodeCompiler.analyze$lambda$9(KotlinToJVMBytecodeCompiler.kt:356)
	at org.jetbrains.kotlin.cli.common.messages.AnalyzerWithCompilerReport.analyzeAndReport(AnalyzerWithCompilerReport.kt:112)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinToJVMBytecodeCompiler.analyze(KotlinToJVMBytecodeCompiler.kt:347)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinToJVMBytecodeCompiler.runFrontendAndGenerateIrUsingClassicFrontend(KotlinToJVMBytecodeCompiler.kt:177)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinToJVMBytecodeCompiler.compileModules$cli(KotlinToJVMBytecodeCompiler.kt:102)
	at org.jetbrains.kotlin.cli.jvm.K2JVMCompiler.doExecute(K2JVMCompiler.kt:169)
	at org.jetbrains.kotlin.cli.jvm.K2JVMCompiler.doExecute(K2JVMCompiler.kt:43)
	at org.jetbrains.kotlin.cli.common.CLICompiler.execImpl(CLICompiler.kt:102)
	at org.jetbrains.kotlin.cli.common.CLICompiler.exec(CLICompiler.kt:316)
	at org.jetbrains.kotlin.daemon.CompileServiceImpl.compile(CompileServiceImpl.kt:1554)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(Unknown Source)
	at java.rmi/sun.rmi.transport.Transport$1.run(Unknown Source)
	at java.rmi/sun.rmi.transport.Transport$1.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
``

Comments

da...@google.com <da...@google.com> #2Jan 8, 2025 01:15AM

Thank you for the report and the code causing the issue. I have landed a reproduction which shows that the code thrown an ArrayIndexOutOfBoundsException from the last bitSet.toByteArray()[0] when not processed by R8.

ma...@gmail.com <ma...@gmail.com> #3Jan 8, 2025 09:38AM

Project: r8
Branch: main
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/100168

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: bf9b1962052bf91689120a09deded518e37862a2
Date: Wed Jan 22 09:41:15 2025

da...@google.com <da...@google.com> #4Jan 8, 2025 02:21PM

deleted

ma...@gmail.com <ma...@gmail.com> #5Jan 8, 2025 02:47PM

I'm really sorry, please use the source code below:

public class R8Test {

    public byte[] toBytes(boolean on) {
        byte[] bytes = new byte[3];
        bytes[0] = 1;
        BitSet bits = new BitSet(8);
        byte[] byteArray = bits.toByteArray();
        if (byteArray != null && byteArray.length >= 1) {
            bytes[1] = bits.toByteArray()[0];
        }

        BitSet bitSet = new BitSet(8);
        byte[] byteArray2 = bits.toByteArray();
        if (byteArray2 != null && byteArray2.length >= 1) {
            bytes[2] = bitSet.toByteArray()[0];
        }
        return bytes;
    }
}

da...@google.com <da...@google.com> #6Jan 8, 2025 03:02PM

Thank you for the update. Most likely the initial source code will still be sufficient to fix the issue.

da...@google.com <da...@google.com> #7Jan 8, 2025 03:29PM

Status: Duplicate of

384600605

Project: r8
Branch: main
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100169

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 8f4ead7ecfe729c0811264de5545f9f104705d0d
Date: Wed Jan 22 12:39:38 2025

ma...@gmail.com <ma...@gmail.com> #8Jan 8, 2025 05:25PM

Project: r8
Branch: main
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100170

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 99e24d1d45d9812d3b4d005690afdcedab1a15bd
Date: Wed Jan 22 13:06:35 2025

da...@google.com <da...@google.com> #9Jan 8, 2025 09:56PM

Status: Assigned (reopened)

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100542

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 3353b45090549cf6d57d6cf0a65b8b5959a705b1
Date: Thu Jan 23 08:33:20 2025

ko...@dumps.app <ko...@dumps.app> #10Jan 29, 2025 07:16PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100543

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: c609582a812828005c7edf12d17f240c746b08c6
Date: Thu Jan 23 08:33:30 2025

da...@google.com <da...@google.com> #11Jan 29, 2025 08:24PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100544

Version 8.7.29

Expand for full commit details

Version 8.7.29 
 
Bug: b/391417819 
Change-Id: I6575d9bb6138a2703066d54d57e2c501a7c143ce

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: e98195210c16e6878b79635ceaec5d2594768414
Date: Thu Jan 23 08:33:36 2025

ap...@google.com <ap...@google.com> #12Jan 29, 2025 11:39PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100526

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 2d5ed830b7418a5647d0d46fd7491e8a6c9508c7
Date: Thu Jan 23 08:33:25 2025

da...@google.com <da...@google.com> Jan 30, 2025 12:43AM

Marked as fixed.

pr...@google.com <pr...@google.com> #13Feb 12, 2025 06:40PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100525

Version 8.8.28

Expand for full commit details

Version 8.8.28 
 
Bug: b/391417819 
Change-Id: Ia53d504317c0f4128fbb1f256ab5660aaf30bcb9

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 46c042e66ab65f238d710fabb2635d80864b19f0
Date: Thu Jan 23 08:32:59 2025

Issue 388299754

Description

Issue summary

Comments

da...@google.com <da...@google.com> #2Jan 8, 2025 01:15AM

ma...@gmail.com <ma...@gmail.com> #3Jan 8, 2025 09:38AM

da...@google.com <da...@google.com> #4Jan 8, 2025 02:21PM

ma...@gmail.com <ma...@gmail.com> #5Jan 8, 2025 02:47PM

da...@google.com <da...@google.com> #6Jan 8, 2025 03:02PM

da...@google.com <da...@google.com> #7Jan 8, 2025 03:29PM

ma...@gmail.com <ma...@gmail.com> #8Jan 8, 2025 05:25PM

da...@google.com <da...@google.com> #9Jan 8, 2025 09:56PM

ko...@dumps.app <ko...@dumps.app> #10Jan 29, 2025 07:16PM

da...@google.com <da...@google.com> #11Jan 29, 2025 08:24PM

ap...@google.com <ap...@google.com> #12Jan 29, 2025 11:39PM

da...@google.com <da...@google.com> Jan 30, 2025 12:43AM

pr...@google.com <pr...@google.com> #13Feb 12, 2025 06:40PM

Add comment

Issue metadata