`Modifier.height(IntrinsicSize)` does not respect `minLines` set on `Text` or `BasicText` [388299762]

Fixed

Bug

Status Update

No update yet.

Description

ad...@guardian.co.uk

created issue #1

Jan 8, 2025 09:53AM

Steps to Reproduce or Code Sample to Reproduce:

The code below should produce a text component 2 lines tall. However it is only 1 line tall. Removing the modifier makes it correctly 2 lines tall.

Repro code:

BasicText(
    text = "Title",
    minLines = 2,
    modifier = Modifier.height(IntrinsicSize.Min)
)

This issue makes it that if any parent container applies this modifier, the text is measured incorrectly, breaking the UI.

Jetpack Compose version: 2024.12.01 BOM

Jetpack Compose component(s) used: BasicText/Text and Modifier.height(IntrinsicSize)

Android Studio Build: Build #AI-242.23339.11.2421.12700392, built on November 22, 2024

Kotlin version: 2.0.21

Comments

gr...@google.com <gr...@google.com> Jan 8, 2025 07:39PM

Reassigned to an...@google.com.

so...@google.com <so...@google.com> Jan 10, 2025 02:28PM

Reassigned to so...@google.com.

ap...@google.com <ap...@google.com> #2Jan 23, 2025 12:37PM

Marked as fixed.

Hi,

Thanks for filing the issue. We can probably add this information to the ImageProxy or ImageInfo. We'll review this internally and get back to you soon.

ap...@google.com <ap...@google.com> #3Jan 23, 2025 12:37PM

By the way, note that this info is already added to the Exif values of saved image if you are using the ImageCapture.OnImageSavedCallback callback instead of ImageCapture.OnImageCapturedCallback. So, if your app requirements don't have any explicit need of OnImageCapturedCallback, that is also an option.

na...@google.com <na...@google.com> #4Jan 29, 2025 06:12PM

Thanks for looking into this. Using ImageProxy or ImageInfo to pass the value seems like a great idea.

I did suspect that ImageCapture.OnImageSavedCallback would have this set, but we have an explicit need for ImageCapture.OnImageCapturedCallback.

Issue 388299762