`Modifier.height(IntrinsicSize)` does not respect `minLines` set on `Text` or `BasicText` [388299762]

Fixed

Bug

Status Update

No update yet.

Description

ad...@guardian.co.uk

created issue #1

Jan 8, 2025 09:53AM

Steps to Reproduce or Code Sample to Reproduce:

The code below should produce a text component 2 lines tall. However it is only 1 line tall. Removing the modifier makes it correctly 2 lines tall.

Repro code:

BasicText(
    text = "Title",
    minLines = 2,
    modifier = Modifier.height(IntrinsicSize.Min)
)

This issue makes it that if any parent container applies this modifier, the text is measured incorrectly, breaking the UI.

Jetpack Compose version: 2024.12.01 BOM

Jetpack Compose component(s) used: BasicText/Text and Modifier.height(IntrinsicSize)

Android Studio Build: Build #AI-242.23339.11.2421.12700392, built on November 22, 2024

Kotlin version: 2.0.21

Comments

gr...@google.com <gr...@google.com> Jan 8, 2025 07:39PM

Reassigned to an...@google.com.

so...@google.com <so...@google.com> Jan 10, 2025 02:28PM

Reassigned to so...@google.com.

ap...@google.com <ap...@google.com> #2Jan 23, 2025 12:37PM

Marked as fixed.

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ap...@google.com <ap...@google.com> #3Jan 23, 2025 12:37PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

na...@google.com <na...@google.com> #4Jan 29, 2025 06:12PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

Issue 388299762