`Modifier.height(IntrinsicSize)` does not respect `minLines` set on `Text` or `BasicText` [388299762]

Fixed

Bug

Status Update

No update yet.

Description

ad...@guardian.co.uk

created issue #1

Jan 8, 2025 09:53AM

Steps to Reproduce or Code Sample to Reproduce:

The code below should produce a text component 2 lines tall. However it is only 1 line tall. Removing the modifier makes it correctly 2 lines tall.

Repro code:

BasicText(
    text = "Title",
    minLines = 2,
    modifier = Modifier.height(IntrinsicSize.Min)
)

This issue makes it that if any parent container applies this modifier, the text is measured incorrectly, breaking the UI.

Jetpack Compose version: 2024.12.01 BOM

Jetpack Compose component(s) used: BasicText/Text and Modifier.height(IntrinsicSize)

Android Studio Build: Build #AI-242.23339.11.2421.12700392, built on November 22, 2024

Kotlin version: 2.0.21

Comments

gr...@google.com <gr...@google.com> Jan 8, 2025 07:39PM

Reassigned to an...@google.com.

so...@google.com <so...@google.com> Jan 10, 2025 02:28PM

Reassigned to so...@google.com.

ap...@google.com <ap...@google.com> #2Jan 23, 2025 12:37PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ap...@google.com <ap...@google.com> #3Jan 23, 2025 12:37PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

na...@google.com <na...@google.com> #4Jan 29, 2025 06:12PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-beta01
androidx.compose.foundation:foundation-android:1.8.0-beta01
androidx.compose.foundation:foundation-jvmstubs:1.8.0-beta01
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-beta01

Issue 388299762