[Regression] Modifier.dragAndDropSource doesn't initiate system drag and drop [388353336]

Fixed

Bug

Status Update

No update yet.

Description

va...@google.com

created issue #1

Jan 8, 2025 12:44AM

At tip-of-tree, on at least API 24, 28, and 30, the Foundation -> Drag and drop -> Multi app drag and drop demo no longer works.

The app doesn't crash, but the following exception is printed to logcat and the drag doesn't start:

Unable to initiate drag
                                                                                                    java.lang.NullPointerException
                                                                                                    	at androidx.compose.ui.node.LayoutNodeDrawScope.drawContent(LayoutNodeDrawScope.kt:46)
                                                                                                    	at androidx.compose.foundation.draganddrop.CacheDrawScopeDragShadowCallback$cachePicture$1$1$1.invoke(AndroidDragAndDropSource.android.kt:55)
                                                                                                    	at androidx.compose.foundation.draganddrop.CacheDrawScopeDragShadowCallback$cachePicture$1$1$1.invoke(AndroidDragAndDropSource.android.kt:55)
                                                                                                    	at androidx.compose.ui.draw.CacheDrawScope$record$1.invoke(DrawModifier.kt:347)
                                                                                                    	at androidx.compose.ui.draw.CacheDrawScope$record$1.invoke(DrawModifier.kt:338)
                                                                                                    	at androidx.compose.ui.graphics.layer.GraphicsLayer.draw$ui_graphics_release(AndroidGraphicsLayer.android.kt:1078)
                                                                                                    	at androidx.compose.ui.graphics.layer.GraphicsLayerKt.drawLayer(GraphicsLayer.kt:51)
                                                                                                    	at androidx.compose.foundation.draganddrop.CacheDrawScopeDragShadowCallback.drawDragShadow(AndroidDragAndDropSource.android.kt:48)
                                                                                                    	at androidx.compose.foundation.draganddrop.DragSourceNodeWithDefaultPainter$dragAndDropModifierNode$1.invoke(DragAndDropSource.kt:240)
                                                                                                    	at androidx.compose.foundation.draganddrop.DragSourceNodeWithDefaultPainter$dragAndDropModifierNode$1.invoke(DragAndDropSource.kt:238)
                                                                                                    	at androidx.compose.ui.draganddrop.ComposeDragShadowBuilder.onDrawShadow(ComposeDragShadowBuilder.android.kt:74)
                                                                                                    	at android.view.View.startDragAndDrop(View.java:24051)
                                                                                                    	at androidx.compose.ui.platform.AndroidComposeViewStartDragAndDropN.startDragAndDrop(AndroidComposeView.android.kt:3029)
                                                                                                    	at androidx.compose.ui.platform.AndroidComposeView.startDrag-12SF9DM(AndroidComposeView.android.kt:1294)
                                                                                                    	at androidx.compose.ui.platform.AndroidComposeView.access$startDrag-12SF9DM(AndroidComposeView.android.kt:235)
                                                                                                    	at androidx.compose.ui.platform.AndroidComposeView$dragAndDropManager$1.invoke-12SF9DM(AndroidComposeView.android.kt:323)
                                                                                                    	at androidx.compose.ui.platform.AndroidComposeView$dragAndDropManager$1.invoke(AndroidComposeView.android.kt:323)
                                                                                                    	at androidx.compose.ui.draganddrop.AndroidDragAndDropManager$requestDragAndDropTransfer$dragAndDropSourceScope$1.startDragAndDropTransfer-12SF9DM(AndroidDragAndDropManager.android.kt:75)
                                                                                                    	at androidx.compose.foundation.draganddrop.DragAndDropSourceNode$dragAndDropModifierNode$1.invoke-Uv8p0NA(DragAndDropSource.kt:160)
                                                                                                    	at androidx.compose.foundation.draganddrop.DragAndDropSourceNode$dragAndDropModifierNode$1.invoke(DragAndDropSource.kt:157)
                                                                                                    	at androidx.compose.ui.draganddrop.DragAndDropNode$startDragAndDropTransfer$1.invoke(DragAndDropNode.kt:292)
                                                                                                    	at androidx.compose.ui.draganddrop.DragAndDropNode$startDragAndDropTransfer$1.invoke(DragAndDropNode.kt:275)
                                                                                                    	at androidx.compose.ui.draganddrop.DragAndDropNodeKt.traverseSelfAndDescendants(DragAndDropNode.kt:473)
                                                                                                    	at androidx.compose.ui.draganddrop.DragAndDropNodeKt.access$traverseSelfAndDescendants(DragAndDropNode.kt:1)
                                                                                                    	at androidx.compose.ui.draganddrop.DragAndDropNode.startDragAndDropTransfer-d-4ec7I(DragAndDropNode.kt:275)
                                                                                                    	at androidx.compose.ui.draganddrop.AndroidDragAndDropManager.requestDragAndDropTransfer-Uv8p0NA(AndroidDragAndDropManager.android.kt:83)
                                                                                                    	at androidx.compose.ui.draganddrop.DragAndDropNode.requestDragAndDropTransfer-k-4lQ0M(DragAndDropNode.kt:258)
                                                                                                    	at androidx.compose.foundation.draganddrop.DragAndDropSourceNode$onAttach$1$1.requestDragAndDropTransfer-k-4lQ0M(DragAndDropSource.kt:179)
                                                                                                    	at androidx.compose.foundation.draganddrop.DragAndDropSourceDefaults$DefaultStartDetector$1$1.invoke-k-4lQ0M(AndroidDragAndDropSource.android.kt:33)
                                                                                                    	at androidx.compose.foundation.draganddrop.DragAndDropSourceDefaults$DefaultStartDetector$1$1.invoke(AndroidDragAndDropSource.android.kt:33)
                                                                                                    	at androidx.compose.foundation.gestures.TapGestureDetectorKt$detectTapGestures$2$1.invokeSuspend(TapGestureDetector.kt:121)
                                                                                                    	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                                                                                                    	at kotlinx.coroutines.DispatchedTaskKt.resume(DispatchedTask.kt:179)
                                                                                                    	at kotlinx.coroutines.DispatchedTaskKt.dispatch(DispatchedTask.kt:168)
2025-01-08 00:16:24.153  6034-6034  View                    androidx.compose.integration.demos   E  	at kotlinx.coroutines.CancellableContinuationImpl.dispatchResume(CancellableContinuationImpl.kt:474)
                                                                                                    	at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl(CancellableContinuationImpl.kt:508)
                                                                                                    	at kotlinx.coroutines.CancellableContinuationImpl.resumeImpl$default(CancellableContinuationImpl.kt:497)
                                                                                                    	at kotlinx.coroutines.CancellableContinuationImpl.resumeWith(CancellableContinuationImpl.kt:368)
                                                                                                    	at androidx.compose.ui.input.pointer.SuspendingPointerInputModifierNodeImpl$PointerEventHandlerCoroutine$withTimeout$job$1.invokeSuspend(SuspendingPointerInputFilter.kt:887)
                                                                                                    	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                                                                                                    	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
                                                                                                    	at androidx.compose.ui.platform.AndroidUiDispatcher.performTrampolineDispatch(AndroidUiDispatcher.android.kt:79)
                                                                                                    	at androidx.compose.ui.platform.AndroidUiDispatcher.access$performTrampolineDispatch(AndroidUiDispatcher.android.kt:41)
                                                                                                    	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.run(AndroidUiDispatcher.android.kt:57)
                                                                                                    	at android.os.Handler.handleCallback(Handler.java:873)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:99)
                                                                                                    	at android.os.Looper.loop(Looper.java:193)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:6669)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Reverting aosp/3408267 allows the system drag and drop to work again.

Comments

va...@google.com <va...@google.com> #2Jan 8, 2025 12:46AM

This was fixed in

https://android-review.googlesource.com/880833 and will be available in Navigation 1.0.0-alpha10.

lp...@google.com <lp...@google.com> #3Jan 8, 2025 01:04AM

Reassigned to lp...@google.com.

I made a change here recently, probably responsible

lp...@google.com <lp...@google.com> #4Jan 8, 2025 01:16PM

Some testing notes, doesn't seem to reproduce for me on API 35, but does on API 30

ap...@google.com <ap...@google.com> #5Jan 8, 2025 09:40PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Alex Vanyo <vanyo@google.com>
Link: https://android-review.googlesource.com/3440173

Revert "Fixes issue with dragAndDropSource preventing child invalidations"

Expand for full commit details

Revert "Fixes issue with dragAndDropSource preventing child invalidations" 
 
This reverts commit 874505db38c2ea6a0ecee16c9f20eda1de35492a. 
 
Reason for revert: Prevents system drag and drop from occurring with default decoration on older API levels: b/388353336 
 
Change-Id: Ie9948a699df139b386186c407e908fa1697bbb29

Files:

D compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/draganddrop/DragAndDropSourceTest.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/draganddrop/AndroidDragAndDropSource.android.kt

Hash: 3d5fd7d04bdd7f02ee2b215af68b2832e06134bf
Date: Tue Jan 07 17:35:34 2025

va...@google.com <va...@google.com> #6Jan 8, 2025 10:07PM

I submitted the revert, should this bug be closed and b/379682458 reopened?

lp...@google.com <lp...@google.com> Jan 9, 2025 02:15AM

Marked as fixed.

pr...@google.com <pr...@google.com> #7Jan 15, 2025 06:30PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha08
androidx.compose.foundation:foundation-android:1.8.0-alpha08
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha08
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha08