Status Update
Comments
mg...@google.com <mg...@google.com>
mg...@google.com <mg...@google.com>
ap...@google.com <ap...@google.com> #2
Attached reproducing video of an app using calculateWindowSizeClass
and LocalConfiguration
:
On the second time resizing to be 50%/50% from smaller, the displayed configuration is incorrect.
ap...@google.com <ap...@google.com> #3
When resizing the activity in multi-window mode under those conditions, there are cases where:
the Activity is not recreated Activity.onConfigurationChanged is not called View.onConfigurationChanged is not called
Is this just for 33 / is there a framework bug filed? The amount of broken things in configuration land we already had to workaround in Compose is a bit untenable. It seems like we are missing a lot of test coverage in the platform to avoid these issues hitting us in the future
na...@google.com <na...@google.com> #4
In any case this seems like more ammunition for us to push more strongly on 'pure-compose apps should always opt out of configuration changes'
Description
Component used: Lifecycle ViewModel SavedState
Version used: 2.9.0-alpha08
With the introduction of
CreationExtras
andviewModelFactory
,AbstractSavedStateViewModelFactory
is no longer needed and should be deprecated or at least marked as discouraged since it forces the creation of aSavedStateHandle
for every ViewModel even if the ViewModel does not require one, causing pressure on the saved instance state size and additional book keeping.