Rework measureRepeated to be based on coroutines [389149423]

Assigned

Feature Request

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Jan 10, 2025 10:38PM

Currently, there are several problems with the architecture of BenchmarkState/BenchmarkRule:

BenchmarkState has extremely complex state management due to attempting to expose a single keepRunning API
Trace capture happens within BenchmarkRule instead of measureRepeated (to allow it to support the Java API)
Yielding the main thread from within measureRepeatedOnMainThread() is awkward, and happens within the measurement loop
sleep after thermal throttling is detected doesn't yield, so can cause ANRs with measureRepeatedOnMainThread (b/311242861)
configuration (e.g. profiler, metric type, looping behavior) and data output (json, instrumentation results, traces) are distributed, and not easily simplified (ideally measureRepeated would return all of this data)

This bug tracks an effort to rewrite much of the top level control flow of BenchmarkRule / BenchmarkState to be based on coroutines, and address all the above problems.

Comments

ap...@google.com <ap...@google.com> #2Jan 16, 2025 09:18PM

Would you like to move it to android.hardware.biometrics? It looks like the problem is deeper than androidx.

cc...@google.com <cc...@google.com> #3Jan 16, 2025 10:06PM

Native Android 10 BiometricPrompt has exactly the same issue. If fixing this in the platform is impractical, maybe AndroidX Biometrics library can implement some workaround?

ap...@google.com <ap...@google.com> #4Jan 28, 2025 06:41PM

exxbrain@ can you attach a bugreport?

gr...@google.com <gr...@google.com> #5Feb 11, 2025 11:39AM

I've created two sample projects (see attachment): one with android.hardware.biometrics (TestBiometricQ), other with androidx.biometric:biometric:1.0.0 (TestBiometricX).
They both have the same issue with setDeviceCredentialAllowed(true) (see #1).

Bug reports:

https://drive.google.com/file/d/1fx4EyHdfJ1koRIt2KZ1emQeRdSDnNOkG/view?usp=drive_web (biometric_q_report.zip)

https://drive.google.com/file/d/1PASxQhxXvLp62t91mYis28QhGqvHBfD5/view?usp=drive_web (biometric_x_report.zip)

On attached screenshots you can see "onAuthenticationError" toast alongside device pattern UI.

Issue 389149423

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jan 16, 2025 09:18PM

cc...@google.com <cc...@google.com> #3Jan 16, 2025 10:06PM

ap...@google.com <ap...@google.com> #4Jan 28, 2025 06:41PM

gr...@google.com <gr...@google.com> #5Feb 11, 2025 11:39AM

Add comment

Issue metadata