Assigned

Bug

Status Update

No update yet.

Description

po...@gmail.com

created issue #1

Jan 13, 2025 08:49PM

Jetpack Compose version: 1.7.6
Jetpack Compose component used:
- androidx.compose.ui.text.TextStyle
- androidx.compose.ui.text.style.TextAlign
- androidx.compose.ui.text.style.TextOverflow
Android Studio Build: Ladybug Feature Drop 2024.2.2
Kotlin version: 2.1.0
Devices/Android versions reproduced on: Phone Emulator (API 34)
Keyboard (i.e. Gboard, Samsung, etc): AOSP Keyboard

If you have Material text

Text(
    text = "Hello Android!".repeat(5),
    textAlign = TextAlign.Center,
    letterSpacing = 1.sp,
    overflow = TextOverflow.Ellipsis,
    maxLines = 1
)

inside the layout with Modifier.imePadding() applied to it, and trigger the appearance of the soft keyboard, then text starts to move to the right of the screen.

This bug is very similar to this one and is probably related to this code (it was introduced here).

Screenshots and video attached.

Sample project to reproduce the problem (this is the exact place in the code).

TextPaddingBug.png

155 KB

View

Download

TextPaddingBug Demo.mp4

794 KB

Download

NoTextPaddingBug.png

158 KB

View

Download

Comments

se...@google.com <se...@google.com> #2Jan 13, 2025 09:43PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

po...@gmail.com <po...@gmail.com> #3Jan 13, 2025 09:53PM

🥰

se...@google.com <se...@google.com> #4Jan 14, 2025 06:48PM

Ime is not necessary part of repro, relayout does it.

@Composable
private fun TextCrash() {
    val infiniteTransition = rememberInfiniteTransition(label = "infinite transition")
    val padding by infiniteTransition.animateFloat(
        initialValue = 0f,
        targetValue = 50f,
        animationSpec = infiniteRepeatable(tween(1000), RepeatMode.Reverse),
        label = "I like to move it move it"
    )

    Box(
        modifier = Modifier
            .padding(padding.toInt().dp)
            .fillMaxSize(),
        contentAlignment = Alignment.Center
    ) {
        Column(verticalArrangement = Arrangement.spacedBy(12.dp)) {
            Text(
                text = "Hello Android!".repeat(5),
                textAlign = TextAlign.Center,
                letterSpacing = 1.sp,
                overflow = TextOverflow.Ellipsis,
                maxLines = 1
            )
        }
    }
}

se...@google.com <se...@google.com> #5Jan 14, 2025 09:49PM

This is the minimal TextStyle to repro

se...@google.com <se...@google.com> #6Jan 14, 2025 09:49PM

TextStyle(
            textAlign = TextAlign.Center,
            letterSpacing = 1.sp,
            lineHeight = 24.sp,
            lineHeightStyle = LineHeightStyle(
                alignment = LineHeightStyle.Alignment.Center,
                trim = LineHeightStyle.Trim.None,
                mode = LineHeightStyle.Mode.Fixed
            ),
        )

Message last modified on Jan 14, 2025 10:01PM

se...@google.com <se...@google.com> #7Jan 15, 2025 12:40AM

Reassigned to se...@google.com.

Fix coming. Will see if I can get it into 1.8-beta01.

fixed video.webm

510 KB

Download

po...@gmail.com <po...@gmail.com> #8Jan 15, 2025 01:00AM

Amazing! That was super quick)

se...@google.com <se...@google.com> #9Jan 15, 2025 07:23PM

Excellent bug report and I had some idle cycles this week :)

IssueTracker

Text with TextOverflow.Ellipsis, TextAlign.Center and letter spacing is moving to the right

Status Update

Description

Comments

se...@google.com <se...@google.com> #2Jan 13, 2025 09:43PM

po...@gmail.com <po...@gmail.com> #3Jan 13, 2025 09:53PM

🥰

se...@google.com <se...@google.com> #4Jan 14, 2025 06:48PM

se...@google.com <se...@google.com> #5Jan 14, 2025 09:49PM

se...@google.com <se...@google.com> #6Jan 14, 2025 09:49PM

se...@google.com <se...@google.com> #7Jan 15, 2025 12:40AM

po...@gmail.com <po...@gmail.com> #8Jan 15, 2025 01:00AM

se...@google.com <se...@google.com> #9Jan 15, 2025 07:23PM

Issue 389707025

Description

Issue summary

Comments

se...@google.com <se...@google.com> #2Jan 13, 2025 09:43PM

po...@gmail.com <po...@gmail.com> #3Jan 13, 2025 09:53PM

🥰

se...@google.com <se...@google.com> #4Jan 14, 2025 06:48PM

se...@google.com <se...@google.com> #5Jan 14, 2025 09:49PM

se...@google.com <se...@google.com> #6Jan 14, 2025 09:49PM

se...@google.com <se...@google.com> #7Jan 15, 2025 12:40AM

po...@gmail.com <po...@gmail.com> #8Jan 15, 2025 01:00AM

se...@google.com <se...@google.com> #9Jan 15, 2025 07:23PM

Add comment

Issue metadata