LimitOffsetPagingSource loads partial initial page when near bottom of the list causing ui jump [389729367]

Fixed

Bug

Status Update

No update yet.

Description

ev...@tatarka.me

created issue #1

Jan 13, 2025 10:17PM

Component used: room, room-paging Version used: 2.7.0-alpha12 Devices/Android versions reproduced on: emulator

Steps to reproduce:

Scroll to the end of the list. Then preform a refresh that reduces the number of items in the database but keeps the last items that are visible.
Note the ui jumps up several items. This is is because the first load is smaller than the screen size.

This appears to be caused by the logic in https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:room/room-paging/src/commonMain/kotlin/androidx/room/paging/util/RoomPagingUtil.kt;drc=6d0e4120b9ea66164e1f3c1d93e711fac2aed847;l=76 specifically, if the refresh key lands within the last page it'll load fewer items than expected.

Changing

if (key >= itemCount) {
    maxOf(0, itemCount - params.loadSize)
} else {
    key
}

if (key >= itemCount - params.loadSize) {
    maxOf(0, itemCount - params.loadSize)
} else {
    key
}

should fix it.

Comments

da...@google.com <da...@google.com> Jan 15, 2025 05:25PM

Reassigned to da...@google.com.

ap...@google.com <ap...@google.com> #2Jan 15, 2025 07:49PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

na...@google.com <na...@google.com> #3Jan 29, 2025 06:11PM

Project: platform/frameworks/support
Branch: androidx-main

commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 now with workaround for

https://youtrack.jetbrains.com/issue/KT-62653

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3156121

Issue 389729367

Description

Issue summary

Comments

da...@google.com <da...@google.com> Jan 15, 2025 05:25PM

ap...@google.com <ap...@google.com> #2Jan 15, 2025 07:49PM

na...@google.com <na...@google.com> #3Jan 29, 2025 06:11PM

Add comment

Issue metadata