Wildcard Deep-link stopped work since 2.8.0 [389970341]

Fixed

Bug

Status Update

No update yet.

Description

lo...@gmail.com

created issue #1

Jan 15, 2025 03:51PM

Component used: Navigation Version used: 2.7.7 - success 2.8.0 - failed 2.8.5 - failed 2.9.0-alpha04 - failed

Devices/Android versions reproduced on: tested API 30, 33. i think any affected

Sample project to trigger the issue. in the attachments
A screenrecord or screenshots showing the issue (if UI related). in the attachments

Issue: wildcard segment in deep link stopped work as expected since 2.8.0 and till latest 2.9.0-alpha04

# success always
navDeepLink {
    uriPattern = "https://example.com/{id}"
    action = Intent.ACTION_VIEW
}

# success till 2.7.7
# failed since 2.8.0 till 2.9.0-alpha04
navDeepLink {
    uriPattern = "https://example.com/{id}/.*"
    action = Intent.ACTION_VIEW
}

spent ~2 days to understand the reason!!! when examples from internet work, but my app - not.

Kazam_screencast_00003.mp4

15 MB

Download

DeepLinkWildcardBug.zip

40 MB

Download

Comments

jb...@google.com <jb...@google.com> Jan 22, 2025 04:22PM

Assigned to cl...@google.com.

lo...@gmail.com <lo...@gmail.com> #2Jan 24, 2025 04:23PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

DeepLinkWildcardBug.zip

32 MB

Download

ap...@google.com <ap...@google.com> #3Feb 10, 2025 11:32PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <clarafok@google.com>
Link: https://android-review.googlesource.com/3487732

Fix path wildcard not matching with added deeplink

Expand for full commit details

Fix path wildcard not matching with added deeplink 
 
In a previous change to support empty string arguments (aosp/3136075), uriPattern regex for routes were updated. However, the logic that determines whether a deeplink route is an exact DeepLink still references the old regex, leading to routes being falsely identified as an exact match. 
 
When we compare matching deeplinks, exact match > matching arguments. Therefore, regex bug leads to deeplinks without matching arguments being prioritized over deeplinks with matching arguments + wildCard. 
 
In this fix, we update the isExactMatch logic to look for the updated regex. 
 
Test: ./gradlew navigation:navigation-common:cC 
Bug: 389970341 
Relnote: "Fix bug where routes with wildcard paths do not match with an added deeplink" 
Change-Id: I7ea9206cbecb6ca3d74fbca7721bd2e40e3f915d

Files:

M navigation/navigation-common/src/androidInstrumentedTest/kotlin/androidx/navigation/NavDeepLinkTest.kt
M navigation/navigation-common/src/androidInstrumentedTest/kotlin/androidx/navigation/NavGraphAndroidTest.kt
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDeepLink.android.kt

Hash: 6b994dacfdb1e19f1b26cad5af80b7268206ed08
Date: Mon Feb 10 14:37:22 2025

cl...@google.com <cl...@google.com> #4Feb 10, 2025 11:46PM

Marked as fixed.

Original bug fixed and available in navigation 2.8.8.

As for the bug in comment#2, it appears to be a different cause. I've filed a separate issue for it at https://issuetracker.google.com/issues/395712033

lo...@gmail.com <lo...@gmail.com> #5Feb 12, 2025 10:03AM

Original bug fixed and available in navigation 2.8.8.

don't see release 2.8.8 on https://developer.android.com/jetpack/androidx/releases/navigation. when it will be available? thanks!

Message last modified on Feb 12, 2025 10:04AM

cl...@google.com <cl...@google.com> #6Feb 12, 2025 05:54PM

It will be available on Feb 26th

Issue 389970341

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> Jan 22, 2025 04:22PM

lo...@gmail.com <lo...@gmail.com> #2Jan 24, 2025 04:23PM

ap...@google.com <ap...@google.com> #3Feb 10, 2025 11:32PM

cl...@google.com <cl...@google.com> #4Feb 10, 2025 11:46PM

lo...@gmail.com <lo...@gmail.com> #5Feb 12, 2025 10:03AM

cl...@google.com <cl...@google.com> #6Feb 12, 2025 05:54PM

Add comment

Issue metadata