Fixed
Status Update
Comments
jb...@google.com <jb...@google.com>
lo...@gmail.com <lo...@gmail.com> #2
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
ap...@google.com <ap...@google.com> #3
yea i'll take it.
cl...@google.com <cl...@google.com> #4
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
lo...@gmail.com <lo...@gmail.com> #5
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
cl...@google.com <cl...@google.com> #6
With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)
Description
Component used: Navigation Version used: 2.7.7 - success 2.8.0 - failed 2.8.5 - failed 2.9.0-alpha04 - failed
Devices/Android versions reproduced on: tested API 30, 33. i think any affected
Sample project to trigger the issue. in the attachments
A screenrecord or screenshots showing the issue (if UI related). in the attachments
Issue: wildcard segment in deep link stopped work as expected since 2.8.0 and till latest 2.9.0-alpha04
spent ~2 days to understand the reason!!! when examples from internet work, but my app - not.