Status Update
No update yet.
Comments
jb...@google.com
lo...@gmail.com
also doesn't work https://example.com/path/detail?token=123 in all versions:
pattern:
https://example.com/path/.*?token={id}
P.S. updated test project
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Clara Fok <
Link:
Fix path wildcard not matching with added deeplink
Expand for full commit details
Fix path wildcard not matching with added deeplink
In a previous change to support empty string arguments (aosp/3136075), uriPattern regex for routes were updated. However, the logic that determines whether a deeplink route is an exact DeepLink still references the old regex, leading to routes being falsely identified as an exact match.
When we compare matching deeplinks, exact match > matching arguments. Therefore, regex bug leads to deeplinks without matching arguments being prioritized over deeplinks with matching arguments + wildCard.
In this fix, we update the isExactMatch logic to look for the updated regex.
Test: ./gradlew navigation:navigation-common:cC
Bug: 389970341
Relnote: "Fix bug where routes with wildcard paths do not match with an added deeplink"
Change-Id: I7ea9206cbecb6ca3d74fbca7721bd2e40e3f915d
Files:
- M
navigation/navigation-common/src/androidInstrumentedTest/kotlin/androidx/navigation/NavDeepLinkTest.kt - M
navigation/navigation-common/src/androidInstrumentedTest/kotlin/androidx/navigation/NavGraphAndroidTest.kt - M
navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDeepLink.android.kt
Hash: 6b994dacfdb1e19f1b26cad5af80b7268206ed08
Date: Mon Feb 10 14:37:22 2025
cl...@google.com
Original bug fixed and available in navigation 2.8.8.
As for the bug in
lo...@gmail.com
Original bug fixed and available in navigation 2.8.8.
don't see release 2.8.8 on https://developer.android.com/jetpack/androidx/releases/navigation.
when it will be available?
thanks!
cl...@google.com
It will be available on Feb 26th
Description
Component used: Navigation Version used: 2.7.7 - success 2.8.0 - failed 2.8.5 - failed 2.9.0-alpha04 - failed
Devices/Android versions reproduced on: tested API 30, 33. i think any affected
Sample project to trigger the issue. in the attachments
A screenrecord or screenshots showing the issue (if UI related). in the attachments
Issue: wildcard segment in deep link stopped work as expected since 2.8.0 and till latest 2.9.0-alpha04
spent ~2 days to understand the reason!!! when examples from internet work, but my app - not.