[NavigationSuiteScaffold] ViewModel not cleared when navigating away [390201791]

Assigned

Bug

Status Update

No update yet.

Description

ad...@gmail.com

created issue #1

Jan 15, 2025 07:08PM

Hey there,

I'm migrating from Scaffold with bottomBar + NavHost to NavigationSuiteScaffold and observe some weird behavior.
My expectation was that navigating away from a screen would trigger onCleared on its containing ViewModel but that is not the case anymore.

Some examples where this reproduces:

git@github.com:android/nowinandroid.git
git@github.com:joreilly/PeopleInSpace.git

Some example with NavHost where I see the expected behavior:

git@github.com:joreilly/FantasyPremierLeague.git

Can you please advise?

Comments

co...@google.com <co...@google.com> #2Jan 17, 2025 12:22AM

Assigned to le...@google.com.

Tram, can you confirm that the behavior is correct if the modifier is moved to the composable inside the AnimatedPane?

ad...@gmail.com <ad...@gmail.com> #3Jan 27, 2025 04:27PM

Hi Max, yes when the modifiers are moved to the composable inside the AnimatedPane, the PB animations are better than when the modifiers are in the AnimatedPane itself

Issue 390201791

Description

Issue summary

Comments

co...@google.com <co...@google.com> #2Jan 17, 2025 12:22AM

ad...@gmail.com <ad...@gmail.com> #3Jan 27, 2025 04:27PM

Add comment

Issue metadata