Status Update
Comments
ch...@google.com <ch...@google.com>
sg...@google.com <sg...@google.com> #2
We're seeing a similar error in our code. Appears to be a combination of AGP 8.6.0 and Kotlin 2 needed to hit it.
private fun Intent.stripUnwantedFlags() {
// Explicitly remove the new task and clear task flags (Our browser activity is a single
// task activity and we never want to start a second task here).
flags = flags and Intent.FLAG_ACTIVITY_NEW_TASK.inv()
flags = flags and Intent.FLAG_ACTIVITY_CLEAR_TASK.inv()
// IntentReceiverActivity is started with the "excludeFromRecents" flag (set in manifest). We
// do not want to propagate this flag from the intent receiver activity to the browser.
flags = flags and Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS.inv()
}
All 3 lines then hit:
Must be one or more of: Intent.FLAG_GRANT_READ_URI_PERMISSION, Intent.FLAG_GRANT_WRITE_URI_PERMISSION, Intent.FLAG_FROM_BACKGROUND, Intent.FLAG_DEBUG_LOG_RESOLUTION, Intent.FLAG_EXCLUDE_STOPPED_PACKAGES, Intent.FLAG_INCLUDE_STOPPED_PACKAGES, Intent.FLAG_GRANT_PERSISTABLE_URI_PERMISSION, Intent.FLAG_GRANT_PREFIX_URI_PERMISSION, Intent.FLAG_ACTIVITY_MATCH_EXTERNAL, Intent.FLAG_ACTIVITY_NO_HISTORY, Intent.FLAG_ACTIVITY_SINGLE_TOP, Intent.FLAG_ACTIVITY_NEW_TASK, Intent.FLAG_ACTIVITY_MULTIPLE_TASK, Intent.FLAG_ACTIVITY_CLEAR_TOP, Intent.FLAG_ACTIVITY_FORWARD_RESULT, Intent.FLAG_ACTIVITY_PREVIOUS_IS_TOP, Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS, Intent.FLAG_ACTIVITY_BROUGHT_TO_FRONT, Intent.FLAG_ACTIVITY_RESET_TASK_IF_NEEDED, Intent.FLAG_ACTIVITY_LAUNCHED_FROM_HISTORY, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NEW_DOCUMENT, Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET, Intent.FLAG_ACTIVITY_NO_USER_ACTION, Intent.FLAG_ACTIVITY_REORDER_TO_FRONT, Intent.FLAG_ACTIVITY_NO_ANIMATION, Intent.FLAG_ACTIVITY_CLEAR_TASK, Intent.FLAG_ACTIVITY_TASK_ON_HOME, Intent.FLAG_ACTIVITY_RETAIN_IN_RECENTS, Intent.FLAG_ACTIVITY_LAUNCH_ADJACENT, Intent.FLAG_ACTIVITY_REQUIRE_NON_BROWSER, Intent.FLAG_ACTIVITY_REQUIRE_DEFAULT, Intent.FLAG_RECEIVER_REGISTERED_ONLY, Intent.FLAG_RECEIVER_REPLACE_PENDING, Intent.FLAG_RECEIVER_FOREGROUND, Intent.FLAG_RECEIVER_NO_ABORT, Intent.FLAG_RECEIVER_VISIBLE_TO_INSTANT_APPS
ap...@google.com <ap...@google.com> #3
The initial report (
However,
hs...@siren.plus <hs...@siren.plus> #4
ap...@google.com <ap...@google.com> #7
Thanks for the update!
ap...@google.com <ap...@google.com> #8
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Ladybug Feature Drop | 2024.2.2 Canary 2
- Android Gradle Plugin 8.8.0-alpha02
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
ap...@google.com <ap...@google.com> #9
The fixes for this issue are now also available in:
- Android Studio Ladybug | 2024.2.1 RC 1
- Android Gradle Plugin 8.7.0-rc01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
ap...@google.com <ap...@google.com> #10
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Extend ArrayConstructionSimplifier dominance checks
Expand for full commit details
Extend ArrayConstructionSimplifier dominance checks
Fixes: b/391417819
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: c609582a812828005c7edf12d17f240c746b08c6
Date: Thu Jan 23 08:33:30 2025
ap...@google.com <ap...@google.com> #11
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Version 8.7.29
Expand for full commit details
Version 8.7.29
Bug: b/391417819
Change-Id: I6575d9bb6138a2703066d54d57e2c501a7c143ce
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: e98195210c16e6878b79635ceaec5d2594768414
Date: Thu Jan 23 08:33:36 2025
ap...@google.com <ap...@google.com> #12
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Minimize reproduction for
Expand for full commit details
Minimize reproduction for b/391417819
Bug: b/391417819
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433
Files:
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 2d5ed830b7418a5647d0d46fd7491e8a6c9508c7
Date: Thu Jan 23 08:33:25 2025
ap...@google.com <ap...@google.com> #13
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Version 8.8.28
Expand for full commit details
Version 8.8.28
Bug: b/391417819
Change-Id: Ia53d504317c0f4128fbb1f256ab5660aaf30bcb9
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: 46c042e66ab65f238d710fabb2635d80864b19f0
Date: Thu Jan 23 08:32:59 2025
ap...@google.com <ap...@google.com> #14
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Extend ArrayConstructionSimplifier dominance checks
Expand for full commit details
Extend ArrayConstructionSimplifier dominance checks
Fixes: b/391417819
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 8742667733c823ce28496032566dd67b61c77b93
Date: Thu Jan 23 08:32:53 2025
ap...@google.com <ap...@google.com> #15
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of issue 391417819
Bug: b/391417819
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0
Files:
- A
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: cf6351164bfa81c0825804a298a2002427703bb8
Date: Thu Jan 23 08:32:43 2025
ap...@google.com <ap...@google.com> #16
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Minimize reproduction for
Expand for full commit details
Minimize reproduction for b/391417819
Bug: b/391417819
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433
Files:
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 9306278ddfbe67c7fe3a81446148a245db8a096b
Date: Thu Jan 23 08:32:49 2025
ap...@google.com <ap...@google.com> #17
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of issue 391417819
Bug: b/391417819
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0
Files:
- A
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 521167ce8ff95379eac380e69f0eb8f7ebd8bb1a
Date: Thu Jan 23 08:28:07 2025
ap...@google.com <ap...@google.com> #18
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Version 8.9.23
Expand for full commit details
Version 8.9.23
Bug: b/391417819
Change-Id: I6dc328cf7316214561496f03c24b233cc9cc2e8f
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: b8f27da10862efd537f7988c9f5f9d639baaf342
Date: Thu Jan 23 08:28:24 2025
ap...@google.com <ap...@google.com> #19
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Extend ArrayConstructionSimplifier dominance checks
Expand for full commit details
Extend ArrayConstructionSimplifier dominance checks
Fixes: b/391417819
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 4f64f9ef6cfad77ca541b339f4d2de3e3bbbb629
Date: Thu Jan 23 08:28:18 2025
ap...@google.com <ap...@google.com> #20
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Minimize reproduction for
Expand for full commit details
Minimize reproduction for b/391417819
Bug: b/391417819
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433
Files:
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: d4cc4e99e6075a7970e8caa7a2f3d939050053f5
Date: Thu Jan 23 08:28:13 2025
ap...@google.com <ap...@google.com> #21
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of issue 391417819
Bug: b/391417819
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0
Files:
- A
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 3353b45090549cf6d57d6cf0a65b8b5959a705b1
Date: Thu Jan 23 08:33:20 2025
ap...@google.com <ap...@google.com> #22
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Extend ArrayConstructionSimplifier dominance checks
Expand for full commit details
Extend ArrayConstructionSimplifier dominance checks
Fixes: b/391417819
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: c609582a812828005c7edf12d17f240c746b08c6
Date: Thu Jan 23 08:33:30 2025
ap...@google.com <ap...@google.com> #23
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Minimize reproduction for
Expand for full commit details
Minimize reproduction for b/391417819
Bug: b/391417819
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433
Files:
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 2d5ed830b7418a5647d0d46fd7491e8a6c9508c7
Date: Thu Jan 23 08:33:25 2025
ap...@google.com <ap...@google.com> #24
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Extend ArrayConstructionSimplifier dominance checks
Expand for full commit details
Extend ArrayConstructionSimplifier dominance checks
Fixes: b/391417819
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 8742667733c823ce28496032566dd67b61c77b93
Date: Thu Jan 23 08:32:53 2025
ap...@google.com <ap...@google.com> #25
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of issue 391417819
Bug: b/391417819
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0
Files:
- A
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: cf6351164bfa81c0825804a298a2002427703bb8
Date: Thu Jan 23 08:32:43 2025
ap...@google.com <ap...@google.com> #26
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Minimize reproduction for
Expand for full commit details
Minimize reproduction for b/391417819
Bug: b/391417819
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433
Files:
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 9306278ddfbe67c7fe3a81446148a245db8a096b
Date: Thu Jan 23 08:32:49 2025
ap...@google.com <ap...@google.com> #27
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Remove use of instruction pointers in ArrayConstructionSimplifier
Expand for full commit details
Remove use of instruction pointers in ArrayConstructionSimplifier
Bug: b/391417819
Change-Id: Ibac54efa132e841a66158f5b150686583b6ce263
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
Hash: 204fa090ccb00a76f35f6a2bce300fc202488f0b
Date: Thu Jan 23 12:17:26 2025
ap...@google.com <ap...@google.com> #28
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Version 8.7.30
Expand for full commit details
Version 8.7.30
Bug: b/391417819
Change-Id: I2a4fb56c095f6f6e38c83784f48b67aae1eea125
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: fa99a3957d69b100e0b171b27b7e561704767d0a
Date: Thu Jan 23 12:17:35 2025
ap...@google.com <ap...@google.com> #29
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Remove use of instruction pointers in ArrayConstructionSimplifier
Expand for full commit details
Remove use of instruction pointers in ArrayConstructionSimplifier
Bug: b/391417819
Change-Id: I3b2c63f92ab7c715c0ee34c47a11ea4a9a031cd6
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
Hash: be6d116a901e6de654b4ab8bf819090110cc435d
Date: Thu Jan 23 12:14:33 2025
ap...@google.com <ap...@google.com> #30
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Version 8.8.29
Expand for full commit details
Version 8.8.29
Bug: b/391417819
Change-Id: Idf84855740cd4d85578087e5af12e15f2d3c34b1
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: 2db4212c6c2bdce2c9d7de18c0bee2287676fad4
Date: Thu Jan 23 12:15:28 2025
ap...@google.com <ap...@google.com> #31
Project: r8
Branch: main
Author: Andrew Grieve <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: 6a196b767d07351dc7727d805df3de5f6e55bb95
Date: Tue Jan 28 09:45:13 2025
ap...@google.com <ap...@google.com> #32
Project: r8
Branch: 8.6
Author: Christoffer Adamsen <
Link:
Minimize reproduction for
Expand for full commit details
Minimize reproduction for b/391417819
Bug: b/391417819
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433
Files:
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 19c63ff0edfb19a43225f4e71a2040773ff61dde
Date: Thu Jan 23 08:34:02 2025
ap...@google.com <ap...@google.com> #33
Project: r8
Branch: 8.6
Author: Christoffer Adamsen <
Link:
Extend ArrayConstructionSimplifier dominance checks
Expand for full commit details
Extend ArrayConstructionSimplifier dominance checks
Fixes: b/391417819
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: ef2d79417694eb4d4015b88217079e7078608546
Date: Thu Jan 23 08:34:07 2025
ap...@google.com <ap...@google.com> #34
Project: r8
Branch: 8.6
Author: Christoffer Adamsen <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of issue 391417819
Bug: b/391417819
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0
Files:
- A
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 057e709d6d58cc612be0c1454528a64f4e520afb
Date: Thu Jan 23 08:33:57 2025
ap...@google.com <ap...@google.com> #35
Project: r8
Branch: 8.5
Author: Christoffer Adamsen <
Link:
Minimize reproduction for
Expand for full commit details
Minimize reproduction for b/391417819
Bug: b/391417819
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433
Files:
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: ddeceac56e5f69ba399d452143f7e0ad846e463a
Date: Thu Jan 23 08:35:14 2025
ap...@google.com <ap...@google.com> #36
Project: r8
Branch: 8.5
Author: Christoffer Adamsen <
Link:
Extend ArrayConstructionSimplifier dominance checks
Expand for full commit details
Extend ArrayConstructionSimplifier dominance checks
Fixes: b/391417819
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: ad1db321daef6d551838790b37ab31839b13d4a6
Date: Thu Jan 23 08:35:19 2025
ap...@google.com <ap...@google.com> #37
Project: r8
Branch: 8.5
Author: Christoffer Adamsen <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of issue 391417819
Bug: b/391417819
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0
Files:
- A
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 2d41ee40de5da2ea80734d60733b431b2082a4cc
Date: Thu Jan 23 08:35:09 2025
ap...@google.com <ap...@google.com> #38
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: a9d0cc5fb40101e32f13da8163d296d9151078cc
Date: Wed Feb 05 14:22:37 2025
ap...@google.com <ap...@google.com> #39
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Version 8.8.30
Expand for full commit details
Version 8.8.30
Bug: b/391417819
Change-Id: I966d3ceddba2f0ee0817f7551440745dec6590d2
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: c27beef20ae9bfd4c6a3a0aa5b6bca529459894d
Date: Wed Feb 05 14:22:47 2025
ap...@google.com <ap...@google.com> #40
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Version 8.7.31
Expand for full commit details
Version 8.7.31
Bug: b/391417819
Change-Id: I596f4c4d86000f39b5bd392c4ad82f290c26ba4c
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: c3b0d4ada556a59928e0c15c3382966bfab65bb5
Date: Wed Feb 05 14:25:48 2025
ap...@google.com <ap...@google.com> #41
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: e15d7557ead42a62f051a3d377dbf2c194080c1e
Date: Wed Feb 05 14:25:39 2025
ap...@google.com <ap...@google.com> #42
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Version 8.9.24
Expand for full commit details
Version 8.9.24
Bug: b/391417819
Change-Id: Ibef5197ce6514a49e36908efe5a363ced62a4707
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: cb856f7819c1c4d9f18c8cb5912cba0d133b923f
Date: Wed Feb 05 14:21:33 2025
ap...@google.com <ap...@google.com> #43
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: 0214496fecdceca1a0730153ece5d9f5f7f6ba0d
Date: Wed Feb 05 14:21:08 2025
ap...@google.com <ap...@google.com> #44
Project: r8
Branch: 8.5
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: 6463499b7bfc8b408daf1e403b8cfc707825d04f
Date: Wed Feb 05 14:28:58 2025
ap...@google.com <ap...@google.com> #45
Project: r8
Branch: 8.5
Author: Christoffer Adamsen <
Link:
Version 8.5.51
Expand for full commit details
Version 8.5.51
Bug: b/391417819
Change-Id: I0059527e0cea91383204efe6d1e656551fc423e2
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: 9aaf485a55ea66ce7a09748986b799272208af09
Date: Wed Feb 05 14:29:06 2025
ap...@google.com <ap...@google.com> #46
Project: r8
Branch: 8.6
Author: Christoffer Adamsen <
Link:
Version 8.6.40
Expand for full commit details
Version 8.6.40
Bug: b/391417819
Change-Id: Ia0da9c64c03523fd9f7a335c818acb074ee69e35
Files:
- M
src/main/java/com/android/tools/r8/Version.java
Hash: dce31b8fd345ee2720a300394764cea8d2a8cded
Date: Wed Feb 05 14:28:32 2025
ap...@google.com <ap...@google.com> #47
Project: r8
Branch: 8.6
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: a50126864f7ebb15091207741df2b229653b3804
Date: Wed Feb 05 14:28:22 2025
ap...@google.com <ap...@google.com> #48
Project: r8
Branch: 8.6
Author: Christoffer Adamsen <
Link:
Minimize reproduction for
Expand for full commit details
Minimize reproduction for b/391417819
Bug: b/391417819
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433
Files:
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 19c63ff0edfb19a43225f4e71a2040773ff61dde
Date: Thu Jan 23 08:34:02 2025
ap...@google.com <ap...@google.com> #49
Project: r8
Branch: 8.6
Author: Christoffer Adamsen <
Link:
Extend ArrayConstructionSimplifier dominance checks
Expand for full commit details
Extend ArrayConstructionSimplifier dominance checks
Fixes: b/391417819
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49
Files:
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: ef2d79417694eb4d4015b88217079e7078608546
Date: Thu Jan 23 08:34:07 2025
ap...@google.com <ap...@google.com> #50
Project: r8
Branch: 8.6
Author: Christoffer Adamsen <
Link:
Add reproduction of
Expand for full commit details
Add reproduction of issue 391417819
Bug: b/391417819
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0
Files:
- A
src/test/java/com/android/tools/r8/B391417819Repro.java
Hash: 057e709d6d58cc612be0c1454528a64f4e520afb
Date: Thu Jan 23 08:33:57 2025
ap...@google.com <ap...@google.com> #51
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: a9d0cc5fb40101e32f13da8163d296d9151078cc
Date: Wed Feb 05 14:22:37 2025
ap...@google.com <ap...@google.com> #52
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: e15d7557ead42a62f051a3d377dbf2c194080c1e
Date: Wed Feb 05 14:25:39 2025
ap...@google.com <ap...@google.com> #53
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: 0214496fecdceca1a0730153ece5d9f5f7f6ba0d
Date: Wed Feb 05 14:21:08 2025
ap...@google.com <ap...@google.com> #54
Project: r8
Branch: 8.5
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: 6463499b7bfc8b408daf1e403b8cfc707825d04f
Date: Wed Feb 05 14:28:58 2025
ap...@google.com <ap...@google.com> #55
Project: r8
Branch: 8.8
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: a9d0cc5fb40101e32f13da8163d296d9151078cc
Date: Wed Feb 05 14:22:37 2025
ap...@google.com <ap...@google.com> #56
Project: r8
Branch: 8.7
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: e15d7557ead42a62f051a3d377dbf2c194080c1e
Date: Wed Feb 05 14:25:39 2025
ap...@google.com <ap...@google.com> #57
Project: r8
Branch: 8.9
Author: Christoffer Adamsen <
Link:
Fix dominator check in ValueUtils.computeInitialArrayValues()
Expand for full commit details
Fix dominator check in ValueUtils.computeInitialArrayValues()
It was not correctly identifying linear edges.
Bug: 391417819
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e
Files:
- M
src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
- M
src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
- M
src/main/java/com/android/tools/r8/utils/DominatorChecker.java
- M
src/main/java/com/android/tools/r8/utils/ValueUtils.java
Hash: 0214496fecdceca1a0730153ece5d9f5f7f6ba0d
Date: Wed Feb 05 14:21:08 2025
an...@google.com <an...@google.com> #58
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Meerkat | 2024.3.1 RC 2
- Android Gradle Plugin 8.9.0-rc02
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
an...@google.com <an...@google.com> #59
The fixes for this issue are now also available in:
- Android Studio Ladybug Feature Drop | 2024.2.2 Patch 2
- Android Gradle Plugin 8.8.2
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Description
Hi there,
The issue continues to happen for us even with AGP 8.7.3. I am attaching the source code and smali output here.
java.lang.VerifyError: Verifier rejected class com.example.r8.R8Test: byte[] com.example.r8.R8Test.toBytes(boolean) failed to verify: byte[] com.example.r8.R8Test.toBytes(boolean): [0x28] unexpected value in v0 of type Undefined but expected Byte for put (declaration of 'com.example.r8.R8Test' appears in /data/app/~~xxxxx/base.apk)
We believe this should be a bug that only occurs in a specific scenario.
Source code as follows:
smail output as follws:
From the above smail output, it can be seen that the code byte[] bytes = new byte[3]; was optimized away, resulting in a verifyError.