java.lang.VerifyError: Verifier rejected class [391417819]

Fixed

Bug

Status Update

No update yet.

Description

li...@xiaomi.com

created issue #1

Jan 22, 2025 07:30AM

Hi there,

The issue continues to happen for us even with AGP 8.7.3. I am attaching the source code and smali output here.

java.lang.VerifyError: Verifier rejected class com.example.r8.R8Test: byte[] com.example.r8.R8Test.toBytes(boolean) failed to verify: byte[] com.example.r8.R8Test.toBytes(boolean): [0x28] unexpected value in v0 of type Undefined but expected Byte for put (declaration of 'com.example.r8.R8Test' appears in /data/app/~~xxxxx/base.apk)

We believe this should be a bug that only occurs in a specific scenario.

Source code as follows:

public class R8Test {

    public byte[] toBytes(boolean on) {
        byte[] bytes = new byte[3];
        bytes[0] = 1;
        BitSet bits = new BitSet(8);
        byte[] byteArray = bits.toByteArray();
        if (byteArray != null && byteArray.length >= 1) {
            bytes[1] = bits.toByteArray()[0];
        }
        BitSet bitSet = new BitSet(8);
        bytes[2] = bitSet.toByteArray()[0];
        return bytes;
    }
}

smail output as follws:

.method public toBytes(Z)[B
    .registers 6

    new-instance p0, Ljava/util/BitSet;

    const/16 p1, 0x8

    invoke-direct {p0, p1}, Ljava/util/BitSet;-><init>(I)V

    invoke-virtual {p0}, Ljava/util/BitSet;->toByteArray()[B

    move-result-object v1

    const/4 v2, 0x0

    const/4 v3, 0x1

    if-eqz v1, :cond_18

    array-length v1, v1

    if-lt v1, v3, :cond_18

    invoke-virtual {p0}, Ljava/util/BitSet;->toByteArray()[B

    move-result-object p0

    aget-byte v0, p0, v2

    :cond_18
    new-instance p0, Ljava/util/BitSet;

    invoke-direct {p0, p1}, Ljava/util/BitSet;-><init>(I)V

    invoke-virtual {p0}, Ljava/util/BitSet;->toByteArray()[B

    move-result-object p0

    aget-byte p0, p0, v2

    const/4 p1, 0x3

    new-array p1, p1, [B

    aput-byte v3, p1, v2

    aput-byte v0, p1, v3

    const/4 v0, 0x2

    aput-byte p0, p1, v0

    return-object p1
.end method

From the above smail output, it can be seen that the code byte[] bytes = new byte[3]; was optimized away, resulting in a verifyError.

source_smail.txt

1.6 KB

View

Download

Comments

ch...@google.com <ch...@google.com> Jan 22, 2025 08:35AM

Reassigned to ch...@google.com.

sg...@google.com <sg...@google.com> #2Jan 22, 2025 08:45AM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 3
Android Gradle Plugin 8.8.0-alpha03

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ap...@google.com <ap...@google.com> #3Jan 22, 2025 08:47AM

Project: r8
Branch: main
Author: Søren Gjesse <sgjesse@google.com>
Link: https://r8-review.googlesource.com/100168

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: bf9b1962052bf91689120a09deded518e37862a2
Date: Wed Jan 22 09:41:15 2025

hs...@siren.plus <hs...@siren.plus> #4Jan 22, 2025 09:03AM

Comment has been deleted.

Message last modified on Jan 22, 2025 09:04AM

li...@xiaomi.com <li...@xiaomi.com> #5Jan 22, 2025 09:05AM

I'm really sorry, please use the source code below:

public class R8Test {

    public byte[] toBytes(boolean on) {
        byte[] bytes = new byte[3];
        bytes[0] = 1;
        BitSet bits = new BitSet(8);
        byte[] byteArray = bits.toByteArray();
        if (byteArray != null && byteArray.length >= 1) {
            bytes[1] = bits.toByteArray()[0];
        }

        BitSet bitSet = new BitSet(8);
        byte[] byteArray2 = bits.toByteArray();
        if (byteArray2 != null && byteArray2.length >= 1) {
            bytes[2] = bitSet.toByteArray()[0];
        }
        return bytes;
    }
}

sg...@google.com <sg...@google.com> #6Jan 22, 2025 09:13AM

Thank you for the update. Most likely the initial source code will still be sufficient to fix the issue.

ap...@google.com <ap...@google.com> #7Jan 22, 2025 02:08PM

Project: r8
Branch: main
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100169

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 8f4ead7ecfe729c0811264de5545f9f104705d0d
Date: Wed Jan 22 12:39:38 2025

ap...@google.com <ap...@google.com> #8Jan 22, 2025 02:08PM

Marked as fixed.

Project: r8
Branch: main
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100170

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 99e24d1d45d9812d3b4d005690afdcedab1a15bd
Date: Wed Jan 22 13:06:35 2025

ap...@google.com <ap...@google.com> #9Jan 23, 2025 07:44AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100542

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 3353b45090549cf6d57d6cf0a65b8b5959a705b1
Date: Thu Jan 23 08:33:20 2025

ap...@google.com <ap...@google.com> #10Jan 23, 2025 07:44AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100543

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: c609582a812828005c7edf12d17f240c746b08c6
Date: Thu Jan 23 08:33:30 2025

ap...@google.com <ap...@google.com> #11Jan 23, 2025 07:44AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100544

Version 8.7.29

Expand for full commit details

Version 8.7.29 
 
Bug: b/391417819 
Change-Id: I6575d9bb6138a2703066d54d57e2c501a7c143ce

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: e98195210c16e6878b79635ceaec5d2594768414
Date: Thu Jan 23 08:33:36 2025

ap...@google.com <ap...@google.com> #12Jan 23, 2025 07:44AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100526

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 2d5ed830b7418a5647d0d46fd7491e8a6c9508c7
Date: Thu Jan 23 08:33:25 2025

ap...@google.com <ap...@google.com> #13Jan 23, 2025 07:44AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100525

Version 8.8.28

Expand for full commit details

Version 8.8.28 
 
Bug: b/391417819 
Change-Id: Ia53d504317c0f4128fbb1f256ab5660aaf30bcb9

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 46c042e66ab65f238d710fabb2635d80864b19f0
Date: Thu Jan 23 08:32:59 2025

ap...@google.com <ap...@google.com> #14Jan 23, 2025 07:44AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100541

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 8742667733c823ce28496032566dd67b61c77b93
Date: Thu Jan 23 08:32:53 2025

ap...@google.com <ap...@google.com> #15Jan 23, 2025 07:44AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100540

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: cf6351164bfa81c0825804a298a2002427703bb8
Date: Thu Jan 23 08:32:43 2025

ap...@google.com <ap...@google.com> #16Jan 23, 2025 07:44AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100524

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 9306278ddfbe67c7fe3a81446148a245db8a096b
Date: Thu Jan 23 08:32:49 2025

ap...@google.com <ap...@google.com> #17Jan 23, 2025 07:44AM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100520

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 521167ce8ff95379eac380e69f0eb8f7ebd8bb1a
Date: Thu Jan 23 08:28:07 2025

ap...@google.com <ap...@google.com> #18Jan 23, 2025 07:44AM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100523

Version 8.9.23

Expand for full commit details

Version 8.9.23 
 
Bug: b/391417819 
Change-Id: I6dc328cf7316214561496f03c24b233cc9cc2e8f

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: b8f27da10862efd537f7988c9f5f9d639baaf342
Date: Thu Jan 23 08:28:24 2025

ap...@google.com <ap...@google.com> #19Jan 23, 2025 07:44AM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100522

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 4f64f9ef6cfad77ca541b339f4d2de3e3bbbb629
Date: Thu Jan 23 08:28:18 2025

ap...@google.com <ap...@google.com> #20Jan 23, 2025 07:44AM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100521

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: d4cc4e99e6075a7970e8caa7a2f3d939050053f5
Date: Thu Jan 23 08:28:13 2025

ap...@google.com <ap...@google.com> #21Jan 23, 2025 07:46AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100542

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 3353b45090549cf6d57d6cf0a65b8b5959a705b1
Date: Thu Jan 23 08:33:20 2025

ap...@google.com <ap...@google.com> #22Jan 23, 2025 07:46AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100543

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: c609582a812828005c7edf12d17f240c746b08c6
Date: Thu Jan 23 08:33:30 2025

ap...@google.com <ap...@google.com> #23Jan 23, 2025 07:47AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100526

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 2d5ed830b7418a5647d0d46fd7491e8a6c9508c7
Date: Thu Jan 23 08:33:25 2025

ap...@google.com <ap...@google.com> #24Jan 23, 2025 07:47AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100541

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 8742667733c823ce28496032566dd67b61c77b93
Date: Thu Jan 23 08:32:53 2025

ap...@google.com <ap...@google.com> #25Jan 23, 2025 07:47AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100540

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: cf6351164bfa81c0825804a298a2002427703bb8
Date: Thu Jan 23 08:32:43 2025

ap...@google.com <ap...@google.com> #26Jan 23, 2025 07:47AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100524

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 9306278ddfbe67c7fe3a81446148a245db8a096b
Date: Thu Jan 23 08:32:49 2025

ap...@google.com <ap...@google.com> #27Jan 23, 2025 11:25AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100529

Remove use of instruction pointers in ArrayConstructionSimplifier

Expand for full commit details

Remove use of instruction pointers in ArrayConstructionSimplifier 
 
Bug: b/391417819 
Change-Id: Ibac54efa132e841a66158f5b150686583b6ce263

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java

Hash: 204fa090ccb00a76f35f6a2bce300fc202488f0b
Date: Thu Jan 23 12:17:26 2025

ap...@google.com <ap...@google.com> #28Jan 23, 2025 11:25AM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100562

Version 8.7.30

Expand for full commit details

Version 8.7.30 
 
Bug: b/391417819 
Change-Id: I2a4fb56c095f6f6e38c83784f48b67aae1eea125

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: fa99a3957d69b100e0b171b27b7e561704767d0a
Date: Thu Jan 23 12:17:35 2025

ap...@google.com <ap...@google.com> #29Jan 23, 2025 11:25AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100528

Remove use of instruction pointers in ArrayConstructionSimplifier

Expand for full commit details

Remove use of instruction pointers in ArrayConstructionSimplifier 
 
Bug: b/391417819 
Change-Id: I3b2c63f92ab7c715c0ee34c47a11ea4a9a031cd6

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java

Hash: be6d116a901e6de654b4ab8bf819090110cc435d
Date: Thu Jan 23 12:14:33 2025

ap...@google.com <ap...@google.com> #30Jan 23, 2025 11:25AM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100561

Version 8.8.29

Expand for full commit details

Version 8.8.29 
 
Bug: b/391417819 
Change-Id: Idf84855740cd4d85578087e5af12e15f2d3c34b1

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 2db4212c6c2bdce2c9d7de18c0bee2287676fad4
Date: Thu Jan 23 12:15:28 2025

ap...@google.com <ap...@google.com> #31Jan 28, 2025 07:27PM

Project: r8
Branch: main
Author: Andrew Grieve <agrieve@google.com>
Link: https://r8-review.googlesource.com/100660

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: 6a196b767d07351dc7727d805df3de5f6e55bb95
Date: Tue Jan 28 09:45:13 2025

ap...@google.com <ap...@google.com> #32Feb 5, 2025 01:30PM

Project: r8
Branch: 8.6
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100546

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 19c63ff0edfb19a43225f4e71a2040773ff61dde
Date: Thu Jan 23 08:34:02 2025

ap...@google.com <ap...@google.com> #33Feb 5, 2025 01:30PM

Project: r8
Branch: 8.6
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100547

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: ef2d79417694eb4d4015b88217079e7078608546
Date: Thu Jan 23 08:34:07 2025

ap...@google.com <ap...@google.com> #34Feb 5, 2025 01:30PM

Project: r8
Branch: 8.6
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100545

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 057e709d6d58cc612be0c1454528a64f4e520afb
Date: Thu Jan 23 08:33:57 2025

ap...@google.com <ap...@google.com> #35Feb 5, 2025 01:30PM

Project: r8
Branch: 8.5
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100550

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: ddeceac56e5f69ba399d452143f7e0ad846e463a
Date: Thu Jan 23 08:35:14 2025

ap...@google.com <ap...@google.com> #36Feb 5, 2025 01:30PM

Project: r8
Branch: 8.5
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100527

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: ad1db321daef6d551838790b37ab31839b13d4a6
Date: Thu Jan 23 08:35:19 2025

ap...@google.com <ap...@google.com> #37Feb 5, 2025 01:30PM

Project: r8
Branch: 8.5
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100549

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 2d41ee40de5da2ea80734d60733b431b2082a4cc
Date: Thu Jan 23 08:35:09 2025

ap...@google.com <ap...@google.com> #38Feb 5, 2025 01:32PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101142

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: a9d0cc5fb40101e32f13da8163d296d9151078cc
Date: Wed Feb 05 14:22:37 2025

ap...@google.com <ap...@google.com> #39Feb 5, 2025 01:32PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101161

Version 8.8.30

Expand for full commit details

Version 8.8.30 
 
Bug: b/391417819 
Change-Id: I966d3ceddba2f0ee0817f7551440745dec6590d2

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: c27beef20ae9bfd4c6a3a0aa5b6bca529459894d
Date: Wed Feb 05 14:22:47 2025

ap...@google.com <ap...@google.com> #40Feb 5, 2025 01:32PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101144

Version 8.7.31

Expand for full commit details

Version 8.7.31 
 
Bug: b/391417819 
Change-Id: I596f4c4d86000f39b5bd392c4ad82f290c26ba4c

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: c3b0d4ada556a59928e0c15c3382966bfab65bb5
Date: Wed Feb 05 14:25:48 2025

ap...@google.com <ap...@google.com> #41Feb 5, 2025 01:32PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101143

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: e15d7557ead42a62f051a3d377dbf2c194080c1e
Date: Wed Feb 05 14:25:39 2025

ap...@google.com <ap...@google.com> #42Feb 5, 2025 01:32PM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101141

Version 8.9.24

Expand for full commit details

Version 8.9.24 
 
Bug: b/391417819 
Change-Id: Ibef5197ce6514a49e36908efe5a363ced62a4707

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: cb856f7819c1c4d9f18c8cb5912cba0d133b923f
Date: Wed Feb 05 14:21:33 2025

ap...@google.com <ap...@google.com> #43Feb 5, 2025 01:32PM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101160

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: 0214496fecdceca1a0730153ece5d9f5f7f6ba0d
Date: Wed Feb 05 14:21:08 2025

ap...@google.com <ap...@google.com> #44Feb 5, 2025 01:32PM

Project: r8
Branch: 8.5
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101163

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: 6463499b7bfc8b408daf1e403b8cfc707825d04f
Date: Wed Feb 05 14:28:58 2025

ap...@google.com <ap...@google.com> #45Feb 5, 2025 01:32PM

Project: r8
Branch: 8.5
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101146

Version 8.5.51

Expand for full commit details

Version 8.5.51 
 
Bug: b/391417819 
Change-Id: I0059527e0cea91383204efe6d1e656551fc423e2

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 9aaf485a55ea66ce7a09748986b799272208af09
Date: Wed Feb 05 14:29:06 2025

ap...@google.com <ap...@google.com> #46Feb 5, 2025 01:32PM

Project: r8
Branch: 8.6
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101162

Version 8.6.40

Expand for full commit details

Version 8.6.40 
 
Bug: b/391417819 
Change-Id: Ia0da9c64c03523fd9f7a335c818acb074ee69e35

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: dce31b8fd345ee2720a300394764cea8d2a8cded
Date: Wed Feb 05 14:28:32 2025

ap...@google.com <ap...@google.com> #47Feb 5, 2025 01:32PM

Project: r8
Branch: 8.6
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101145

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: a50126864f7ebb15091207741df2b229653b3804
Date: Wed Feb 05 14:28:22 2025

ap...@google.com <ap...@google.com> #48Feb 5, 2025 01:32PM

Project: r8
Branch: 8.6
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100546

Minimize reproduction for b/391417819

Expand for full commit details

Minimize reproduction for b/391417819 
 
Bug: b/391417819 
Change-Id: I65a9c2427b41f2075305c1383f9dd44c0f580433

Files:

M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 19c63ff0edfb19a43225f4e71a2040773ff61dde
Date: Thu Jan 23 08:34:02 2025

ap...@google.com <ap...@google.com> #49Feb 5, 2025 01:32PM

Project: r8
Branch: 8.6
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100547

Extend ArrayConstructionSimplifier dominance checks

Expand for full commit details

Extend ArrayConstructionSimplifier dominance checks 
 
Fixes: b/391417819 
Change-Id: Id31f2463d9255415d33ce43bcafd9e794c550a49

Files:

M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: ef2d79417694eb4d4015b88217079e7078608546
Date: Thu Jan 23 08:34:07 2025

ap...@google.com <ap...@google.com> #50Feb 5, 2025 01:32PM

Project: r8
Branch: 8.6
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/100545

Add reproduction of issue 391417819

Expand for full commit details

Add reproduction of issue 391417819 
 
Bug: b/391417819 
Change-Id: I37eb909c100104fadeb895bf5d930f4f54e94ba0

Files:

A src/test/java/com/android/tools/r8/B391417819Repro.java

Hash: 057e709d6d58cc612be0c1454528a64f4e520afb
Date: Thu Jan 23 08:33:57 2025

ap...@google.com <ap...@google.com> #51Feb 5, 2025 01:34PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101142

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: a9d0cc5fb40101e32f13da8163d296d9151078cc
Date: Wed Feb 05 14:22:37 2025

ap...@google.com <ap...@google.com> #52Feb 5, 2025 01:34PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101143

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: e15d7557ead42a62f051a3d377dbf2c194080c1e
Date: Wed Feb 05 14:25:39 2025

ap...@google.com <ap...@google.com> #53Feb 5, 2025 01:34PM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101160

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: 0214496fecdceca1a0730153ece5d9f5f7f6ba0d
Date: Wed Feb 05 14:21:08 2025

ap...@google.com <ap...@google.com> #54Feb 5, 2025 01:34PM

Project: r8
Branch: 8.5
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101163

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: 6463499b7bfc8b408daf1e403b8cfc707825d04f
Date: Wed Feb 05 14:28:58 2025

ap...@google.com <ap...@google.com> #55Feb 5, 2025 01:36PM

Project: r8
Branch: 8.8
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101142

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: a9d0cc5fb40101e32f13da8163d296d9151078cc
Date: Wed Feb 05 14:22:37 2025

ap...@google.com <ap...@google.com> #56Feb 5, 2025 01:36PM

Project: r8
Branch: 8.7
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101143

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: e15d7557ead42a62f051a3d377dbf2c194080c1e
Date: Wed Feb 05 14:25:39 2025

ap...@google.com <ap...@google.com> #57Feb 5, 2025 01:36PM

Project: r8
Branch: 8.9
Author: Christoffer Adamsen <christofferqa@google.com>
Link: https://r8-review.googlesource.com/101160

Fix dominator check in ValueUtils.computeInitialArrayValues()

Expand for full commit details

Fix dominator check in ValueUtils.computeInitialArrayValues() 
 
It was not correctly identifying linear edges. 
 
Bug: 391417819 
Change-Id: Ibfea470210b2af338129c306f349e87a0e47af6e

Files:

M src/main/java/com/android/tools/r8/ir/code/BasicBlock.java
M src/main/java/com/android/tools/r8/ir/conversion/passes/ArrayConstructionSimplifier.java
M src/main/java/com/android/tools/r8/utils/DominatorChecker.java
M src/main/java/com/android/tools/r8/utils/ValueUtils.java

Hash: 0214496fecdceca1a0730153ece5d9f5f7f6ba0d
Date: Wed Feb 05 14:21:08 2025

an...@google.com <an...@google.com> #58Feb 18, 2025 01:59PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat | 2024.3.1 RC 2
Android Gradle Plugin 8.9.0-rc02

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

an...@google.com <an...@google.com> #59Feb 26, 2025 05:51PM

The fixes for this issue are now also available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Patch 2
Android Gradle Plugin 8.8.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Issue 391417819

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> Jan 22, 2025 08:35AM

sg...@google.com <sg...@google.com> #2Jan 22, 2025 08:45AM

ap...@google.com <ap...@google.com> #3Jan 22, 2025 08:47AM

hs...@siren.plus <hs...@siren.plus> #4Jan 22, 2025 09:03AM

li...@xiaomi.com <li...@xiaomi.com> #5Jan 22, 2025 09:05AM

sg...@google.com <sg...@google.com> #6Jan 22, 2025 09:13AM

ap...@google.com <ap...@google.com> #7Jan 22, 2025 02:08PM

ap...@google.com <ap...@google.com> #8Jan 22, 2025 02:08PM

ap...@google.com <ap...@google.com> #9Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #10Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #11Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #12Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #13Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #14Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #15Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #16Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #17Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #18Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #19Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #20Jan 23, 2025 07:44AM

ap...@google.com <ap...@google.com> #21Jan 23, 2025 07:46AM

ap...@google.com <ap...@google.com> #22Jan 23, 2025 07:46AM

ap...@google.com <ap...@google.com> #23Jan 23, 2025 07:47AM

ap...@google.com <ap...@google.com> #24Jan 23, 2025 07:47AM

ap...@google.com <ap...@google.com> #25Jan 23, 2025 07:47AM

ap...@google.com <ap...@google.com> #26Jan 23, 2025 07:47AM

ap...@google.com <ap...@google.com> #27Jan 23, 2025 11:25AM

ap...@google.com <ap...@google.com> #28Jan 23, 2025 11:25AM

ap...@google.com <ap...@google.com> #29Jan 23, 2025 11:25AM

ap...@google.com <ap...@google.com> #30Jan 23, 2025 11:25AM

ap...@google.com <ap...@google.com> #31Jan 28, 2025 07:27PM

ap...@google.com <ap...@google.com> #32Feb 5, 2025 01:30PM

ap...@google.com <ap...@google.com> #33Feb 5, 2025 01:30PM

ap...@google.com <ap...@google.com> #34Feb 5, 2025 01:30PM

ap...@google.com <ap...@google.com> #35Feb 5, 2025 01:30PM

ap...@google.com <ap...@google.com> #36Feb 5, 2025 01:30PM

ap...@google.com <ap...@google.com> #37Feb 5, 2025 01:30PM

ap...@google.com <ap...@google.com> #38Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #39Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #40Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #41Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #42Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #43Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #44Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #45Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #46Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #47Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #48Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #49Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #50Feb 5, 2025 01:32PM

ap...@google.com <ap...@google.com> #51Feb 5, 2025 01:34PM

ap...@google.com <ap...@google.com> #52Feb 5, 2025 01:34PM

ap...@google.com <ap...@google.com> #53Feb 5, 2025 01:34PM

ap...@google.com <ap...@google.com> #54Feb 5, 2025 01:34PM

ap...@google.com <ap...@google.com> #55Feb 5, 2025 01:36PM

ap...@google.com <ap...@google.com> #56Feb 5, 2025 01:36PM

ap...@google.com <ap...@google.com> #57Feb 5, 2025 01:36PM

an...@google.com <an...@google.com> #58Feb 18, 2025 01:59PM

an...@google.com <an...@google.com> #59Feb 26, 2025 05:51PM

Add comment

Issue metadata