Conflict between ComposeTestRule.enableAccessibilityChecks() and setting a ComposeTestRule.accessibilityValidator [391560768]

Fixed

Feature Request

Status Update

No update yet.

Description

ja...@google.com

created issue #1

Jan 22, 2025 01:14PM

Jetpack Compose version: 1.8.0-alpha08

Jetpack Compose component(s) used: ui-test

Just looking at the API, I would enable a11y checks as follows:

    composeTestRule.enableAccessibilityChecks()
    composeTestRule.accessibilityValidator = AccessibilityValidator()

However this is not how the API was designed to be used because enableAccessibilityChecks creates a new AccessibilityValidator

ui-test-android-1.8.0-alpha08.../androidMain/androidx/compose/ui/test/ComposeUiTest.android.kt

        @RequiresApi(34)
        override fun enableAccessibilityChecks() {
            accessibilityValidator = AccessibilityValidator().setRunChecksFromRootView(true)
        }

Actually, this code:

        composeTestRule.accessibilityValidator = AccessibilityValidator().apply {
          // config
        }

        composeTestRule.enableAccessibilityChecks()

would not work as expected either, as the validator would be replaced when the checks are enabled.

The correct snippet would be

composeTestRule.enableAccessibilityChecks()
composeTestRule.accessibilityValidator!!.apply { ... }

We can definitely document this well, but I'd like to discuss if the API should be improved.

For example enableAccessibilityChecks() -> enableAccessibilityChecks(accessibilityValidator: AccessibilityValidator = accessibilityValidator())

and make the setter for accessibilityValidator private.

Comments

ti...@google.com <ti...@google.com> Jan 24, 2025 11:03PM

Assigned to je...@google.com.

je...@google.com <je...@google.com> #2Feb 3, 2025 05:47PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

cl...@google.com <cl...@google.com> #3Feb 4, 2025 12:57PM

Added to our backlog

ap...@google.com <ap...@google.com> #4Feb 6, 2025 06:05PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Anastasia Soboleva <soboleva@google.com>
Link: https://android-review.googlesource.com/3473853

Add ui-test-accessibility and ui-test-junit4-accessibility library

Expand for full commit details

Add ui-test-accessibility and ui-test-junit4-accessibility library 
 
This allows us to remove the hard dependency on ATF inside ui-test and ui-test-junit. 
Methods like enableAccessibilityChecks() and disableAccessibilityChecks() on ComposeUITest and ComposeTestRule moved to those packages correspondingly. 
It also addresses the API usage feedback and adds accessibilityValidator as a parameter to the enableAccessibilityChecks which allows to easily configure and pass your own ATF validator. 
 
Given that Android is the only platform right now supporting these checks, we made this API Android-only. Inside ui-test everything is ready to work on various platforms. If we decide to move the enableChecks APIs in these packages to KMP, we'll likely deprecate hidden the existing and add the new one, perhaps tweaking the jvm name if needed. 
 
The integration point between the ui-test and ui-test-accessibility is a ComposeAccessibilityValidator that is made RestrictTo to avoid exposing API added in such short notice. In the future we can consider making it public. 
 
Most of the tests, samples and documentation are moved as is adjusting for a slightly changed API. 
 
Test: AccessibilityChecksTest 
Test: verified running checks in a separate (foundation) module 
Fixes: 391948233 
Fixes: 391560768 
Relnote: "Moved `enableAccessibilityChecks()` API that turns on the Accessibility Checks for Android to separate packages which are `compose:ui:ui-test-accessibility` if you're not using the TestRule and `compose:ui:ui-test-junit4-accessibility` when calling on TestRule" 
 
Change-Id: I3c3183c7f06ced8c0ad4873b6262ea39e1ea1b16

Files:

A compose/ui/ui-test-accessibility/OWNERS
A compose/ui/ui-test-accessibility/api/current.txt
A compose/ui/ui-test-accessibility/api/res-current.txt
A compose/ui/ui-test-accessibility/api/restricted_current.txt
A compose/ui/ui-test-accessibility/build.gradle
A compose/ui/ui-test-accessibility/samples/build.gradle
A compose/ui/ui-test-accessibility/samples/src/main/java/androidx/compose/ui/test/accessibility/samples/AccessibilityChecksSamples.kt
A compose/ui/ui-test-accessibility/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/accessibility/AccessibilityChecksTest.kt
A compose/ui/ui-test-accessibility/src/androidMain/kotlin/androidx/compose/ui/test/accessibility/ComposeUiTestExt.android.kt
A compose/ui/ui-test-junit4-accessibility/OWNERS
A compose/ui/ui-test-junit4-accessibility/api/current.txt
A compose/ui/ui-test-junit4-accessibility/api/res-current.txt
A compose/ui/ui-test-junit4-accessibility/api/restricted_current.txt
A compose/ui/ui-test-junit4-accessibility/build.gradle
A compose/ui/ui-test-junit4-accessibility/samples/build.gradle
A compose/ui/ui-test-junit4-accessibility/samples/src/main/java/androidx/compose/ui/test/junit4/accessibility/samples/AccessibilityChecksSamples.kt
A compose/ui/ui-test-junit4-accessibility/src/androidMain/kotlin/androidx/compose/ui/test/junit4/accessibility/AndroidComposeTestRuleExt.android.kt
A compose/ui/ui-test-junit4-accessibility/src/androidMain/kotlin/androidx/compose/ui/test/junit4/accessibility/ComposeTestRuleExt.android.kt
A compose/ui/ui-test-junit4/api/current.ignore
M compose/ui/ui-test-junit4/api/current.txt
A compose/ui/ui-test-junit4/api/restricted_current.ignore
M compose/ui/ui-test-junit4/api/restricted_current.txt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.android.kt
M compose/ui/ui-test-junit4/src/jvmMain/kotlin/androidx/compose/ui/test/junit4/ComposeTestRule.jvm.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/build.gradle
D compose/ui/ui-test/samples/src/main/java/androidx/compose/ui/test/samples/AccessibilityChecksSamples.kt
M compose/ui/ui-test/src/androidInstrumentedTest/kotlin/androidx/compose/ui/test/AccessibilityChecksTest.kt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/Actions.android.kt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/ComposeUiTest.android.kt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/TestContext.android.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/ComposeUiTest.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/TestContext.kt
M compose/ui/ui-test/src/commonStubsMain/kotlin/androidx/compose/ui/test/ComposeUiTest.commonStubs.kt
M docs-tip-of-tree/build.gradle
M settings.gradle

Hash: 36363496f5ff64683296c74b62b744da7f5a0a4c
Date: Mon Jan 27 09:02:33 2025

Issue 391560768

Description

Issue summary

Comments

ti...@google.com <ti...@google.com> Jan 24, 2025 11:03PM

je...@google.com <je...@google.com> #2Feb 3, 2025 05:47PM

cl...@google.com <cl...@google.com> #3Feb 4, 2025 12:57PM

ap...@google.com <ap...@google.com> #4Feb 6, 2025 06:05PM

Add comment

Issue metadata