Fixed
Status Update
Comments
ti...@google.com <ti...@google.com>
je...@google.com <je...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
cl...@google.com <cl...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
Description
Jetpack Compose version: 1.8.0-alpha08
Jetpack Compose component(s) used: ui-test
Just looking at the API, I would enable a11y checks as follows:
However this is not how the API was designed to be used because
enableAccessibilityChecks
creates a newAccessibilityValidator
ui-test-android-1.8.0-alpha08.../androidMain/androidx/compose/ui/test/ComposeUiTest.android.kt
Actually, this code:
would not work as expected either, as the validator would be replaced when the checks are enabled.
The correct snippet would be
We can definitely document this well, but I'd like to discuss if the API should be improved.
For example
enableAccessibilityChecks()
->enableAccessibilityChecks(accessibilityValidator: AccessibilityValidator = accessibilityValidator())
and make the setter for
accessibilityValidator
private.