Fixed
Status Update
Comments
ti...@google.com <ti...@google.com>
je...@google.com <je...@google.com> #2
Thanks for your feedback! Initially, the intention was to limit the date range picker to ranges of dates without the option to select the same date for start and end. However, your feedback have triggered a few additional discussions and we will make the change to allow that.
cl...@google.com <cl...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 3aef71f0bb035d22907c9eb1011803515271822e
Author: Shalom Gibly <sgibly@google.com>
Date: Tue Mar 14 12:29:28 2023
DateRangePicker - allow same day range selection
Updates to the DateRangePicker to allow slecting the same date as a
start and end.
Bug: 272882497
Test: DateRangePickerTest
Relnote: "Updated the DateRangePicker to allow selecting a range with
the same date for its start and end."
Change-Id: I16529402422cca8b5a370483fa14e4f429548e7c
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/DateRangePickerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DatePicker.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DateRangePicker.kt
https://android-review.googlesource.com/2487965
Branch: androidx-main
commit 3aef71f0bb035d22907c9eb1011803515271822e
Author: Shalom Gibly <sgibly@google.com>
Date: Tue Mar 14 12:29:28 2023
DateRangePicker - allow same day range selection
Updates to the DateRangePicker to allow slecting the same date as a
start and end.
Bug: 272882497
Test: DateRangePickerTest
Relnote: "Updated the DateRangePicker to allow selecting a range with
the same date for its start and end."
Change-Id: I16529402422cca8b5a370483fa14e4f429548e7c
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/DateRangePickerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DatePicker.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DateRangePicker.kt
ap...@google.com <ap...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.1.0-beta01
Description
Jetpack Compose version: 1.8.0-alpha08
Jetpack Compose component(s) used: ui-test
Just looking at the API, I would enable a11y checks as follows:
However this is not how the API was designed to be used because
enableAccessibilityChecks
creates a newAccessibilityValidator
ui-test-android-1.8.0-alpha08.../androidMain/androidx/compose/ui/test/ComposeUiTest.android.kt
Actually, this code:
would not work as expected either, as the validator would be replaced when the checks are enabled.
The correct snippet would be
We can definitely document this well, but I'd like to discuss if the API should be improved.
For example
enableAccessibilityChecks()
->enableAccessibilityChecks(accessibilityValidator: AccessibilityValidator = accessibilityValidator())
and make the setter for
accessibilityValidator
private.