IssueTracker

Source: https://github.com/GoogleCloudPlatform/appengine-java-standard/blob/aecf48dde8ca581b0387a5a4e231980d4961cc04/remoteapi/src/main/java/com/google/appengine/tools/remoteapi/RemoteApiInstaller.java#L123-L152

Problem you have encountered: When initializing the RemoteAPI across all threads, there is no mechanism to retry if the login fails. In the code below, the variable installedForAllThreads is a private static boolean that is set to true before calling the login() method. If login() fails, the RemoteAPI is not actually installed, yet installedForAllThreads remains true.

public void installOnAllThreads(RemoteApiOptions options) throws IOException { final RemoteApiOptions finalOptions = options.copy(); validateOptions(finalOptions);

// Synchronize on the class because we're manipulating global state (ApiProxy.Delegate).
synchronized (getClass()) {
  if (installed()) {
    throw new IllegalStateException("remote API is already installed");
  }
  installedForAllThreads = true;

  final RemoteApiClient client = login(finalOptions);
  @SuppressWarnings("unchecked")
  Delegate<Environment> originalDelegate = ApiProxy.getDelegate();

  RemoteApiDelegate globalRemoteApiDelegate =
      createDelegate(finalOptions, client, originalDelegate);
  ApiProxy.setDelegate(globalRemoteApiDelegate);

  // Single-thread install has the ability to leave the existing environment
  // in place and simply override the app id. That functionality is not
  // supported here.
  ApiProxy.setEnvironmentFactory(new EnvironmentFactory() {
    @Override
    public Environment newEnvironment() {
      return createEnv(finalOptions, client);
    }
  });
}

}

What you expected to happen: If login() fails, installedForAllThreads should be false.

Steps to reproduce:

Other information (workarounds you have tried, documentation consulted, etc):