Screenshot testing does not work with Wear Compose Material3 Dialogs [393517595]

Assigned

Bug

Status Update

No update yet.

Description

st...@google.com

created issue #1

Jan 31, 2025 10:26AM

This applies to AlertDialog, ConfirmationDialog or OpenOnPhoneDialog.

Workaround is to screenshot against the content composable, such as AlertDialogContent, but ideally apps would be able to take a screenshot test having made the AlertDialog itself visible.

Comments

pa...@google.com <pa...@google.com> #2Jan 31, 2025 06:37PM

Comment has been deleted.

Message last modified on Feb 6, 2025 10:03PM

st...@google.com <st...@google.com> #3Feb 3, 2025 11:03AM

Please could you explain why Alert was a workaround (https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material/src/main/java/androidx/wear/compose/material/dialog/Dialog.kt;l=90) but AlertDialogContent is not (https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:wear/compose/compose-material3/src/main/java/androidx/wear/compose/material3/AlertDialog.kt;l=290), because both display content without the Dialog wrapper.

pa...@google.com <pa...@google.com> #4Feb 3, 2025 06:36PM

Alert is a completely different component, we are trying to ideally use AlertDialog in our app, so rendering Alert instead is not a work around. AlertDialog at least uses AlertDialogContent, but Alert is completely separate

Message last modified on Feb 3, 2025 06:36PM

pa...@google.com <pa...@google.com> #5Feb 3, 2025 07:05PM

Also if I wrap Alert in a Dialog, the scuba test fails to work, I get a blank screen as well.

pa...@google.com <pa...@google.com> #6Feb 5, 2025 11:06PM

We are migrating all our existing single screen "dialogs" to use Dialogs so this issue will increasingly affect screenshot testing across our app. It's not reasonable to create versions without the Dialog wrapper for every single dialog implementation in our app.

pa...@google.com <pa...@google.com> #7Feb 6, 2025 10:03PM

Narrowed down the issue to androidx.compose.ui.window.Dialog. I believe, something to do with the LaunchedEffect responsible for displaying it. The function dialog.show() also mentions it displays the dialog in the application layer, so perhaps scuba tests do not pick up this layer?

ys...@google.com <ys...@google.com> #8Feb 7, 2025 10:06AM

FWIW it's definitely possible to use screenshot testing with Dialog support. Roborazzi supports this with robolectric.

https://github.com/takahirom/roborazzi/pull/225

https://github.com/takahirom/roborazzi/pull/555

st...@google.com <st...@google.com> #9Mar 4, 2025 11:14AM

Assigned to ti...@google.com.

We think this will now be possible, with AppScaffold around the AlertDialog.