Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Chris Craik <
Link:
Inject a synthetic runWithMeasurementDisabled trace into method traces
Expand for full commit details
Inject a synthetic runWithMeasurementDisabled trace into method traces
Bug: 393640753
Test: TrivialKotlinBenchmark (with runWithMeasurementDisabled added)
Change-Id: I49d975e1d4f959447ce6899c1a8a8eae35704e7f
Files:
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/ArtTrace.kt
Hash: 4171615904f48d815d9141325d4a15f81b620f2d
Date: Fri Jan 31 14:49:32 2025
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
Author: Chris Craik <
Link:
Move traceprocessor impl to benchmark-common
Expand for full commit details
Move traceprocessor impl to benchmark-common
Bug: 393640753
Test: Presubmit
Relnote: "Moved TraceProcessor.runSession extention APIs to be experimental, as they are likely to move to be non-extensions eventually on Android."
The APIs were previously minAPI 23, but moved to a minAPI 21 library,
so now are explicitly labelled. Since Androidx will go minAPI 23 in
the not too distant future, didn't bother moving to and testing on API
21.
Change-Id: Ib05284ba1b7250386a1993ae2e7a122b2b9c28d6
Files:
- M
benchmark/benchmark-common/api/current.txt
- M
benchmark/benchmark-common/api/restricted_current.txt
- M
benchmark/benchmark-common/build.gradle
- M
benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/traceprocessor/RowTest.kt
- M
benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/traceprocessor/SliceTest.kt
- M
benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/traceprocessor/TraceProcessorTest.kt
- M
benchmark/benchmark-common/src/main/AndroidManifest.xml
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/traceprocessor/TraceProcessorExtensions.kt
- M
benchmark/benchmark-common/src/main/res/xml/network_security_config.xml
- M
benchmark/benchmark-macro/api/current.txt
- M
benchmark/benchmark-macro/api/restricted_current.txt
- M
benchmark/benchmark-macro/build.gradle
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/ArtMetricTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PerfettoTraceRuleTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/PowerMetricTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupInsightsTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/StartupTimingMetricTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceMetricTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/AndroidxTracingTraceTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/BatteryDischargeQueryTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/FrameTimingQueryTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/MemoryCountersQueryTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/MemoryUsageQueryTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoCaptureSweepTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoSdkTraceTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PowerQueryTest.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/StartupTimingQueryTest.kt
- M
benchmark/benchmark-macro/src/main/AndroidManifest.xml
- M
benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Macrobenchmark.kt
- M
benchmark/integration-tests/macrobenchmark/src/main/java/androidx/benchmark/integration/macrobenchmark/TraceProcessorBenchmark.kt
Hash: 602aeec29d1cb9c243f847d627cb7d913fd8de89
Date: Fri Jan 31 16:36:32 2025
ap...@google.com <ap...@google.com> #4
Project: platform/prebuilts/androidx/traceprocessor
Branch: androidx-main
Author: Chris Craik <
Link:
Add test traces for method trace metrics
Expand for full commit details
Add test traces for method trace metrics
Test: MethodTracingTest
Bug: 393640753
Change-Id: I11b0d1973275c0d391a5e0269b3c603d28868c7b
Files:
- A
testdata/api35_runWithMeasurementDisabled-methodTracing.trace
- A
testdata/api35_runWithMeasurementDisabled.perfetto-trace
Hash: 30ca4d3845714e915a72dcd79304a2229dbc02cd
Date: Thu Feb 06 13:55:15 2025
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
Author: Chris Craik <
Link:
Add methodCount metric based on method trace
Expand for full commit details
Add methodCount metric based on method trace
Relnote: "Microbenchmark: Added `methodCount` metric based on method trace. When method traces are captured, count the number of methods executed by a microbenchmark, not counting code executed during runWithMeasurementDisabled"
Test: MethodTracingTest
Fixes: 393640753
Also improves MetricResult comparison strictness to make testing
metrics more robust, updated associated test.
Change-Id: I11b0d1973275c0d391a5e0269b3c603d28868c7b
Files:
- A
benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/MethodTracingTest.kt
- M
benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/MicrobenchmarkPhaseConfigTest.kt
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/MetricResult.kt
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/Microbenchmark.kt
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/ArtTrace.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MetricResultExtensionsTest.kt
Hash: dcbaad7871605c71a2011dc5ac2768e24d715c5e
Date: Fri Jan 31 16:06:06 2025
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
Author: Chris Craik <
Link:
Revert "Add methodCount metric based on method trace"
Expand for full commit details
Revert "Add methodCount metric based on method trace"
Fixes: 395666872
Bug: 393640753
This reverts commit dcbaad7871605c71a2011dc5ac2768e24d715c5e.
Reason for revert: Causing perfetto query timeouts in CI
Change-Id: I2d64439c6a6935d5aa0b60c33b8154b5b4e48803
Files:
- D
benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/MethodTracingTest.kt
- M
benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/MicrobenchmarkPhaseConfigTest.kt
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/MetricResult.kt
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/Microbenchmark.kt
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
- M
benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/ArtTrace.kt
- M
benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MetricResultExtensionsTest.kt
Hash: 34d9e5afb9c7f670802611c5cca8d5591a0bbc93
Date: Mon Feb 10 11:51:29 2025
Description
Inspired by b/393181737 and https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3472391 , want to see if we can make method traces as nonintrusive and toolable as possible