Method counting metric, based on method tracing [393640753]

Assigned

Feature Request

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Jan 31, 2025 10:51PM

Inspired by b/393181737 and https://android-review.git.corp.google.com/c/platform/frameworks/support/+/3472391, want to see if we can make method traces as nonintrusive and toolable as possible

Comments

ap...@google.com <ap...@google.com> #2Feb 3, 2025 07:44PM

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

ap...@google.com <ap...@google.com> #3Feb 5, 2025 08:23PM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

ap...@google.com <ap...@google.com> #4Feb 7, 2025 12:00AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

ap...@google.com <ap...@google.com> #5Feb 7, 2025 12:00AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Chris Craik <ccraik@google.com>
Link: https://android-review.googlesource.com/3475296

Add methodCount metric based on method trace

Expand for full commit details

Add methodCount metric based on method trace 
 
Relnote: "Microbenchmark: Added `methodCount` metric based on method trace. When method traces are captured, count the number of methods executed by a microbenchmark, not counting code executed during runWithMeasurementDisabled" 
Test: MethodTracingTest 
Fixes: 393640753 
 
Also improves MetricResult comparison strictness to make testing 
metrics more robust, updated associated test. 
 
Change-Id: I11b0d1973275c0d391a5e0269b3c603d28868c7b

Files:

A benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/MethodTracingTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/MicrobenchmarkPhaseConfigTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/MetricResult.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Microbenchmark.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/ArtTrace.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MetricResultExtensionsTest.kt

Hash: dcbaad7871605c71a2011dc5ac2768e24d715c5e
Date: Fri Jan 31 16:06:06 2025

ap...@google.com <ap...@google.com> #6Feb 10, 2025 08:31PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Chris Craik <ccraik@google.com>
Link: https://android-review.googlesource.com/3487572

Revert "Add methodCount metric based on method trace"

Expand for full commit details

Revert "Add methodCount metric based on method trace" 
 
Fixes: 395666872 
Bug: 393640753 
 
This reverts commit dcbaad7871605c71a2011dc5ac2768e24d715c5e. 
 
Reason for revert: Causing perfetto query timeouts in CI 
 
Change-Id: I2d64439c6a6935d5aa0b60c33b8154b5b4e48803

Files:

D benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/MethodTracingTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/MicrobenchmarkPhaseConfigTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/MetricResult.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Microbenchmark.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/ArtTrace.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MetricResultExtensionsTest.kt

Hash: 34d9e5afb9c7f670802611c5cca8d5591a0bbc93
Date: Mon Feb 10 11:51:29 2025

cc...@google.com <cc...@google.com> Feb 10, 2025 08:40PM

Status: Assigned (reopened)

Issue 393640753