Status Update
Comments
pa...@google.com <pa...@google.com> #2
This bug been identified as part of Chrome's flake reduction initiative. Resolution of this issue is critical because it has a large impact on the stability of Chrome CI/CQ. Resolving these issues will be essential to meet Chrome’s flake reduction goals.
This bug has led to a large number of gardened builds failing in the last 7 days. List of gardened build failures caused by this cluster can be viewed at:
https://data.corp.google.com/sites/chrome_generic_flakiness_dashboard_datasite/build_failures/?av=rpqxzw:ktu56&fb=is_sheriff_or_cq_builder:eq:true&f=cluster_name:in:b%2F400617105
or in LUCI Analysis and grouped by builders:
https://luci-milo.appspot.com/ui/tests/p/chromium/rules/3519deb73451d0c9b91241ccea2406fa?tab=recent-failures&filterToMetric=builds-failed-due-to-flaky-tests&groupBy=builder&orderBy=invocationFailures
Please consider the following strategies to mitigate the impact from this issue which are rated in order of resolution preference:
1. Resolve the underlying test issue.
2. Move the flaky test from Critical Builders to FYI Builder
3. Disable test (least desirable as it reduces test coverage) and add a Test-Disabled label to this issue. The disabled tests might continue running in reviver builders (go/test-reviver), see config [1] for a list of supported builders.
http://go/resolve-chrome-top-flakes provides more information on the tools available for resolving flaky tests.
When investigating this failure, you may identify this bug is too broad (encompasses multiple different issues) or too narrow (only captures one part of a larger issue). If this applies, you can combine issues[2] or split issues[3].
Links:
[1]https://source.chromium.org/chromium/chromium/src/+/main:infra/config/subprojects/reviver/reviver.star
[2]https://luci-analysis.appspot.com/help#combining-issues
[3]https://luci-analysis.appspot.com/help#splitting-issues
Why LUCI Analysis posted this comment:https://luci-milo.appspot.com/ui/tests/help#policy-activated (Policy ID: builds-failed-due-to-flaky-tests)
This bug has led to a large number of gardened builds failing in the last 7 days. List of gardened build failures caused by this cluster can be viewed at:
or in LUCI Analysis and grouped by builders:
Please consider the following strategies to mitigate the impact from this issue which are rated in order of resolution preference:
1. Resolve the underlying test issue.
2. Move the flaky test from Critical Builders to FYI Builder
3. Disable test (least desirable as it reduces test coverage) and add a Test-Disabled label to this issue. The disabled tests might continue running in reviver builders (go/test-reviver), see config [1] for a list of supported builders.
When investigating this failure, you may identify this bug is too broad (encompasses multiple different issues) or too narrow (only captures one part of a larger issue). If this applies, you can combine issues[2] or split issues[3].
Links:
[1]
[2]
[3]
Why LUCI Analysis posted this comment:
Description
Steps to reproduce the problem
Open Google Chrome and open a New Tab Page. Right-click anywhere on the page and select Inspect to open Developer Tools. Navigate to the Sources tab. Locate the file: chrome-untrusted://new-tab-page/one-google-bar?paramsencoded= Scroll to Line 24, where the error occurs. Observe that the @import statement is concatenated directly with the .gb_1d class without proper separation. This causes a CSS parsing issue, potentially preventing correct style application. Expected Behavior: The @import rule should be properly separated from the .gb_1d class to ensure correct parsing. Actual Behavior: The incorrect concatenation may lead to parsing errors or unexpected behavior in CSS processing. Suggested Fix: Replace the incorrect line with properly formatted CSS:
css Copy Edit @import url(' https://fonts.googleapis.com/css?lang=en&family=Product+Sans|Roboto:400,700 ');
.gb_1d {
font: 13px/27px Roboto, Arial, sans-serif;
z-index: 986;
}
Problem Description
Problem Description: I found a CSS syntax error in the Chrome New Tab Page (one-google-bar), specifically in the file:
📌 File URL: chrome-untrusted://new-tab-page/one-google-bar?paramsencoded= 📌 Error Location: Line 24
The issue occurs because an @import rule is incorrectly concatenated with a CSS class (.gb_1d) without proper separation. This violates CSS syntax rules and may cause parsing issues or unexpected style rendering in Chrome.
Problematic Code: css Copy Edit @import url(' https://fonts.googleapis.com/css?lang=en&family=Product+Sans|Roboto:400,700');.gb_1d{font:13px/27px Roboto,Arial,sans-serif;z-index:986}
🔴 Issue:
The @import statement is not properly separated from the next CSS rule (.gb_1d). This makes the CSS difficult to parse and may lead to unexpected rendering issues. According to CSS standards, @import must be on its own line, followed by a semicolon. Expected Behavior: The @import statement should be placed on a separate line to ensure proper parsing:
css Copy Edit @import url(' https://fonts.googleapis.com/css?lang=en&family=Product+Sans|Roboto:400,700 ');
.gb_1d {
font: 13px/27px Roboto, Arial, sans-serif;
z-index: 986;
}
Impact of the Issue:
Possible Rendering Issues: Styles may not apply correctly, affecting UI elements.
CSS Parsing Errors: Browsers may ignore or misinterpret styles.
Best Practices Violation: This does not adhere to standard CSS formatting guidelines.
References:
🔗 MDN Web Docs - CSS @import
🔗 MDN Web Docs - CSS Syntax
Please let me know if more details are needed. Thank you! 🚀
Summary
CSS syntax error in Chrome New Tab Page.
Additional Data
Category: UI
Chrome Channel: Not sure
Regression: N/A